From nobody Fri Oct 17 05:29:38 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cnths5M69z6CdX0; Fri, 17 Oct 2025 05:31:09 +0000 (UTC) (envelope-from Alexander@Leidinger.net) Received: from mailgate.Leidinger.net (bastille.leidinger.net [89.238.82.207]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature ECDSA (prime256v1) client-digest SHA256) (Client CN "mailgate.leidinger.net", Issuer "E8" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cnthq6qVmz3PP2; Fri, 17 Oct 2025 05:31:07 +0000 (UTC) (envelope-from Alexander@Leidinger.net) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=leidinger.net header.s=outgoing-alex header.b="NelI/r/T"; dmarc=pass (policy=quarantine) header.from=leidinger.net; spf=pass (mx1.freebsd.org: domain of Alexander@Leidinger.net designates 89.238.82.207 as permitted sender) smtp.mailfrom=Alexander@Leidinger.net List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=leidinger.net; s=outgoing-alex; t=1760679030; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EjOZivJnUaqJz1ODb9NBlEwfAh0a7A46vMJ6dyWPCzA=; b=NelI/r/T3snZlzJE8ynokAH+RaUrarilz2T6HUMnDDtxSQ5q4c9bYv2qm0MP59KT3L/P8p tNUnd+2+s4G8WT6yubI0GsHhgLomeW+5JAtC8xjB4SlmG2bS8OFTeqFtP81u/UaxHFY9ug 7LU1G+2lucw80GtYUr+ZZAvHvxJAS0vvW+U7W1L8z1MIfdfTEFokIKw99TgCFk/A/yVKUa lt2VsPhFNL5Ic8qjDH28pvDQllI9S23MUma+biUuqzWfozWQ2Az3koHJND1N/qsSiG8/1Q lxRdQP0luf+3f0cd2Bf0uhGc5Ds7Fktm5lcs+5w1wvnXXj9w7vq24I/h6wT5Cw== Date: Fri, 17 Oct 2025 07:29:38 +0200 From: Alexander Leidinger To: Rick Macklem Cc: "David E. O'Brien" , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 0050289464fa - main - style(9): white space after ; and around binary operators In-Reply-To: References: <202510162205.59GM5ZvD042942@gitrepo.freebsd.org> Message-ID: <16835444882475995d82a23078996276@Leidinger.net> Organization: No organization, this is a private message. Content-Type: multipart/signed; protocol="application/pgp-signature"; boundary="=_0ecf25361336a504c9cea98fa843239a"; micalg=pgp-sha256 X-Spamd-Bar: ----- X-Spamd-Result: default: False [-6.00 / 15.00]; SIGNED_PGP(-2.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; DMARC_POLICY_ALLOW(-0.50)[leidinger.net,quarantine]; R_SPF_ALLOW(-0.20)[+mx]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; R_DKIM_ALLOW(-0.20)[leidinger.net:s=outgoing-alex]; ONCE_RECEIVED(0.10)[]; MISSING_XM_UA(0.00)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ARC_NA(0.00)[]; HAS_ORG_HEADER(0.00)[]; DKIM_TRACE(0.00)[leidinger.net:+]; TAGGED_RCPT(0.00)[]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org,dev-commits-src-main@freebsd.org]; FREEMAIL_TO(0.00)[gmail.com]; HAS_ATTACHMENT(0.00)[] X-Rspamd-Queue-Id: 4cnthq6qVmz3PP2 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --=_0ecf25361336a504c9cea98fa843239a Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8; format=flowed Am 2025-10-17 01:29, schrieb Rick Macklem: > On Thu, Oct 16, 2025 at 4:21 PM Rick Macklem > wrote: >> >> Please be aware of the following snippets from "man 9 style": >> >> In general code can be considered "new code" when it makes up about >> 50% >> or more of the file(s) involved. This is enough to break precedents in >> the existing code and use the current style guidelines. >> >> Stylistic changes (including whitespace changes) are hard on the >> source >> repository and are to be avoided without good reason. >> >> rick > Just to be clear, I am not asking that this commit be reverted. > I am just suggesting that you be aware that style(9) changes to > extant code is not, in general, encouraged, afaik unless you are > re-writing a large portion of the code (over 50%). Does someone remember why? We have now the possibility to exclude commits from the VCS attribution of lines to commits (git blame), as such, does the reason of not doing it still hold? Bye, Alexander. -- http://www.Leidinger.net Alexander@Leidinger.net: PGP 0x8F31830F9F2772BF http://www.FreeBSD.org netchild@FreeBSD.org : PGP 0x8F31830F9F2772BF --=_0ecf25361336a504c9cea98fa843239a Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc; size=833 Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEER9UlYXp1PSd08nWXEg2wmwP42IYFAmjx1FEACgkQEg2wmwP4 2IYNUA/9H8ENxveDq507XF8WH95IElosCa6Sw4NPLT6Bic/zyMq1zfMVpVcT9v17 iUq/euXpOvCmy/3NZGpXxHi1nHOHbgVaq4rBJJO9CjKxsZDd5i3tyT1i34d/rzbA m8FCdEP2Fw/vqB9g9u9mXqhqKqcgeMsHwpKJ2iKLL+I2YOfCYATT/WDBZzz1BTO6 8BkZgIPIfp1cNBUg7K+OFEPPG9xozQRxAEp7d2n2gifrmh0Z0Ng3wg9y4ntMq/DG a18vkbrDKMaT3AszOheWfYWZELvbmPLj43Zkl5DmoxOX14coSGv7irJE9N3+TDXa +kwWfvat8csMPP2BVfHMynhBQfZfSzoNXkIwgyn0TWlQyr1DHfYdkHNxu6xyhHPp egv55XtBult+1hxoiUZfEgvDlxox3DaAz86oD/dBuH2EedJXFIVsTy0EhSKsNGCN Df7/1qVxu/KyT+Gr76v2OwqDR0YRdksL6i01QZIfAOa0+dTb1jfk3fAqfVzlvvCm 59aIY9GnzRv7ZO0XeJ/90H12FQ+v7OVI02xbtMem2gmv4a3PRQYwoyRygKFfZ6Vw alAdfjRaZV6nGnGktkSzal/zsnn5jhA2CiGkrBDKck58bnpblGjY/hB7NOmAh8Hk FoMsu5ScLQDAZbXUG8PgnJ402r4a5vaAYTE7wK6qDwsSinCP3+I= =ucXA -----END PGP SIGNATURE----- --=_0ecf25361336a504c9cea98fa843239a--