From nobody Wed Oct 15 07:25:24 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cmjKc2kHsz6CspC; Wed, 15 Oct 2025 07:25:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cmjKc24DTz3RfB; Wed, 15 Oct 2025 07:25:24 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1760513124; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9sqsiSxDqW5pRaDymBDTAPVNdi84F6Da17bNwny+YPI=; b=DSR91QPUB9CiL/wHHHzJa4D6HwyHSaql9UqM+glmJz2XRdTOjrSSIa2Ym49JwRbESAdn8t HkwEhr9ce/tbko7uP+iyu/CX5HAT5qq6thOVqb819G96R8UCFGoCcwcf8f13LpMhfGHrfA EzoeAqkfdnEppUPKtcvUBEMWeCajdHSOk1Yz92k2fIikur1xhUEeL+yQ1uggga8s85HhBH WC1yPfzaLriGGNz7YHC52opkH0xsa58x3kVWUXmhwZzLbYjgvK9Nyc0fDWNKMR/jvgnsfm 45RYG/HLAxTXtn+fQS0knIlq2ZlC1cUkJTPEVDN1Z1fJWoxh59YhEiXKh6jNcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1760513124; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9sqsiSxDqW5pRaDymBDTAPVNdi84F6Da17bNwny+YPI=; b=djefKQYn9PWb4gB3V4xieXTZf9bGrmQP8JnniwnNSpznNnYsoJhEy4Fj172oC3nLs6t4Vt cE0NUHcy/+2i15f72UWlA1R2yyc+tNQkGn61NVHfKKNfEXtDLJn0cfWrQ7PUpky7fkCzP6 oqFTGVuwTdTVy1x8yHjMfavojVt4T//+hNaZheit11nzzUWQ6pDWGDA85Uf2QBNbgsMu85 tV0so8vQafLelff2YrD3kjPdNcADhlJHFgXSCVQs+vMOB0quL2B0WFmqkAYuKYy073F7FF KH54YkJOEBqqeHMPoG6yTbvlMF5oODhR9D15yZmUVPDnuvfmsHu23iHe0e5jXQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1760513124; a=rsa-sha256; cv=none; b=ozBshbo57iH8vG6kJT4cScEGQTz66XdHQ+6PM5HZ2IkUQMQuUNMrTjEGHicImrkAFxCGm3 Kze4mwtuGPaFS8wsGyOKeiGQ8ogaxKD+hRDERZgnaOUaGz25n1P6RdHSTV1zA0qbSVfQ5g 7XHfm3duWWaSLkpkR9AiWXfr/A7TEb/LwARCFPuhDHonppo2AMyto0zefVqwiurzvQEQJZ Jqarte3N92uOdXB1ILQQTbWV6FAZoLu5U2Ot0+oLgTUn7Vnj04jindgohmTgo9lB+n+s7q pUz3xp/bGDvGp7oUxtweIJDVO3iVcjBt5Gs8m5iBnNVvxLIRXJKLFbmFSlpBuw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cmjKc1WtlzDNX; Wed, 15 Oct 2025 07:25:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 59F7PO9P072363; Wed, 15 Oct 2025 07:25:24 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 59F7POZt072360; Wed, 15 Oct 2025 07:25:24 GMT (envelope-from git) Date: Wed, 15 Oct 2025 07:25:24 GMT Message-Id: <202510150725.59F7POZt072360@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Ryan Libby Subject: git: 68501a93076a - main - mv88e151x: fix potential attach and autonegotiation issues List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: rlibby X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 68501a93076ac095be7a96ecd55d15287c497c9d Auto-Submitted: auto-generated The branch main has been updated by rlibby: URL: https://cgit.FreeBSD.org/src/commit/?id=68501a93076ac095be7a96ecd55d15287c497c9d commit 68501a93076ac095be7a96ecd55d15287c497c9d Author: Ryan Libby AuthorDate: 2025-10-15 04:01:48 +0000 Commit: Ryan Libby CommitDate: 2025-10-15 04:01:48 +0000 mv88e151x: fix potential attach and autonegotiation issues Reported by: GCC -Wmaybe-uninitialized, -Wtautological-compare Reviewed by: kp Differential Revision: https://reviews.freebsd.org/D45919 --- sys/dev/mii/mv88e151x.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/sys/dev/mii/mv88e151x.c b/sys/dev/mii/mv88e151x.c index 618ad81471c9..fb03b2a7a917 100644 --- a/sys/dev/mii/mv88e151x.c +++ b/sys/dev/mii/mv88e151x.c @@ -97,7 +97,7 @@ mv88e151x_attach(device_t dev) { const struct mii_attach_args *ma; struct mii_softc *sc; - uint32_t cop_cap, cop_extcap; + uint32_t cop_cap = 0, cop_extcap = 0; sc = device_get_softc(dev); ma = device_get_ivars(dev); @@ -224,10 +224,12 @@ mv88e151x_fiber_status(struct mii_softc *phy) else if (reg & MV88E151X_STATUS_LINK && reg & MV88E151X_STATUS_SYNC && (reg & MV88E151X_STATUS_ENERGY) == 0) { - if ((reg & MV88E151X_STATUS_SPEED_MASK) == + if (((reg & MV88E151X_STATUS_SPEED_MASK) >> + MV88E151X_STATUS_SPEED_SHIFT) == MV88E151X_STATUS_SPEED_1000) mii->mii_media_active |= IFM_1000_SX; - else if ((reg & MV88E151X_STATUS_SPEED_MASK) == + else if (((reg & MV88E151X_STATUS_SPEED_MASK) >> + MV88E151X_STATUS_SPEED_SHIFT) == MV88E151X_STATUS_SPEED_100) mii->mii_media_active |= IFM_100_FX; else