From nobody Tue Oct 14 12:22:53 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cmCzK71mtz6CLWx; Tue, 14 Oct 2025 12:22:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cmCzK5JZfz3DSc; Tue, 14 Oct 2025 12:22:53 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1760444573; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FLIosuQf8SATCRXpo4hQCMX5pvzYpa3dJQ0aE6apgYs=; b=QQcN5fHga+ojMzwv82jf38KjBQcRUnVnGkEvO+WIyq8/hxyhNy46BQuZR4gkXHJD0s4TsK oWBJPgg5vmKrr08k78AUHjGPvtC5tGyQlA+E/dMs29EitwDpfgiIYIrIchxYDSowUDFS7i wpr+gquIWASGMBUslOmNOMQSjwFuqm/f3y/gc0tMCWvGloJjHg8WIF54pWf5ivnKV3N0kJ 12mfrG8qABGDMxVAa2SXfn9v+lhhBErPCExAuE1wze7iYsPt7W+N3eo81xUQQ7qZxXC28M nba6kRMhVZqTBMviOyKl2LVFXHr5AAMbrrEM2DjWrh0YV5G+TObg5S1Rvha3pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1760444573; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FLIosuQf8SATCRXpo4hQCMX5pvzYpa3dJQ0aE6apgYs=; b=t3+/Qb9MpzJkLdYXvFVSmBJsx/CfFzsA8MoXZUh2HNfG/sQT76o59RufK2IwUWhwYMvhx3 rgPpM/P1Dh09uY+B3KarKBQLYOCboW3uRtQ2VtQeSwGwAk+uGXFgOcDAQQGZXQhg0VFcib 6ailgWZaI6Q6lCz5p7XVcbXKGN97AuzDE6C71i7TqsWpRX0yqLpH5gH44uoBlspaFOy9Vm 1MJ84PDbEqBDpJcRzNz05OC4rjYVsmJssjdQqHb6muS4BSVB8YVlrD/NjKoLs8rznG2zDR vYLum5xiC89MIJ2gnPjFvunuFw6qEm9HgH2ouAw00XgzbluUSK8ZdnQe0cad7g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1760444573; a=rsa-sha256; cv=none; b=dBmwtW+jtS+IMb3n/WMWpgmdovclln4jyvcJ7mxoQpnEf8vs2O5i4T4u77Wzsd9WVV6KGC gHCVdM+UvQwjgyVSlDb9F3e/vzKB209UNgEiAmHkTZ89/2DUXh+Wb66DASRoSG4NAq4esi QUEq3lAbTy88A4gn5Aa6hTCLUqYqRiNgrctpl8wDzPc3cVVtP3dIi5wrlEF6MNXxZ2Y+tE uCvV8IEZJDbj0qVnurt7cV1Owg2wkcJ4GAiYkRvg2yNdUCmdXr65JDaNSTRCh8YaDU/m5L j0cUabGr9O8qKAq5mk7ar3ncFjI5t2L5I3SrDH1EQKCHFuJ4eyPFCCPIPKSTXQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cmCzK43krzsp1; Tue, 14 Oct 2025 12:22:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 59ECMr0b019721; Tue, 14 Oct 2025 12:22:53 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 59ECMruh019718; Tue, 14 Oct 2025 12:22:53 GMT (envelope-from git) Date: Tue, 14 Oct 2025 12:22:53 GMT Message-Id: <202510141222.59ECMruh019718@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Olivier Certner Subject: git: 4ae70c3ea498 - main - sys/rpc: UNIX auth: Support XDR_FREE List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 4ae70c3ea498e06676040ee99254d261e29ae82e Auto-Submitted: auto-generated The branch main has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=4ae70c3ea498e06676040ee99254d261e29ae82e commit 4ae70c3ea498e06676040ee99254d261e29ae82e Author: Olivier Certner AuthorDate: 2025-10-13 15:13:09 +0000 Commit: Olivier Certner CommitDate: 2025-10-14 12:21:49 +0000 sys/rpc: UNIX auth: Support XDR_FREE xdr_authunix_parms() does not allocate any auxiliary memory, so we can simply support XDR_FREE by just returning TRUE. Although there are currently no callers passing XDR_FREE, this makes us immune to such a change in a way that doesn't cost more but is more constructive than a mere KASSERT(). Suggested by: rmacklem MFC after: 2 days Sponsored by: The FreeBSD Foundation --- sys/rpc/authunix_prot.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sys/rpc/authunix_prot.c b/sys/rpc/authunix_prot.c index c1a9f90bbe28..0274a713ff2b 100644 --- a/sys/rpc/authunix_prot.c +++ b/sys/rpc/authunix_prot.c @@ -61,6 +61,10 @@ xdr_authunix_parms(XDR *xdrs, uint32_t *time, struct xucred *cred) uint32_t junk; char hostbuf[MAXHOSTNAMELEN]; + if (xdrs->x_op == XDR_FREE) + /* This function does not allocate auxiliary memory. */ + return (TRUE); + if (xdrs->x_op == XDR_ENCODE) { getcredhostname(NULL, hostbuf, sizeof(hostbuf)); namelen = strlen(hostbuf);