From nobody Thu Oct 09 19:38:40 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cjKtX3yHXz6C1B0; Thu, 09 Oct 2025 19:38:44 +0000 (UTC) (envelope-from christos@freebsd.org) Received: from margiolis.net (mail.margiolis.net [95.179.159.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA512) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4cjKtW4wKhz3RCY; Thu, 09 Oct 2025 19:38:43 +0000 (UTC) (envelope-from christos@freebsd.org) Authentication-Results: mx1.freebsd.org; none DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=default; bh=RDBgHWyXC7cw JIqaldMiTCwzqwGY5du8syeSkWmMqEs=; h=in-reply-to:references:from: subject:cc:to:date; d=margiolis.net; b=UaDBwH1fBYohXZsxEkodAQTetAMolnL 5x+QiGbkyv2q1/pbw10hrm2K4ic4vLZInpZN/Qg5ueeiF3PXmCpS9KmXSK/KavMPcfDJ4L kDZoNvajcLtnnR7E3xckNIB+1Dmb0FC5bhZRbo6rw2c70hq5AfSFYvaFs70vf8lgOR5AUQ = Received: from localhost (public-gprs249212.centertel.pl [31.60.120.189]) by margiolis.net (OpenSMTPD) with ESMTPSA id 475646a1 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Thu, 9 Oct 2025 13:38:41 -0600 (MDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 09 Oct 2025 21:38:40 +0200 Message-Id: To: =?utf-8?q?Dag-Erling_Sm=C3=B8rgrav?= Cc: "Mark Johnston" , , , , <0mp@freebsd.org> Subject: Re: git: 9cab9fde5eda - main - virtual_oss: Port to base From: "Christos Margiolis" X-Mailer: aerc 0.21.0 References: <202509280958.58S9wrww083342@gitrepo.freebsd.org> <861pnf83kw.fsf@ltc.des.dev> <86frbs6ivg.fsf@ltc.des.dev> In-Reply-To: <86frbs6ivg.fsf@ltc.des.dev> X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:20473, ipnet:95.179.144.0/20, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4cjKtW4wKhz3RCY On Thu Oct 9, 2025 at 8:16 PM CEST, Dag-Erling Sm=C3=B8rgrav wrote: > Christos Margiolis writes: >> Mark Johnston writes: >> > Well, it'll break the test added in https://reviews.freebsd.org/D52954= , >> > which will be useful for catching bugs. >> If I understand correctly, the test is meant to catch dependency cycles? >> If yes, why would we have one here? > > This does not cause a cycle but it does cause a warning from rcorder, > which causes the test to fail. > > The test can be changed to use `-e not-match:"circular dependencies"` > instead of `-e empty` to avoid triggering on the sndiod warning, but I > still think it's wrong to encode knowledge of a specific port in base. > > I would suggest that you change virtual_oss to have `BEFORE: DAEMON` and > sndiod to have `REQUIRE: DAEMON` instead. This does not change the > start order for the base system (virtual_oss was already being started > before DAEMON) but ensures the correct sequencing of virtual_oss and > sndiod without recording a false dependency between them. > > DES I like this idea. The sequence we want is to first run sndiod and then virtual_oss. I am not really experienced with rc scripts, but don't we want the opposite from what you are proposing? As in, BEFORE: DAEMON for sndiod, and REQUIRE: DAEMON for virtual_oss, so that sndiod starts before virtual_oss. It is very possible that I have things mixed up. :-) Christos