From nobody Thu Oct 09 18:16:19 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cjJ3V3gsJz6BtTl; Thu, 09 Oct 2025 18:16:22 +0000 (UTC) (envelope-from des@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cjJ3V2cw3z3K1v; Thu, 09 Oct 2025 18:16:22 +0000 (UTC) (envelope-from des@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1760033782; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iAOx810Xol9cemWikQsMN0f5T6a7a+pgMaLliI/feBY=; b=AooHXFkMoSdY4YqzmXTbR0ayME6RYQXnFoK9eNlH7+mOg8e3sIOYg7w8oe0tnCRL6hfXD+ WzjuWMxL0VdcQ5bll28DGbBUfXZF+RxXC+L8uIubgYi5r6Lx2wdNFZawqrCdRjitUUblAy Npv1vk3HPsNFh/0hkKgYQRg5q2t2wL5RU7dAqIEN143GCDn2+XO6JeCMDQM7j1OdyIbUW3 JK2lbFbwZ4JxE5exv7hHotbDLybZnKmNZ67of+PZniksk3JEnQSwAV20T+oKTxcIB95+M7 ZtOpudLCxyBbFJJQGGreEJ1S/ED5xvtAQJLmEGoxQTq4mF/0Xgn7FP3Xne0q6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1760033782; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iAOx810Xol9cemWikQsMN0f5T6a7a+pgMaLliI/feBY=; b=h2teeSK2rvLgtUFCqfybiYMW5CbZBzgLF6c70BRF67liLYXm8GjR5KWjlBU+0U4Z+2RFGE pYLKCPFgi2ZwgNHqY67iwpGxn1oC09RFaLmSDjEZRyB4zg0x2kbJ3bgVrjeOdGeW0FjHIl y1QcUNUzu0ypDBUZLgnTKy3kJl2Ab04ZJz/zKtRmPqhLJ8dQ4Lc3OBssAhQN3fzgaYiPuu B97ghff4oZRUxgGe6Zz6Ny4V7lxl2iPNQ+V3XeoAMZ0Q9W5WHSXVLWDBYAWOdD7NqGiWJ4 U00NfEcPYo8C0SOGelvSjA3yq6sEUs4b4QPnMxeemLA1pHFLVDfPPXiAyzKTkA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1760033782; a=rsa-sha256; cv=none; b=hGpH1XBARKmISaiGiraZJjCgbPLPfHIGDf4PU2bYfIT0Sj55qScJIMfeBBz9zQWzIR7Rmf mZkWPOyVFCY4XtXTjCyCgeSZBE9OgSStlmlB+M3U8imdVgPepwHtbiDSe8qMI8OTNNWlqw 6dMe4Ldc7HQP6hYwAxThBXCn191PFS5cgV47YN7jh7Ig7jdeVGCFLZpxHAiH8Z94NR/aMs ySfkhymFNPPUHsWhhPgaTCwCh7z2/N/VSBQgDsrMMpfI/WbVf6zGzghReoKhVPr7Ojm8Tq 7yUFOiIOXSLqxpUo5hWCz1etuIQGFz1N081pfnZcv50ZhsiWsZoHRaDU/D8EMA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from ltc.des.dev (unknown [IPv6:2a01:e0a:c54:bed0:922e:16ff:fef1:acef]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: des) by smtp.freebsd.org (Postfix) with ESMTPSA id 4cjJ3V1DZzzKCb; Thu, 09 Oct 2025 18:16:22 +0000 (UTC) (envelope-from des@freebsd.org) Received: by ltc.des.dev (Postfix, from userid 1001) id EB44588474; Thu, 09 Oct 2025 20:16:19 +0200 (CEST) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: "Christos Margiolis" Cc: "Mark Johnston" , , , , <0mp@freebsd.org> Subject: Re: git: 9cab9fde5eda - main - virtual_oss: Port to base In-Reply-To: (Christos Margiolis's message of "Thu, 09 Oct 2025 19:41:22 +0200") References: <202509280958.58S9wrww083342@gitrepo.freebsd.org> <861pnf83kw.fsf@ltc.des.dev> User-Agent: Gnus/5.13 (Gnus v5.13) Date: Thu, 09 Oct 2025 20:16:19 +0200 Message-ID: <86frbs6ivg.fsf@ltc.des.dev> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Christos Margiolis writes: > Mark Johnston writes: > > Well, it'll break the test added in https://reviews.freebsd.org/D52954, > > which will be useful for catching bugs. > If I understand correctly, the test is meant to catch dependency cycles? > If yes, why would we have one here? This does not cause a cycle but it does cause a warning from rcorder, which causes the test to fail. The test can be changed to use `-e not-match:"circular dependencies"` instead of `-e empty` to avoid triggering on the sndiod warning, but I still think it's wrong to encode knowledge of a specific port in base. I would suggest that you change virtual_oss to have `BEFORE: DAEMON` and sndiod to have `REQUIRE: DAEMON` instead. This does not change the start order for the base system (virtual_oss was already being started before DAEMON) but ensures the correct sequencing of virtual_oss and sndiod without recording a false dependency between them. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@FreeBSD.org