From nobody Thu Oct 09 17:41:22 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cjHHL1SzQz6BqhP; Thu, 09 Oct 2025 17:41:34 +0000 (UTC) (envelope-from christos@freebsd.org) Received: from margiolis.net (mail.margiolis.net [95.179.159.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA512) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4cjHHK04BJz3F3m; Thu, 09 Oct 2025 17:41:32 +0000 (UTC) (envelope-from christos@freebsd.org) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=margiolis.net header.s=default header.b=NNo6AfSs; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=freebsd.org (policy=none); spf=softfail (mx1.freebsd.org: 95.179.159.8 is neither permitted nor denied by domain of christos@freebsd.org) smtp.mailfrom=christos@freebsd.org DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=default; bh=RGNfjL3sQJYa zhGI3gAMocf8oUPX0lY3ENFgr01SejQ=; h=in-reply-to:references:subject:cc: to:from:date; d=margiolis.net; b=NNo6AfSs50uCZhW/8BekkOjOStZbNZm0nYMqW PrKjGCM7dgTiXq9lUbaPasmbGfCpTMWIryIMZT1KIRAX+5tTV3goL2Z7PJW4swzLAinOS5 D4fmV5ok+2/7Fd7IYCnptdpdtN0Dwbd8JW9EEqILo0VcjOdg5AuLgQImpvf0X2Xk= Received: from localhost (public-gprs249212.centertel.pl [31.60.120.189]) by margiolis.net (OpenSMTPD) with ESMTPSA id 1d29025d (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Thu, 9 Oct 2025 11:41:24 -0600 (MDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 09 Oct 2025 19:41:22 +0200 Message-Id: From: "Christos Margiolis" To: "Mark Johnston" Cc: =?utf-8?q?Dag-Erling_Sm=C3=B8rgrav?= , , , , <0mp@freebsd.org> Subject: Re: git: 9cab9fde5eda - main - virtual_oss: Port to base X-Mailer: aerc 0.21.0 References: <202509280958.58S9wrww083342@gitrepo.freebsd.org> <861pnf83kw.fsf@ltc.des.dev> In-Reply-To: X-Spamd-Bar: -- X-Spamd-Result: default: False [-2.70 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.999]; MV_CASE(0.50)[]; R_DKIM_ALLOW(-0.20)[margiolis.net:s=default]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : No valid SPF, DKIM not aligned (relaxed),none]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; ASN(0.00)[asn:20473, ipnet:95.179.144.0/20, country:US]; TO_DN_SOME(0.00)[]; FREEFALL_USER(0.00)[christos]; RCVD_COUNT_ONE(0.00)[1]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org,dev-commits-src-main@freebsd.org]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_FIVE(0.00)[6]; R_SPF_SOFTFAIL(0.00)[~all:c]; RECEIVED_HELO_LOCALHOST(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_TRACE(0.00)[margiolis.net:+] X-Rspamd-Queue-Id: 4cjHHK04BJz3F3m On Tue Oct 7, 2025 at 4:10 PM CEST, Mark Johnston wrote: > On Tue, Oct 07, 2025 at 03:48:26PM +0200, Christos Margiolis wrote: >> On Tue Oct 7, 2025 at 11:26 AM CEST, Dag-Erling Sm=C3=B8rgrav wrote: >> > Christos Margiolis writes: >> >> libexec/rc/rc.d/virtual_oss | 119 + >> > >> > This contains a reference to a non-existent sndiod service. >>=20 >> I am aware. I discussed this with 0mp@ during EuroBSDCon in Zagreb and >> decided that it probably does not hurt too much to leave it there, at >> least for now. > > Well, it'll break the test added in https://reviews.freebsd.org/D52954, > which will be useful for catching bugs. If I understand correctly, the test is meant to catch dependency cycles? If yes, why would we have one here? >> It's important to note that for most users sndiod actually is not >> needed. This is only needed when virtual_oss(8) runs with sndio support, >> which has been moved to a new port: audio/virtual_oss_sndio. > > Why not just modify the sndiod script to REQUIRE virtual_oss? Why REQUIRE and not BEFORE? virtual_oss is not *required* for sndiod to run, and vice-versa. sndiod is required by virtual_oss(8) only when virtual_oss(8) wants to use sndio devices. Christos