From nobody Thu Oct 09 17:07:41 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cjGXF5nLhz6Bmv1; Thu, 09 Oct 2025 17:07:41 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cjGXF4xYfz47w4; Thu, 09 Oct 2025 17:07:41 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1760029661; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BPUiCHlQLFf4cL7JDZ9zS02ckju2+SyKU0ZRKa6x+V4=; b=CmJojS4cD5IxGT34X3p9LrsozzNURYuQl1GKSfQU1Qewf+yfevfvXu7ARlSzbu4v99ELdM 7poTX1zSYaQvDBsFrSvQHVfOWQvMUraJISXNeur3fxEqFYx66AEM5Pl7NfpMQ01w4xY05M MbkpKefkzFU6mmUtue5zzrDSTD56Mou207iHODowpU/9s/5QwWfyutw/vEuiGxxVi7Jo02 xTVLj7jQeqWYAQ7KKBE1Vce8/EMdSBs/qIOBwX1W2AXFPo0qxDmdb37bwIbF7giiodMP0q OlyxFfcJ2TadtC5Q8OXT03p3qA+r/RubvzWdHXqqLEdFMqYKiBz4/403NcvF9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1760029661; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BPUiCHlQLFf4cL7JDZ9zS02ckju2+SyKU0ZRKa6x+V4=; b=DCPzdoB+I4a5Fy4//90AOBttof9oVpsgagBRJG7DNaQGeFSZN7pL9qDg5JZ97ipcrP/PuM Z82HLR227SgNzLxPmCDj2D8GhZtzCTTfA5MtBZqiTW0dcLXEggkgXHLUmSVfndshqbOykS xDRBezJ64OBqTxnrfo61J/LwCCjXdPrgbKX3Wn0e2dfutjIYnRc1gaZEQcaXazxJt0lG9l c8OsBp19aKI2ehvTotTW7PSpIqheNfJTj283wBYEs2G9tcGne8tqV+esUpSrJzKYAoSWvs b0sXO5sxz7zH3ppDtBhdauL5kn+bhiFS9nqdQ2mWjzAiFq+qgmgzZuIV9RwzrA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1760029661; a=rsa-sha256; cv=none; b=JeefwBjfk9CMgbXx0KAP2a6vF/UuQ9GA9u77AtCqUtgoojeSX+Y2n913/Z/z2UxGw+HwkY qqGHb+u76RCJAUorsGbsQFFvsIglk+2UuUf0QwW02X9E3U2Xsd/s35GSqlNE0KuWEmVzW4 0Cq0FGXtaRwVtOxzJvq5gEQDzr+bcPa5wV8MT0GDZ8g3K1VbLRTRIjxAlfb+NKmex2gtFu PKd7ojgf/jrGw+AvjQIq9MyZZWgUsvRgT8VXPFF8Jh0078j73igCSu6hBV2pf97BXD7ksL HHnKvDgq+BRXbkc0za24hgjhEsnpEwTVxWYsIc/3GlbsSNCKUerroN9SW1BeRg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cjGXF4JhWzB7m; Thu, 09 Oct 2025 17:07:41 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 599H7fYL082754; Thu, 9 Oct 2025 17:07:41 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 599H7foI082751; Thu, 9 Oct 2025 17:07:41 GMT (envelope-from git) Date: Thu, 9 Oct 2025 17:07:41 GMT Message-Id: <202510091707.599H7foI082751@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Olivier Certner Subject: git: 75eb6846269b - main - nfsuserd: Fix OOB access on membership of too many groups, take 2 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 75eb6846269bb9bec1eaf4f0ad93d7525715b550 Auto-Submitted: auto-generated The branch main has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=75eb6846269bb9bec1eaf4f0ad93d7525715b550 commit 75eb6846269bb9bec1eaf4f0ad93d7525715b550 Author: Olivier Certner AuthorDate: 2025-10-09 17:03:11 +0000 Commit: Olivier Certner CommitDate: 2025-10-09 17:06:57 +0000 nfsuserd: Fix OOB access on membership of too many groups, take 2 Forgot to reset 'ngroup' after one of the calls to getgrouplist() in the previous commit with same title (referenced also below). MFC after: 1 hour Fixes: e6c623c86ab4 ("Add support for the "-manage-gids" option to the nfsuserd daemon.") Fixes: bb339adfb2a2 ("nfsuserd: Fix OOB access on membership of too many groups") Sponsored by: The FreeBSD Foundation --- usr.sbin/nfsuserd/nfsuserd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/usr.sbin/nfsuserd/nfsuserd.c b/usr.sbin/nfsuserd/nfsuserd.c index 0e5c9c8f1e50..058253beaf95 100644 --- a/usr.sbin/nfsuserd/nfsuserd.c +++ b/usr.sbin/nfsuserd/nfsuserd.c @@ -629,6 +629,7 @@ nfsuserdsrv(struct svc_req *rqstp, SVCXPRT *transp) syslog(LOG_ERR, "Group list of user '%s' too big", pwd->pw_name); + ngroup = NGROUPS; } nid.nid_ngroup = ngroup; nid.nid_grps = grps;