Re: git: 84f981ba57e7 - main - nullfs: shrink null_node to 32 bytes

> > For the hash to be at all useful the chains are supposed to be short.
> >
> > Or to put it differently, a sensibly sized hash with a sensible
> > hashing function makes it automatically fine.
> >
> > This was worthwhile to do because the original size of 40 bytes is a
> > very poor fit for the allocator.
> >
> > fwiw the namecache already works this way for few years.
> >
> > the regular vnode hash should probably get the same treatment, saving
> > 8 bytes off of struct vnode
> 
> I can concede it would make sense to include this in the commit message.

That's a reasonable trade-off, but it's important that such choices are explained in the commit message and/or code comments.

Next time, please consider putting up Phabricator reviews even for such "small" changes, where we would have had the opportunity to mention this before commit.

Thanks and regards.

-- 
Olivier Certner