From nobody Mon Oct 06 16:03:36 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cgPFh6rpKz69ZgQ; Mon, 06 Oct 2025 16:03:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cgPFh6Ml6z3jgY; Mon, 06 Oct 2025 16:03:36 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759766616; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=G0Kc4XA1E4akG7jgYkye1Ammb81sgVSsXKK/cLnNdG4=; b=fANLbptCEkaEEAXoS+Ez+QbkWY3GiXVfVpwBnXZ1IhX/bJ8q6fKqZlXMLru1XuUEfjIi2D yj2s3I8KRPvtrUn36c5P11unndJ4wWGH28NoBfHM/EJ8L8oA2dR2J7Ithmb0fbhgdnE/C+ pR1lwFU96Fn/fTiGySLD4Fu5pjdtIFxjpb5zRGj1rrD9tD/2430hATftsddY3QMpNecACH 7VCDe8HImEvXygYvSBzXermdbV63U+VLB9IZF2V+XGySmr2oPaft+vJBgkzr5IPZVU5bXr X+Y8xlsh8dyTiGoX3ox9HMBMhaWz6px5flQumy4TvV50p5lECbjTSyLggTkEfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759766616; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=G0Kc4XA1E4akG7jgYkye1Ammb81sgVSsXKK/cLnNdG4=; b=PRFjiVCSiZmuA83tmr04/WIq1PQkB8mH4yYXlTCcx6rB5/yLyhwT1whvO6fHP0lWH7MAV4 hKnFtwj4MRSyBItnht4WQGCooy/WL15aGUz6G3qVZDA9yl9Oq3c52kaOYlQkDa/uaUxETs 60vBuHjj6LgPHrv2K/wneKIkfnIdylsgzdx+14H2AZbx7D598zNd1+26cUAHqASGXGtbB+ HN1K1848f2IdoCcNMCjJeDxlyCrhplZx5ZH8kdUwUSzAqKYIwwn90qXz3DAckDe0LfWEIX fpj5iOSvtsg7IQfCYwyLpWYRUgXWvnn55dIsxSr+kBqAL6XcArtlHujZf1eIxQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1759766616; a=rsa-sha256; cv=none; b=vi2fQXb+TdYbFBFVxkxOgRJcTYU9C0RuqwbXK84nLYATHhl7bW3Cg1FvoSoyNAOtk2fZI+ WHxL09tRj1zHj9MDoy+e9gX0ay66JGD4KloDxJZiI6pHQUCOD2u9a9JeOY9V2ep8ykgAL0 yQEDyByqVn664I9oQy9sN7o9nDS2SW+D0dY8+blzSQKjwrwOuiYf3oRjzdxB5/JdV0x4kR bPZKalMv2hTi6WqjAOmf4hw34aqgX3KpZ0F/GuMuDCwfjTKpqC0hwcPmuA/iWZNjTTsUfe kD0x2hAV0K+ndPUG/bPw6/XCEjeXfzblyZAzDdnOZrqBsixDCySh9W50YnZt7A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cgPFh5xrbz14wH; Mon, 06 Oct 2025 16:03:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 596G3aqH020891; Mon, 6 Oct 2025 16:03:36 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 596G3aD9020888; Mon, 6 Oct 2025 16:03:36 GMT (envelope-from git) Date: Mon, 6 Oct 2025 16:03:36 GMT Message-Id: <202510061603.596G3aD9020888@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: "Jonathan T. Looney" Subject: git: 5e1611a37a02 - main - x86: Defer non-fatal MCA message output from the HW interrupt context List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jtl X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 5e1611a37a02076180ccea1506713b8c9628779e Auto-Submitted: auto-generated The branch main has been updated by jtl: URL: https://cgit.FreeBSD.org/src/commit/?id=5e1611a37a02076180ccea1506713b8c9628779e commit 5e1611a37a02076180ccea1506713b8c9628779e Author: Jonathan T. Looney AuthorDate: 2025-10-03 18:26:37 +0000 Commit: Jonathan T. Looney CommitDate: 2025-10-06 16:00:26 +0000 x86: Defer non-fatal MCA message output from the HW interrupt context When processing recoverable MCA events in a hardware interrupt context, defer logging the messages to a task queue. Reviewed by: markj MFC after: 2 weeks Sponsored by: Netflix Differential Revision: https://reviews.freebsd.org/D12275 --- sys/x86/x86/mca.c | 41 ++++++++++++++++++++++++++++++++++------- 1 file changed, 34 insertions(+), 7 deletions(-) diff --git a/sys/x86/x86/mca.c b/sys/x86/x86/mca.c index 933d10e52187..e43c88b3a27b 100644 --- a/sys/x86/x86/mca.c +++ b/sys/x86/x86/mca.c @@ -131,6 +131,7 @@ static STAILQ_HEAD(, mca_internal) mca_pending; static int mca_ticks = 300; static struct taskqueue *mca_tq; static struct task mca_resize_task; +static struct task mca_postscan_task; static struct timeout_task mca_scan_task; static struct mtx mca_lock; static bool mca_startup_done = false; @@ -1017,6 +1018,16 @@ mca_process_records(enum scan_mode mode) { struct mca_internal *mca; + /* + * If in an interrupt context, defer the post-scan activities to a + * task queue. + */ + if (mode != POLLED) { + if (mca_startup_done) + taskqueue_enqueue(mca_tq, &mca_postscan_task); + return; + } + mtx_lock_spin(&mca_lock); while ((mca = STAILQ_FIRST(&mca_pending)) != NULL) { STAILQ_REMOVE_HEAD(&mca_pending, link); @@ -1024,10 +1035,19 @@ mca_process_records(enum scan_mode mode) mca_store_record(mca); } mtx_unlock_spin(&mca_lock); - if (mode == POLLED) - mca_resize_freelist(); - else if (mca_startup_done) - taskqueue_enqueue(mca_tq, &mca_resize_task); + mca_resize_freelist(); +} + +/* + * Emit log entries and resize the free list. This is intended to be called + * from a task queue to handle work which does not need to be done (or cannot + * be done) in an interrupt context. + */ +static void +mca_postscan(void *context __unused, int pending __unused) +{ + + mca_process_records(POLLED); } /* @@ -1110,13 +1130,16 @@ mca_startup(void *dummy) if (mca_banks <= 0) return; - /* CMCIs during boot may have claimed items from the freelist. */ - mca_resize_freelist(); - taskqueue_start_threads(&mca_tq, 1, PI_SWI(SWI_TQ), "mca taskq"); taskqueue_enqueue_timeout_sbt(mca_tq, &mca_scan_task, mca_ticks * SBT_1S, 0, C_PREL(1)); mca_startup_done = true; + + /* + * CMCIs during boot may have recorded entries. Conduct the post-scan + * activities now. + */ + mca_postscan(NULL, 0); } SYSINIT(mca_startup, SI_SUB_KICK_SCHEDULER, SI_ORDER_ANY, mca_startup, NULL); @@ -1176,6 +1199,7 @@ mca_setup(uint64_t mcg_cap) TIMEOUT_TASK_INIT(mca_tq, &mca_scan_task, 0, mca_scan_cpus, NULL); STAILQ_INIT(&mca_freelist); TASK_INIT(&mca_resize_task, 0, mca_resize, NULL); + TASK_INIT(&mca_postscan_task, 0, mca_postscan, NULL); mca_resize_freelist(); SYSCTL_ADD_INT(NULL, SYSCTL_STATIC_CHILDREN(_hw_mca), OID_AUTO, "count", CTLFLAG_RD, (int *)(uintptr_t)&mca_count, 0, @@ -1579,6 +1603,9 @@ mca_intr(void) panic("Unrecoverable machine check exception"); } + if (count) + mca_process_records(MCE); + /* Clear MCIP. */ wrmsr(MSR_MCG_STATUS, mcg_status & ~MCG_STATUS_MCIP); }