From nobody Sun Oct 05 21:22:00 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cfwMY07Rbz6BjV3; Sun, 05 Oct 2025 21:22:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cfwMX5FH7z46yy; Sun, 05 Oct 2025 21:22:00 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759699320; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=LL7FlAmAgGKBATie/0vSBEeYl3Y+pXqBCtQdMbZI2yE=; b=Fdqsfe0NizptiUd/m2qN56btQgpmrm0FCUcShVIbsj/3kbk3pOABwgNmwcbXOgsh+2CaOt TwM2TB8jNEfKHoEvqbhdjZJvRe8UMzeUgBjte1nRd5Z8RQlOEYGBdLGkVQnezHdrdJxIon wbJ7YxndpA3lQQ5AfEuI1X+ZG/UtBWIQ0V6lxN5peDE74ZnE8YgEcKaYY1V6pWiCNJpOhy 01YGbca8M6/Ek+yAENTqFhMpN5ml90a+yv9coBVNOTuE9zR0ZizQ+O3PCaQ9v/YMLtfxmA KgWhQIjqUS0yFSdSj3q5dHb86Myo0NE+2eHiebklc6jBnr+mKYRnqFo3NGFMXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759699320; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=LL7FlAmAgGKBATie/0vSBEeYl3Y+pXqBCtQdMbZI2yE=; b=TpcRohvjCawmIj+tAy0BLMty32VRWk1PAbHN2+nZc35WKAjbqkU8X2/QUK2qRMaDjAlpuX 3cdfkjcMmYu5oOMfxrNYI+cqi+XgHHTnjvEcjmwDyoHU0Vl/v3wZXU0BA8iVU9Z0POEkjP 8fVzR0xS2Ta1kF2mhVyoZN/7zKVw3dnJKzcGap3WrZVAG68540t/VS42qKyxm5FIeZB3Zn RI8X14/6RxTnn+NT10sRZ1QQ/EUwymFcvAN0imusHX3H3Ue3/RQe3ud2N5JQX+AyhfDyAi 1r5qaQuGQvtk4N2Sa6WnFJD3CRM2ki9/JkaDX1Fy2A+qtu782Y0pwAs5Y6cgjw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1759699320; a=rsa-sha256; cv=none; b=jonpMbYemsZnXI05PCMcS5rqwtpu/qmrUp4Xhxh9tFu/4ZVOWDMh13+YtYAi+JFaAqYYNS nUyOj3JZqKmnu5SXxFN8EdYfjpFPctMXUU4O+jpf5vyQPtzkkx7TFQr/AedL45r0kyZ6f3 NQ+nM1wbX6zAIZz840gJ/x/bTtewFWDCJ9l/B2h19S9hxd4PSNjPuzWiIxOAE7iZj7cTBf cIc8ipUdnY/19d5ZpF4HqRR2CCW4o9+SV59DAtd7OJeESGEhUIjBh3+ybGhon5O8Xa4xrS CDF1LKDtfUT8ptAOD+tj8eeCShGbzKqGfnuEiJurNsT2/pDVV7q/rfJ4r0UxCA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cfwMX4mFCzDMv; Sun, 05 Oct 2025 21:22:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 595LM0Hq099139; Sun, 5 Oct 2025 21:22:00 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 595LM03K099136; Sun, 5 Oct 2025 21:22:00 GMT (envelope-from git) Date: Sun, 5 Oct 2025 21:22:00 GMT Message-Id: <202510052122.595LM03K099136@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mateusz Guzik Subject: git: f16178e0bba8 - main - vfs foffset: drop weird commentary about offset protection List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mjg X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: f16178e0bba81c32b1f4fba310c7d0f2756aca85 Auto-Submitted: auto-generated The branch main has been updated by mjg: URL: https://cgit.FreeBSD.org/src/commit/?id=f16178e0bba81c32b1f4fba310c7d0f2756aca85 commit f16178e0bba81c32b1f4fba310c7d0f2756aca85 Author: Mateusz Guzik AuthorDate: 2025-10-05 17:02:01 +0000 Commit: Mateusz Guzik CommitDate: 2025-10-05 21:21:10 +0000 vfs foffset: drop weird commentary about offset protection It is readily apparent the FOFFSET_LOCKED flag protects it because the read followed its use. It also does not matter who said how it was protected earlier. Reviewed by: kib, markj Sponsored by: Rubicon Communications, LLC ("Netgate") Differential Revision: https://reviews.freebsd.org/D52915 --- sys/kern/vfs_vnops.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/sys/kern/vfs_vnops.c b/sys/kern/vfs_vnops.c index 3d4567b6ab1e..c2a669dc771a 100644 --- a/sys/kern/vfs_vnops.c +++ b/sys/kern/vfs_vnops.c @@ -864,10 +864,6 @@ foffset_lock(struct file *fp, int flags) FILE_V_FOFFSET_LOCK_WAITING); } - /* - * According to McKusick the vn lock was protecting f_offset here. - * It is now protected by the FOFFSET_LOCKED flag. - */ return (atomic_load_long(&fp->f_offset)); }