From nobody Sat Oct 04 03:02:30 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cdr1L6YYGz69vB0; Sat, 04 Oct 2025 03:02:30 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cdr1L4Kxdz3pjJ; Sat, 04 Oct 2025 03:02:30 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759546950; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Qb1A9qjHcwtkHKP2xqON4fa1cBQoAAAfoPcQl+F/wrE=; b=ryjtq5REnYKf6qFvMTL3UbLHY9howG+fv8jjVK1TJoiIXxmOjP30tjgM6vSlmsf4UDXEko FKi4Lvl7i0ntqEAtyVVPBKFy282B+ZbCP7mcY2KHklIbKX4DmpVp/sk10V0RhgGUnrex37 ooi4abRKyEJFmbTN/Dt19BOta7gbZOVp5KzH/+OJQrvFcgiL5czgVe24jpcwuGtHmPksjG LFP9m6x9eXqIwDeLRtIe4eymCvRi9Lh/leUiDDO+epgFq05bBPm0Km4O4wCRyK9tBWC2Nn ATp/nVGIHuosJtTWj4/aKh7ACSyNR537a/uGlFq0ZPelv6salgWD+D/KtA8MIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759546950; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Qb1A9qjHcwtkHKP2xqON4fa1cBQoAAAfoPcQl+F/wrE=; b=mhft2pgX/wqEbz33QdIdqhIwizZBPsy79UqPB72aSyE9q6Pu/eDel3e3BlVnggCxP0iATW 4kp7TS7sqjCd54iO3O2/pDEJp9XasH3uIdkhUE9XbbeGayduVesSRr0lkCeW91oaJvJOT6 wjZTnghKxA4egX4Qbr5uMUOxEn/gY6LRzP5Fz6fce/3H3CkdQvinh4Fg/ruXYH1K8M+vBw H4MQhx5paM3iZ+XSPG1lp13rD9vZcioGPqNeFMI8jE4rFdh/pdVgXqdHGIrfHgR36po57W FsxLevw1hdo08Mhb4D0+KceWSXRl4oiReTkNjl6iXmUB0wUmOsKCUr9ybTUS2A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1759546950; a=rsa-sha256; cv=none; b=c4LRPVYTt9komlOu4A28AhLa32f+KjEv0lkMH+kDIDHXikDTBdJE74U9QEKpPiNiado4Lx PX+DXLFzAQ+e2LqskE9ed1znFL7ayC6CH++FC75n05+EPJhnFsaRPTciBNbKGPw1hHJn0a tGkTx9ZQCUFacKIPN0b+7HHz0Ec4sJ459fBe/z1a+c5Jidmm5Qnas1c1Po10EQfO9JDSIN CkHK5xWV8pSquTWR4w2CYdk9IxfUKBKRsA3iShs0Rks9PqsM0OmsB7aUKpXTrk8J8M4FtW ESpG0G375IxINNfhO/jwdXdhcAAjFon2WCwnOpvkft1UW+JfybTDjIyyH58l5A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cdr1L3sv7z7FS; Sat, 04 Oct 2025 03:02:30 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 59432UgJ014916; Sat, 4 Oct 2025 03:02:30 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 59432UNG014913; Sat, 4 Oct 2025 03:02:30 GMT (envelope-from git) Date: Sat, 4 Oct 2025 03:02:30 GMT Message-Id: <202510040302.59432UNG014913@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Adrian Chadd Subject: git: 88f467bd1a11 - main - iwx: don't log VHT rate lookups in iwx_tx_fill_cmd() for data frames List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: adrian X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 88f467bd1a113b65cebcb6eca145dbd3bea72adc Auto-Submitted: auto-generated The branch main has been updated by adrian: URL: https://cgit.FreeBSD.org/src/commit/?id=88f467bd1a113b65cebcb6eca145dbd3bea72adc commit 88f467bd1a113b65cebcb6eca145dbd3bea72adc Author: Adrian Chadd AuthorDate: 2025-09-28 03:13:06 +0000 Commit: Adrian Chadd CommitDate: 2025-10-04 02:55:40 +0000 iwx: don't log VHT rate lookups in iwx_tx_fill_cmd() for data frames iwx is now logging a lot of stuff to the kernel when associated at VHT rates. It's my fault; the replacement tx rate APIs print out a warning when you're handing the legacy rate /HT rate APIs a VHT rate. However all of the supported chipsets in iwx will be pushing the rate control entirely into firmware. We don't need to do per-frame TX rate control like in previous chips. So for now, just put in an if (rate == VHT) into the path and a TODO comment. A few lines later the function will just skip the rate assignment stuff for data frames, thus saving us the logging. The other paths (control traffic, multicast traffic) uses legacy rates / HT rates by default and won't trigger a warning log. Yes, iwx_tx_fill_cmd() really does deserve a rate control logic rewrite, but I want to fix this particular issue first. Locally tested: * AX210, STA mode, HT and VHT associations Differential Revision: https://reviews.freebsd.org/D52766 Reviewed by: thj --- sys/dev/iwx/if_iwx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sys/dev/iwx/if_iwx.c b/sys/dev/iwx/if_iwx.c index 557b5a7a1ca2..d2d435545e27 100644 --- a/sys/dev/iwx/if_iwx.c +++ b/sys/dev/iwx/if_iwx.c @@ -5501,6 +5501,9 @@ iwx_tx_fill_cmd(struct iwx_softc *sc, struct iwx_node *in, /* for non-data, use the lowest supported rate */ ridx = min_ridx; *flags |= IWX_TX_FLAGS_CMD_RATE; + } else if (ni->ni_flags & IEEE80211_NODE_VHT) { + /* TODO: VHT - the ridx / rate array doesn't have VHT rates yet */ + ridx = iwx_min_basic_rate(ic); } else if (ni->ni_flags & IEEE80211_NODE_HT) { ridx = iwx_mcs2ridx[ieee80211_node_get_txrate_dot11rate(ni) & ~IEEE80211_RATE_MCS];