From nobody Sat Oct 04 03:02:28 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cdr1J38bcz69tkH; Sat, 04 Oct 2025 03:02:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cdr1J2jtGz3plL; Sat, 04 Oct 2025 03:02:28 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759546948; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=4dKLdvxaOgJxgjINGK0PUbQI6NlV7naIGRc4rLoLZPo=; b=SdzcLI7YxqXNVaukJyI8zx9SOojrnlFJZ1LPYiZMgLkYTkp2T/8DDIwcqIp0DW8CODC25S vTM+E+C1RCSbMTegg8Hmeivl2rhwjJqxNr7z/6lb2Y/Bh6x9qGjp5Le+D2zWIxLdvon8Mf Z9pycNyrGCP+QhJUmlBc2iSd9UBAP4XNrwj+Cv/2Klw5O/OflqaOTiWAK4aibIbGT9ckjT yYlAJKsCOmtaIPnZNCZ8rgzz2vwgYsZ0pYxbDYXdLcTqv/i/eQp4ZHHQb0pgxxpc3mF3SA GjCaKUOFlrXKIVxDWqT2uJ78eHy1K6a0GDGw7xuiCEnIl8EXVu9QltDxZZhUIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759546948; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=4dKLdvxaOgJxgjINGK0PUbQI6NlV7naIGRc4rLoLZPo=; b=JGr4ljdj4HoxBtqKo8+0041MCkCIiKj8ftZDp3JOm6sde6cBtz94bV7Y0pzuOq83/yCEiq GdJsgr/hSx5FlAVlo7i8MIatDf7RQO0caNtj7OF0y3mbN/PjbpsF5lA5jPC5J3pWhhEDpO 7ugBQS3J/ijuPUZGM6AN3cmCN+hBywxQ5zj2dm/YNr+HZ4/iebnE9znzn8Z7xfKtnWfcZg qKNnUJATUJEA8wqEOvhhaHI1ZoxoTDQvZOOyb0M161vC6Y6qtIQM+4RoXHQHLW9ivWhjiH 85d9rvEAOU15aR7Yjy0hu+nuvY2ea3AgbUfVE3sMoMWxM6eo2IIXJWNxjjF5Cw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1759546948; a=rsa-sha256; cv=none; b=tJmJDQB0bLU+u9j/zksQRBmp028hZsnUMu7Jvqeh/iAKRPT8Y8uKxMuCIp1hi/QbZDmBtS 78yqdAtOUti7BBAlJ8SxucPggAWX9NfUcm13V2zjSvc0AoK7QU18s+uEkdfphH9vZJnp+7 kVyVHI7frPgm1l5q3CEgnPgJGezIkrc3IHHacVq1GOaJNP5+g5OQiTZZ8ms0x/5IsDcu2O WORR4rHU9JH8X58BPB+gQ1AWvMjJEVKWY7+l7Bc2vRxUnudwTGYVeWNea14ZvoIb/YL8yp +G7NF/1+x2wbRbYeKVhPA8tUbybaqgx0/jA7D5Rat0G8XP7adtLUg4hcipKjyQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cdr1J2FPmz7Yw; Sat, 04 Oct 2025 03:02:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 59432SaC014846; Sat, 4 Oct 2025 03:02:28 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 59432ShH014843; Sat, 4 Oct 2025 03:02:28 GMT (envelope-from git) Date: Sat, 4 Oct 2025 03:02:28 GMT Message-Id: <202510040302.59432ShH014843@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Adrian Chadd Subject: git: f53137556059 - main - iwx: add some missed beacon debugging List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: adrian X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: f53137556059764f5c028880d09d3c234877d37f Auto-Submitted: auto-generated The branch main has been updated by adrian: URL: https://cgit.FreeBSD.org/src/commit/?id=f53137556059764f5c028880d09d3c234877d37f commit f53137556059764f5c028880d09d3c234877d37f Author: Adrian Chadd AuthorDate: 2025-09-14 19:36:18 +0000 Commit: Adrian Chadd CommitDate: 2025-10-04 02:54:30 +0000 iwx: add some missed beacon debugging I'm seeing random disconnects in iwx without any useful information as to why. I'll start by adding missed beacon debugging here; hopefully they're generally useful. Differential Revision: https://reviews.freebsd.org/D52524 Reviewed by: bz --- sys/dev/iwx/if_iwx.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/sys/dev/iwx/if_iwx.c b/sys/dev/iwx/if_iwx.c index 8422fcb787c3..5be7f2755598 100644 --- a/sys/dev/iwx/if_iwx.c +++ b/sys/dev/iwx/if_iwx.c @@ -4890,11 +4890,19 @@ iwx_rx_bmiss(struct iwx_softc *sc, struct iwx_rx_packet *pkt, bus_dmamap_sync(sc->rxq.data_dmat, data->map, BUS_DMASYNC_POSTREAD); + IWX_DPRINTF(sc, IWX_DEBUG_BEACON, + "%s: mac_id=%u, cmslrx=%u, cmb=%u, neb=%d, nrb=%u\n", + __func__, + le32toh(mbn->mac_id), + le32toh(mbn->consec_missed_beacons_since_last_rx), + le32toh(mbn->consec_missed_beacons), + le32toh(mbn->num_expected_beacons), + le32toh(mbn->num_recvd_beacons)); + missed = le32toh(mbn->consec_missed_beacons_since_last_rx); if (missed > vap->iv_bmissthreshold) { ieee80211_beacon_miss(ic); } - } static int @@ -8985,10 +8993,10 @@ iwx_rx_pkt(struct iwx_softc *sc, struct iwx_rx_data *data, struct mbuf *ml) break; case IWX_MISSED_BEACONS_NOTIFICATION: + IWX_DPRINTF(sc, IWX_DEBUG_BEACON, + "%s: IWX_MISSED_BEACONS_NOTIFICATION\n", + __func__); iwx_rx_bmiss(sc, pkt, data); - DPRINTF(("%s: IWX_MISSED_BEACONS_NOTIFICATION\n", - __func__)); - ieee80211_beacon_miss(ic); break; case IWX_MFUART_LOAD_NOTIFICATION: