From nobody Fri Oct 03 22:45:58 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cdkKW3wyqz69Pxw for ; Fri, 03 Oct 2025 22:46:07 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qv1-xf34.google.com (mail-qv1-xf34.google.com [IPv6:2607:f8b0:4864:20::f34]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cdkKW1y5zz3HSl for ; Fri, 03 Oct 2025 22:46:07 +0000 (UTC) (envelope-from markjdb@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-qv1-xf34.google.com with SMTP id 6a1803df08f44-7957e2f6ba8so26861896d6.3 for ; Fri, 03 Oct 2025 15:46:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1759531561; x=1760136361; darn=freebsd.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=wCzAAaN9dbPSmd+WKlRvV/Wyw2bVgAsR3Xp6nScUMiM=; b=Nagzqxxi86Ju7RopbIWcIKN9nYNE2xXPFZqNloeasmP0l33zTkl4tkXGt09W72pYEw sSWuojTCTZFpSAlSN3L8+xo86Sr5VSe/449Vm38FNCQfWnSQiuovonNkpfFVRQK7vGZz r0MxOb1WGwukAv4ozyQCpNY+csVX/+MJo+2aQ667pwK2Q7Qj3lLvGODalFN9KRGmHc+q IpeyUt1xSz0cZf1iwjzYwCVHlwNgsPz2QtkuEnEk7WS0KOthIclTxsba96BU0lqRIkIN dToQ+pJxKG+NQ8EoH5pPIdSXKyRyQznyMMMuTSuTS+I6LSMEXzN6+bfPf7eYLb0GqHNv WhVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759531561; x=1760136361; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wCzAAaN9dbPSmd+WKlRvV/Wyw2bVgAsR3Xp6nScUMiM=; b=YRnNSZi01PJ/UrVVm3wk85G21i13FzX6LXCKUGjRDiMDfJHeCoZEz1zJ/xQ+y/6QdO oWVdeJJJTY6uF+fHfBSz/NpKepLkFRo8xNarM7JBxKbiHoFVK1Wsql2SenDsSMkxXH5I vzDiciWocsQ4J97AvxGBq2gNHLhUufc4z0OwymEyIu6hNX0ZjvdGD1vcmAD11A+wwdRo Cun4vGONqt353EVBvlZXHA74FQ2W646MonF25Rp/jvjhj35rTgBslHfBfgiCW01ARTTy 2U5zVqnDK/Yf8uJr0cRuRtlHd1mqiOtKTXy4C2b7NWE/Mr4qFdD9QFslc6qxLgQZMB44 3Kkg== X-Forwarded-Encrypted: i=1; AJvYcCVZzahBxbfRzoa8MWTlqbGUlUjhdVYQMfcHjBnTS7AQMmHLb+WGpu9ZMIAF5Whw0350Z2YMeXHe8ueJdV5KZ48xGr+HpQ==@freebsd.org X-Gm-Message-State: AOJu0YyvtMrKPDQ1M1XvnMxbaSgR2ZLA61CEouRGFFfUuGWJ2rPqwr6V i5TXggCY+HwyyggOlmQiU69WojOIW1BjqimeCNKQo+zQThOwoDOYIG5a X-Gm-Gg: ASbGnct1l0cMED1v74qqOpED1dB9fcpjvyNCSlqfatoclsFeTAJqATWY/xfJzaG9Q5D hlUsFmYOmOYZf+9a4KJdtbSlUtQXu75v89WEiWj4Ye1WuN2Gl+geHC4F/rTRGg+XKNJOwCZi7Dg O0yuEHHDLYNQFIz1Evb/c8HXyHiMhluIK5WEznIsacbBtZKUXLItEAin2ZnVa9Q4/jELnm/mBTj mG1BRaPivKR4P9ML7sov/P6GX6BkpkaQRQQctLCBABpvk4qityrjYy5GBVZRBe/iJGxdwoywDNZ MzDo9GDULfZSU880r0aZ+eiXoDkLNkUL5CmiqVsa5vjgQGyqRnZR6L1WG4UuuF4Sg5hzKXsB/NJ erj97zzXesVHwfQZzM3vt7fXMOAk0lFaclkfUs8Oh14u9PP4yFBl+PrW+GK1v X-Google-Smtp-Source: AGHT+IGhVUI3ac2WluDE0nMWyisuaTZme5RTQvUEaUaZaFIq2r6Hwi7o761ew31WlQqXn/QJMj73TA== X-Received: by 2002:ad4:4ee4:0:b0:797:cef:c862 with SMTP id 6a1803df08f44-879dc7c334dmr57035166d6.29.1759531561256; Fri, 03 Oct 2025 15:46:01 -0700 (PDT) Received: from nuc (192-0-220-237.cpe.teksavvy.com. [192.0.220.237]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-878bd783965sm49638966d6.40.2025.10.03.15.46.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Oct 2025 15:46:00 -0700 (PDT) Date: Fri, 3 Oct 2025 18:45:58 -0400 From: Mark Johnston To: Kyle Evans Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 1953a12ee2cd - main - flua: support our flua modules in the bootstrap flua Message-ID: References: <202510031810.593IAZE9008541@gitrepo.freebsd.org> <27098bd2-04e8-4ef7-8b8e-f7b170eb8151@FreeBSD.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <27098bd2-04e8-4ef7-8b8e-f7b170eb8151@FreeBSD.org> X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4cdkKW1y5zz3HSl On Fri, Oct 03, 2025 at 04:44:38PM -0500, Kyle Evans wrote: > On 10/3/25 16:39, Mark Johnston wrote: > > On Fri, Oct 03, 2025 at 06:10:35PM +0000, Kyle Evans wrote: > > > The branch main has been updated by kevans: > > > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=1953a12ee2cde1afacb3e3f7612d89695c96e04f > > > > > > commit 1953a12ee2cde1afacb3e3f7612d89695c96e04f > > > Author: Kyle Evans > > > AuthorDate: 2025-10-03 18:09:03 +0000 > > > Commit: Kyle Evans > > > CommitDate: 2025-10-03 18:09:14 +0000 > > > > > > flua: support our flua modules in the bootstrap flua > > > This version builds every module into the flua binary itself, since all > > > of the bootstrap tools are built -DNO_SHARED. As a result, we also > > > cannot dlsym(), so we can't really discover the names of our newly > > > builtin modules. Instead, just build out a linker set with all of our > > > luaopen_*() functions to register everything up-front. > > > Building in all of the modules isn't strictly necessary, but it means > > > that we have an example of how to add a bootstrap module everywhere you > > > go and one doesn't need to consider whether bootstrap flua can use a > > > module when writing scripts. On my build machine, the consequence on > > > our binary size is an increase from around 1.6M -> 1.9M, which isn't > > > really that bad. > > > .lua modules can install into their usual path below $WORLDTMP/legacy > > > and we'll pick them up automagically by way of the ctor that sets up > > > LUA_PATH early on. > > > Reviewed by: bapt, emaste > > > Differential Revision: https://reviews.freebsd.org/D51890 > > > > This breaks cross-building from other OSes since linker.h and kenv.h > > aren't available. I guess we can safely exclude those from the > > bootstrap build? It could be done conditionally on ${.MAKE.OS} perhaps, > > but it's probably better to be consistent. > > Hi, > > Hmm, yes- I think excluding libfreebsd and libjail doesn't make it much more > difficult to reason about what's available in the bootstrap flua. > > re: cross-builds, yikes- I forgot that we'll end up bootstrapping flua there. I > bet it's also broken without libyaml and libucl here: https://reviews.freebsd.org/D52894? I don't see any bootstrap build failures in an Ubuntu chroot after I disable building libfreebsd. Let me know if you'd like me to submit a patch for that.