From nobody Fri Oct 03 21:44:38 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cdhyb6v0pz69HFL; Fri, 03 Oct 2025 21:44:39 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cdhyb5tRfz488N; Fri, 03 Oct 2025 21:44:39 +0000 (UTC) (envelope-from kevans@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759527879; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/KGoWisETbzMMebYw9Jf+ga9IbfQ5QbUab5NhWSeOu8=; b=bAh1793dvX14O/3j6Kf3isQeiVONid9+T8DgcdeOQnG3XvOrvKHx0fK+Y202ELyv1TssHC L/1pNuH2GT22rsYSsHj7Q0JPIue2OMVllL+KEajiNGM5aC0fzW4CtUXjT49UyF5pC7urx2 857dbK09Oph6sjW2IdeO6yvf/PtTCbYE0YbetSfqPmNsjM53cCrv8OivIMxbFSuMEkuux4 /yvdsJk1r2q5f37hlI4Wo+9K0sp5VA/9QMgGX7NjzSy0zeKviqvQFdP1Eh4OQPdOmPEmaO 4Uj6uuAF4wPzpNh7FT6fOuR0QjIjKC6sfymPgoVUKBSNITO9vfRbmOw67g+V7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759527879; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/KGoWisETbzMMebYw9Jf+ga9IbfQ5QbUab5NhWSeOu8=; b=wUTih4aQsblQVH7U+/wqASZwkMX8mXxxzMrb09jeVTxQdX3kh627Yqsqg2zVCCWUWBg7D3 gqO7sZo8YfIBDjjhlGXe7IIgPht9Dp9/g/RXa/VatBAVyDgKcKgoGpmD5iPHIEFpF241xy IRn48r4wAJbJ7hSjCKdf+2/56XEOd/uWjpf9BfJP9sSvRiiaTYhSNuGoXzaJAZ1Y45X4/E Q+9i/C6nVS7X2hDGFh4XZKzkAMU6b8ozpTt2mUZ4SGDXEeiEM4JLpAHpU39Gz0hJ3QwVZ/ 7XhL66m8ZljlRJ3kCSNZiOuemq2vdh1LhOv88WUcajcuUlSaOBsKdihNgh7vNQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1759527879; a=rsa-sha256; cv=none; b=yMqKed1EAsvIGob9YkfIk00+6GW4leTX0uUf1xllKraVJlgmEU7PMnp5U8iZMIzv0TPEx+ I2BO/Vm2K4zG5toDRBIITbeE7997CsYISUx70Hps48w7ims+XE2t8XgWmULFhzE7WaL4Da HcvcPHA6vm1viG9QLEOaMeHUb6Us+azRe+kq2FoL3p0VHIltvdwKTean0skMzapwZ4Om82 Un3zd1XsqvHFOAElBLv6SiLbQVenJztyjjb1J/QspW+Y2xxKhPp++XZ921nsq4JruGiX8j E/cqp8j6E5hx8LoQIvjhUfv99MR+Td9GVAnn/M+9wM0BTH2wm/n9yzCZV+vSOg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from [10.9.4.95] (unknown [209.182.120.176]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) (Authenticated sender: kevans/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4cdhyb2k4hz8T9; Fri, 03 Oct 2025 21:44:39 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Message-ID: <27098bd2-04e8-4ef7-8b8e-f7b170eb8151@FreeBSD.org> Date: Fri, 3 Oct 2025 16:44:38 -0500 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 1953a12ee2cd - main - flua: support our flua modules in the bootstrap flua To: Mark Johnston Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202510031810.593IAZE9008541@gitrepo.freebsd.org> Content-Language: en-US From: Kyle Evans In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/3/25 16:39, Mark Johnston wrote: > On Fri, Oct 03, 2025 at 06:10:35PM +0000, Kyle Evans wrote: >> The branch main has been updated by kevans: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=1953a12ee2cde1afacb3e3f7612d89695c96e04f >> >> commit 1953a12ee2cde1afacb3e3f7612d89695c96e04f >> Author: Kyle Evans >> AuthorDate: 2025-10-03 18:09:03 +0000 >> Commit: Kyle Evans >> CommitDate: 2025-10-03 18:09:14 +0000 >> >> flua: support our flua modules in the bootstrap flua >> >> This version builds every module into the flua binary itself, since all >> of the bootstrap tools are built -DNO_SHARED. As a result, we also >> cannot dlsym(), so we can't really discover the names of our newly >> builtin modules. Instead, just build out a linker set with all of our >> luaopen_*() functions to register everything up-front. >> >> Building in all of the modules isn't strictly necessary, but it means >> that we have an example of how to add a bootstrap module everywhere you >> go and one doesn't need to consider whether bootstrap flua can use a >> module when writing scripts. On my build machine, the consequence on >> our binary size is an increase from around 1.6M -> 1.9M, which isn't >> really that bad. >> >> .lua modules can install into their usual path below $WORLDTMP/legacy >> and we'll pick them up automagically by way of the ctor that sets up >> LUA_PATH early on. >> >> Reviewed by: bapt, emaste >> Differential Revision: https://reviews.freebsd.org/D51890 > > This breaks cross-building from other OSes since linker.h and kenv.h > aren't available. I guess we can safely exclude those from the > bootstrap build? It could be done conditionally on ${.MAKE.OS} perhaps, > but it's probably better to be consistent. Hi, Hmm, yes- I think excluding libfreebsd and libjail doesn't make it much more difficult to reason about what's available in the bootstrap flua. re: cross-builds, yikes- I forgot that we'll end up bootstrapping flua there. I bet it's also broken without libyaml and libucl here: https://reviews.freebsd.org/D52894? Thanks, Kyle Evans