From nobody Sun Nov 23 13:09:37 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dDq7000KZz6Gx5L; Sun, 23 Nov 2025 13:09:47 +0000 (UTC) (envelope-from christos@freebsd.org) Received: from margiolis.net (mail.margiolis.net [95.179.159.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA512) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4dDq6z245wz3fK8; Sun, 23 Nov 2025 13:09:47 +0000 (UTC) (envelope-from christos@freebsd.org) Authentication-Results: mx1.freebsd.org; none DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=default; bh=aZpEDqKMszp9 01un3MmB95AMa1nLz31UOyihx+8RgtI=; h=in-reply-to:references:to:from: subject:cc:date; d=margiolis.net; b=HKMFBExzZU0wzP5fiGteBddlxrsSndCdN3 EJzCWPt7lbrKVBJsQ7leM3bYTHarKHiYGhkLfahmxaF7O3XNQHqdhgU36aLZqJzR+eyK2l obwyrmW0OWgLBWdTx0YistqXwhHoGCEW6jvZQeahp7viLdO6yxH3CtinrfUdmef9vZo= Received: from localhost (public-gprs561811.centertel.pl [37.225.57.212]) by margiolis.net (OpenSMTPD) with ESMTPSA id ba6c7ed7 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sun, 23 Nov 2025 06:09:38 -0700 (MST) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sun, 23 Nov 2025 14:09:37 +0100 Message-Id: Cc: , , Subject: Re: git: e254ef87a30b - main - sound: Merge chn_intr() with chn_intr_locked() From: "Christos Margiolis" To: "Roman Bogorodskiy" X-Mailer: aerc 0.21.0 References: <69209005.3652b.58fc1f99@gitrepo.freebsd.org> In-Reply-To: X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4dDq6z245wz3fK8 On Sun Nov 23, 2025 at 7:54 AM CET, Roman Bogorodskiy wrote: > Christos Margiolis wrote: > >> The branch main has been updated by christos: >>=20 >> URL: https://cgit.FreeBSD.org/src/commit/?id=3De254ef87a30bfcaabc6e4d8e0= ecf05f6949a4f06 >>=20 >> commit e254ef87a30bfcaabc6e4d8e0ecf05f6949a4f06 >> Author: Christos Margiolis >> AuthorDate: 2025-11-21 16:14:28 +0000 >> Commit: Christos Margiolis >> CommitDate: 2025-11-21 16:14:47 +0000 >>=20 >> sound: Merge chn_intr() with chn_intr_locked() >> =20 >> There is no scenario where chn_intr() is called with the channel loc= k >> already held. >> =20 >> No functional change intended. >> =20 >> Sponsored by: The FreeBSD Foundation >> MFC after: 1 week >> Reviewed by: kib, markj >> Differential Revision: https://reviews.freebsd.org/D53854 >> --- >> sys/dev/sound/pcm/channel.c | 20 ++------------------ >> sys/dev/sound/pcm/channel.h | 1 - >> 2 files changed, 2 insertions(+), 19 deletions(-) > > With this change my system panics as soon as I start firefox: > > panic: _mtx_lock_sleep: recursed on non-recursive mutex dsp2.play.0 @ /us= r/src/sys/dev/sound/pcm/channel.c:586 > > Things work fine again with this commit reverted. > > Roman Which driver are you using for your sound card? Christos