From nobody Sun Nov 23 06:54:47 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dDfrd2N1Sz6JPLP for ; Sun, 23 Nov 2025 06:56:49 +0000 (UTC) (envelope-from bogorodskiy@gmail.com) Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dDfrb3hXTz3x1f for ; Sun, 23 Nov 2025 06:56:47 +0000 (UTC) (envelope-from bogorodskiy@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20230601 header.b=A8QtKqtf; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=freebsd.org (policy=none); spf=pass (mx1.freebsd.org: domain of bogorodskiy@gmail.com designates 2a00:1450:4864:20::630 as permitted sender) smtp.mailfrom=bogorodskiy@gmail.com Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-b737c6c13e1so51778766b.3 for ; Sat, 22 Nov 2025 22:56:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763881001; x=1764485801; darn=freebsd.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=3xV66PPHb/KGCF5X85WoY91DJ3u/52OEzlUm8snwmS4=; b=A8QtKqtfRvig9cB+Pw1w5JrVaROIyr7NxUndVbPBVHCfx/iIJX1C+gbtesoTbt/6IL a9befneJQNICTQSNkgc3ULowlTBX9S6QIbAYK5RN/8GGcT94C6rPY7nTzKn74M74zvCy zyhVEzANpP6ri9hmm6pKWtVgEfTr3rTYP8M97IlIWYgcQxbvQS53CkKm6XTXcUSDULIS ruhSiIlItw+ov/U/dSZnaI2nocDzIulODTLbX1VER/CzM2RC2gHigqgYfUO3WaUcIsO7 YnYBIuh0UHrh7BNQ0IfsLOaxOIVqN8/g+iYEhjIhdREe1StxrtJB7kytQQEN0nA4+ckE LzFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763881001; x=1764485801; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=3xV66PPHb/KGCF5X85WoY91DJ3u/52OEzlUm8snwmS4=; b=B6YEqbeQZ41zRlYBKThQdu00jpsTvRa5uQViD2/PBmhBNDljTWT9TA2DCOxSOqzxZx SYF7m1xrXMq16swQQxZwdiS+TEAaedEgkaqCT8R8c+mIPUYXxKCDYbcjUwRqU2Kvv/I5 tsB1jt3DJGejnwWKInstIdajdhJAIhJWUrLHBJWYmNF85neqyI1hTp2Eawyc/LbHYJfL lOP1zZXwNMTTevPw548X1eKUBYrslthl1Oihp+mctwUfUy8AJDQMjWhZHEjBWjdNQwi6 aTSYWKwavMqIhx30tWqeYr8kRbKKnc8t+UnWqNee1IOijLdAfGzVsVuLKGdU7xVViyBO OZKQ== X-Forwarded-Encrypted: i=1; AJvYcCVTO//ItQ3P/IdIb33wXhzHwEpqRE2B4j6zAqGwSXpeXWC+FwkGy1+BI6fgqsuOtblR9BbXRWR0PmfXMwFO1uI6mKXiRg==@freebsd.org X-Gm-Message-State: AOJu0Yy372gg/9/JmJQG/IqaCW7NhF3j9hhUFI8hGO98F4+LTQxRENlB JQ4Bo4O9WxmbYnczBcVa10UNCNaC+DYlg821ngkW3yPmmIZrp94DEC5G X-Gm-Gg: ASbGncvOdfqra3OXzqsQ7zhBHD0yuutLsTdLmplNoKg5hmWsDsI1rXhPKFA8jIXmLUo Ro2tAOQw+egtGoF6JjTWRHTP10+kxOUINqx+rs7ESlYBjV9R+SUc+mOO9lDOvjKWwO/twDT6Qdr S6BG61+5LJRbimV1nNR+ZhurJlitcT1m8FsqinPNwgwZyKhxKCBg45VwB6thTev6xOBYlbePgWD VrzI/DRQ60THE1mGV5NpE4zwwd4YjYeUt6fxfyH6rdDW2Pq71G8DGsFqOruny1meYq0aRfMtK3P Hsip1UtOaR/oF7EfOr/K0HhnxA9Ie0c/Fg1u/jgqut6/zkDGI+CH6kItUqtn7vWSFkxzy9xkFfI QbLh586WoAyQbISlsBc+IEuT1pH0iqreILZlx4r75XAbMWPIpUX4FrAaYOpckiQwspLE5A7BeTg 8s5ZR7RWHYug8xRo+cdA3cGp43RU15I9k= X-Google-Smtp-Source: AGHT+IG0NV5RujLIcXZrCSQ8+BGKhqExhdG8qSwk2Obzl+fO/5gG35/uZB0HUZCxZzxJteAhjpzjrw== X-Received: by 2002:a17:906:b7ca:b0:b76:74b6:da78 with SMTP id a640c23a62f3a-b7674b6db1fmr556602766b.35.1763881000757; Sat, 22 Nov 2025 22:56:40 -0800 (PST) Received: from tulp (84-25-144-101.cable.dynamic.v4.ziggo.nl. [84.25.144.101]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b7654fd4f59sm912380466b.36.2025.11.22.22.56.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Nov 2025 22:56:39 -0800 (PST) Date: Sun, 23 Nov 2025 07:54:47 +0100 From: Roman Bogorodskiy To: Christos Margiolis Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: e254ef87a30b - main - sound: Merge chn_intr() with chn_intr_locked() Message-ID: References: <69209005.3652b.58fc1f99@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <69209005.3652b.58fc1f99@gitrepo.freebsd.org> X-Spamd-Bar: -- X-Spamd-Result: default: False [-2.60 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; MID_RHS_NOT_FQDN(0.50)[]; FORGED_SENDER(0.30)[novel@freebsd.org,bogorodskiy@gmail.com]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36:c]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20230601]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), DKIM not aligned (relaxed),none]; MIME_GOOD(-0.10)[text/plain]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; FROM_HAS_DN(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_NEQ_ENVFROM(0.00)[novel@freebsd.org,bogorodskiy@gmail.com]; RCPT_COUNT_THREE(0.00)[4]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-main@freebsd.org]; RCVD_VIA_SMTP_AUTH(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; MISSING_XM_UA(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::630:from] X-Rspamd-Queue-Id: 4dDfrb3hXTz3x1f Christos Margiolis wrote: > The branch main has been updated by christos: > > URL: https://cgit.FreeBSD.org/src/commit/?id=e254ef87a30bfcaabc6e4d8e0ecf05f6949a4f06 > > commit e254ef87a30bfcaabc6e4d8e0ecf05f6949a4f06 > Author: Christos Margiolis > AuthorDate: 2025-11-21 16:14:28 +0000 > Commit: Christos Margiolis > CommitDate: 2025-11-21 16:14:47 +0000 > > sound: Merge chn_intr() with chn_intr_locked() > > There is no scenario where chn_intr() is called with the channel lock > already held. > > No functional change intended. > > Sponsored by: The FreeBSD Foundation > MFC after: 1 week > Reviewed by: kib, markj > Differential Revision: https://reviews.freebsd.org/D53854 > --- > sys/dev/sound/pcm/channel.c | 20 ++------------------ > sys/dev/sound/pcm/channel.h | 1 - > 2 files changed, 2 insertions(+), 19 deletions(-) With this change my system panics as soon as I start firefox: panic: _mtx_lock_sleep: recursed on non-recursive mutex dsp2.play.0 @ /usr/src/sys/dev/sound/pcm/channel.c:586 Things work fine again with this commit reverted. Roman