From nobody Sat Nov 22 16:59:04 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dDJGM6LzLz6HSJp for ; Sat, 22 Nov 2025 16:59:23 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dDJGL4BmQz3V3X for ; Sat, 22 Nov 2025 16:59:17 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=freebsd.org (policy=none); spf=pass (mx1.freebsd.org: domain of jrtc27@jrtc27.com designates 209.85.128.42 as permitted sender) smtp.mailfrom=jrtc27@jrtc27.com Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-47774d3536dso23392995e9.0 for ; Sat, 22 Nov 2025 08:59:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763830755; x=1764435555; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=2lI9jp59TxRRVnP6ehN5qukLqbI0FL6PhV4W7z/ekOY=; b=RBPojpRoym/+lblf/3xaDpcc1dS7sLL7eGxgjX8m19zDfYvEVulPG0y+HYRHwe5gzG SPI8GT4tg2/ki+i3dJJzGf5c8igGRyk+KltXjtCROYSJ7/P/FTKd5+i8xYUiINzEUf5B QP9jb1QJy89mfIUYYuGQamNOY1DUjMvTz1g3kxqMzrJAb8ckWhHO2U0DeTOENiDwvWTX Fd+wn6r1foAkODfCs31W+z1MdXwgMP3wYRRRVEa/fupEpk4+53fK7EPBaG1E0aCB2lZE gUMVW5rQvuPg8OHQnY2bFMELCNjRMOsKeqH6S9z9V14Xkc0hvDtFbUEDZc1Lxb2xU2TQ Ityw== X-Forwarded-Encrypted: i=1; AJvYcCW7gp13D0q8VcSG2Hm1rBhtxAjDF11Ewh0INwqCUeSvj73FhTOYdx67D1WvTgjUZ/1WZ8YIzaDFJUqThSxC1OOclTR3lg==@freebsd.org X-Gm-Message-State: AOJu0YzJp5z1EsSImC3VYrQTlJvsXCX2vahW2gGRBtGu59ovPPMsATQI LS1kMt8xG0l9WKnMtz/f1jm55SorJ1aAjigRZrB+k5TZP6oqmkUvxHEjqYzJoyYNgic= X-Gm-Gg: ASbGncuIHqf6Aq0FL8gja7K7dtOJGZNbu6J4niBPdNye2dG5gQDhfMQFfhEII4RuMxY mp4yp0dlPvpwLFU87eIhR4U4TQcShnw+77L8/DRfGrrMlXQupxQxtxf/yV2DaOJKwox09gWoK/A Gbl4vGkJ8+F6x5/EfSJE4xbABPl5wFdYGO1M8P6kmbLH0wfzrqx1ZzPO+0c2wvnnCiGHB873p7k eBseX9PGG+UanjXploSiVh0f7F8WeX+kgIWzjhqSP3oGFl5ZeIsjiS3XVs5cqyTFVADdw6fyYPU 0poWhIBJryGSFgxclQCw2xsn+6HqFoJnmi+ZWmvVDfUuZpK0hviG+WcGoZ3SkxfT9lEN8Ymflv1 Z+5guKB7wRP73PW2MxWEJVDWj8I3jmmL+YsoUzifgvWPV3mmWro5eiGGMCJbDKi8N2rmQQTNYvU EyA2T+NfjZU3jA9exXDlMzKl11l1ajMO/FtuylMOsQupqvI/5lhWMz/N1Pj97a8rA= X-Google-Smtp-Source: AGHT+IHVuL+/Guc3QD547JxLex+cld46Tt4Cc9Q9hNd4Wd6a2nNN4mgqiN2a6qNb1R0m9syNksMNHg== X-Received: by 2002:a05:600c:1516:b0:477:14ba:28da with SMTP id 5b1f17b1804b1-477b9ea8f78mr65203465e9.5.1763830755351; Sat, 22 Nov 2025 08:59:15 -0800 (PST) Received: from smtpclient.apple (nat-184-7.net.cam.ac.uk. [131.111.184.7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477a9df8db3sm107120455e9.11.2025.11.22.08.59.14 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 22 Nov 2025 08:59:14 -0800 (PST) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.200.81.1.6\)) Subject: Re: git: a695ac2ce8bc - main - arm64: Move intr_pic_init_secondary earlier From: Jessica Clarke In-Reply-To: <691cb4c1.220bb.22f9ecf6@gitrepo.freebsd.org> Date: Sat, 22 Nov 2025 16:59:04 +0000 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <6FEF15D6-B2EB-4544-9FC7-49B2273BCEC1@freebsd.org> References: <691cb4c1.220bb.22f9ecf6@gitrepo.freebsd.org> To: Andrew Turner X-Mailer: Apple Mail (2.3864.200.81.1.6) X-Spamd-Bar: -- X-Spamd-Result: default: False [-2.40 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999]; NEURAL_HAM_LONG(-1.00)[-0.998]; NEURAL_HAM_SHORT(-1.00)[-0.998]; MV_CASE(0.50)[]; FORGED_SENDER(0.30)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; MIME_GOOD(-0.10)[text/plain]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), No valid DKIM,none]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; ARC_NA(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; FREEFALL_USER(0.00)[jrtc27]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_HAS_DN(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_NEQ_ENVFROM(0.00)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-main@freebsd.org]; R_DKIM_NA(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.128.42:from]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.128.42:from] X-Rspamd-Queue-Id: 4dDJGL4BmQz3V3X On 18 Nov 2025, at 18:02, Andrew Turner wrote: >=20 > The branch main has been updated by andrew: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3Da695ac2ce8bc8e8b989359002659063f= 2e056dcf >=20 > commit a695ac2ce8bc8e8b989359002659063f2e056dcf > Author: Andrew Turner > AuthorDate: 2025-11-18 18:00:32 +0000 > Commit: Andrew Turner > CommitDate: 2025-11-18 18:00:32 +0000 >=20 > arm64: Move intr_pic_init_secondary earlier >=20 > This may have been called after intr_irq_shuffle. For most = interrupt > controllers this appears to be safe, however for the GICv5 we need = to > read a per-CPU ID register before we can assign interrupts to a = given > CPU. >=20 > Fix the race by moving intr_pic_init_secondary earlier in the boot, > after devices have been enumerated and before the interrupts are = moved > to their assigned CPUs. I=E2=80=99ve been trying to figure out what race you=E2=80=99re implying = exists, and cannot find anything. My thoughts are as follows: * If an AP isn=E2=80=99t properly online, why would we be looking at it = for IRQ shuffling in the first place? * intr_irq_shuffle is SI_SUB_SMP, SI_ORDER_SECOND, but release_aps is SI_SUB_SMP, SI_ORDER_FIRST * release_aps blocks until all the APs are running, which was already signalled after intr_pic_init_secondary was called Can you please explain in detail what race you believe exists? In the = meantime, given the motivation is unclear and it=E2=80=99s actively breaking = multiple distinct systems, please revert this, or I will do so shortly myself, and if = there is a race that needs fixing then you can re-land an alternative approach that = works. Jessica