From nobody Fri Nov 21 23:54:09 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dCsWY5M7gz6Hyn9 for ; Fri, 21 Nov 2025 23:54:17 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-il1-x131.google.com (mail-il1-x131.google.com [IPv6:2607:f8b0:4864:20::131]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dCsWY3NwDz4HxB for ; Fri, 21 Nov 2025 23:54:17 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Authentication-Results: mx1.freebsd.org; none Received: by mail-il1-x131.google.com with SMTP id e9e14a558f8ab-43321629a25so10610335ab.3 for ; Fri, 21 Nov 2025 15:54:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd.org; s=google; t=1763769251; x=1764374051; darn=freebsd.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bxz/UwrtmYXxX1KqAskEQ9AEcqlp7szLd/IhLsn3mMg=; b=cIneKRzMhpggEOxnRYW3tRaBJ2qfDrEiy00y9CC3p8M7HqHoUEKyPl18luMJKD9775 oGGZgR4tcjGM9aHPkn7UKhIP3sK9hzVt/xiRjSVR0yGQ5hSkwhDQ4s5YIfegJcSfQe6J Cgn4MPmVgvwChYdrCU3VOp+0jnoxC0RUj+4uMn+b8WQIWFSG5sBPVvsP8kStDbEAqyMM PU07P26hgO91yDh1fuwV+vL+0TyV59HOF0kx1rVNQCnLL7LmteVAxxhhNFe1AoOkiF9j UgVHzB4AbG3be4TCXRzMpubNR7iTWVU5+nwh1uIX1ACvSY5DNr6PHnfxnHgoMoOOCJCn a+YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763769251; x=1764374051; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bxz/UwrtmYXxX1KqAskEQ9AEcqlp7szLd/IhLsn3mMg=; b=p/V1EmXA9MpyOppennB2FxfgUad1gEb58W2dEus1flfyU383vD8UIymhK9KwlGfOk5 qNOnAHc0NBv/yzyD4gZDzVvR7VjvFRr8HMImbUo9ezj1DWJvPyF+tdatVGEbU1fUBtWR PwVPJeGMv0IJubRZ1l9YxuHK4sht9AADx2YNbB4rb4vex2oLR8bfAIdid6lxPlsfTWft pJiZUWAdrQzjjUB2Nu718NWyEmx94HVDj3yhomnHK1mZEo2VD8QLbrixwmRBTy5IyIPq 9WOy1hnYVBydJWOBsETBoCxkNtW0keIoKVT1TXQC5AWXpSLbo/HhO1mBthEfL4IoiHah 3f1w== X-Forwarded-Encrypted: i=1; AJvYcCUtskVEJmy4hpiUlPZdZGxLM58MKT2Srq2uT6k6YTP/D2n/WJZXphqDUwzWD62qChvyg4ZW1Ik/gzyD3fbm88hXugIuoQ==@freebsd.org X-Gm-Message-State: AOJu0YyVsfyyHvbm+HNxFArtOgnIpDyhy7L32EU5D1ohu3blGhl7NE3u zrQVYoabWgFANde6jxkjnDmJdm7NWqd2aioT9KB2lCyvhfFI3EP0yS9eZnlgOS4qW7s= X-Gm-Gg: ASbGncs2svP5wWBSc6vwTVEcLif6u9dquyE3CA+pG6KoiWDFSkY82/AzwpClB0ndTVq UcQDIBZhvMrVABgxElU2fRsqKCRI8lm1yxhR7bObG5gR7DeDkOUSYLzZZzDcH5WSe1ozkbJMkzQ oG/Y9Wt0CqDQnjES3WBcEW1zNBFi8Jwv+GsmoNHBGHQ9O1+eBk7iw0MViXIk5ijpbHIB2V+SADI t0BxdL3tJcWEsJCC8ZTM287KmFZJf2GUXFHTik+LjswZhPrxX8UYkD0Fk0lCkcm4qHitaEPyTnT eqjpjKaPc4OLmracJt1pr7q8l+qDNb0lNNlIChjrYiCmYgCLrE/PoAdwgfOLJVnxrmh8nG+LwKJ 1wGwpZ9PaqzOK33sk3kYKoZ4MVFdG9/ixqAWpHfsDJFeakQzcPnGW+bcIfmWKrdydTWk+HwrN0R nVpns= X-Google-Smtp-Source: AGHT+IHew+P5cOUAE8/Igxdi+lvQ56TWGXlwzvAohRaGDT0h1pUpOFujncUT9mk7Bl89aMZkyv4Zyw== X-Received: by 2002:a05:6e02:16c8:b0:433:7900:f1c5 with SMTP id e9e14a558f8ab-435b9845f4cmr35654135ab.7.1763769251333; Fri, 21 Nov 2025 15:54:11 -0800 (PST) Received: from mutt-hbsd ([2001:470:4001:1::95]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-435a90e8989sm27814095ab.33.2025.11.21.15.54.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Nov 2025 15:54:10 -0800 (PST) Date: Fri, 21 Nov 2025 23:54:09 +0000 From: Shawn Webb To: Christos Margiolis Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 9d18115ca0ab - main - sound: Retire snd_mtx* wrappers Message-ID: X-Operating-System: FreeBSD mutt-hbsd 14.3-STABLE-HBSD FreeBSD 14.3-STABLE-HBSD HARDENEDBSD-14-STABLE amd64 X-PGP-Key: https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/blob/master/Shawn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc References: <69209007.369f8.65e30118@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7puhdlcpwo2btcjb" Content-Disposition: inline In-Reply-To: X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4dCsWY3NwDz4HxB --7puhdlcpwo2btcjb Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: git: 9d18115ca0ab - main - sound: Retire snd_mtx* wrappers MIME-Version: 1.0 On Sat, Nov 22, 2025 at 12:50:19AM +0100, Christos Margiolis wrote: > On Fri Nov 21, 2025 at 9:46 PM CET, Shawn Webb wrote: > > On Fri, Nov 21, 2025 at 08:45:27PM +0000, Shawn Webb wrote: > >> On Fri, Nov 21, 2025 at 04:15:03PM +0000, Christos Margiolis wrote: > >> > The branch main has been updated by christos: > >> >=20 > >> > URL: https://cgit.FreeBSD.org/src/commit/?id=3D9d18115ca0ab0ef3f3417= 3d4e2bdabec916d0b60 > >> >=20 > >> > commit 9d18115ca0ab0ef3f34173d4e2bdabec916d0b60 > >> > Author: Christos Margiolis > >> > AuthorDate: 2025-11-21 16:14:33 +0000 > >> > Commit: Christos Margiolis > >> > CommitDate: 2025-11-21 16:14:47 +0000 > >> >=20 > >> > sound: Retire snd_mtx* wrappers > >> > =20 > >> > Do not create mutexes with snd_mtxcreate(). It doesn't provide a= ny > >> > value, plus it first allocates the mutex with malloc(9). Allocate > >> > mutexes in the stack and use mtx_* functions directly instead of= the > >> > snd_mtx* wrappers. > >> > =20 > >> > Sponsored by: The FreeBSD Foundation > >> > MFC after: 1 week > >> > Reviewed by: kib, markj > >> > Differential Revision: https://reviews.freebsd.org/D53855 > >>=20 > >> Hey Christos, > >>=20 > >> I'm getting the following error on buildkernel: > >>=20 > >> =3D=3D=3D=3D BEGIN LOG =3D=3D=3D=3D > >> /usr/src/sys/dev/sound/pci/hdspe-pcm.c:726:3: error: call to undeclare= d function 'snd_mtxunlock'; ISO C99 and later do not support implicit funct= ion declarations [-Werror,-Wimplicit-function-declaration] > >> 726 | snd_mtxunlock(sc->lock); > >> | ^ > >> 1 error generated. > >> --- hdspe-pcm.o --- > >> =3D=3D=3D=3D END LOG =3D=3D=3D=3D > > > > Never mind. I didn't realize HardenedBSD had a change to that file. > > Sorry for the noise! >=20 > So all good? Out of curiousity, what change is there on HardenedBSD? Yeah, all good. There's a potential NULL pointer dereference due to a lack of a return value check from malloc(..., M_NOWAIT). I haven't done any determination as to whether the bug is triggerable, but it exists nonetheless. Thanks, --=20 Shawn Webb Cofounder / Security Engineer HardenedBSD Signal Username: shawn_webb.74 Tor-ified Signal: +1 303-901-1600 / shawn_webb_opsec.50 https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb/03A= 4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc --7puhdlcpwo2btcjb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAmkg+5oACgkQ/y5nonf4 4fpNRxAAoO03A0rx+VjBwHr/DzOoWVg9es2taCmqBzRSctOXGdOQhY2lgFNyiHCq gLfI5cRNlAff6kL6w9enDOeKDthkyry1k5nnQDJSkgbuZ1Yg73TnW2EivLm3xYaP qXVGW5nQvltQyRnR14q9kAg1osFEoQUKYqHGBacu+vePv43x8NRW5MY03LTX7cfd ISSbuRsmkfT/Pmsl/DZjXdg7m5GAy7FVEd48owzBYiEoYZp9BzUtwpXWFMNLm31t IsyVDMgJoJfKaeonK6fCmaU2nR59l6/00HC7gyJLnC+s72muKBcKLM5pAwuKgcCr pwLCH8FnOU9b02q5STW7EZ4ng7QYz2IWVhFreIhEf9O+9ipezId9SvuunKDIIAfY 0lG82ol4zP8KLQ7BV0eR+A/7o5itQ1dX8uxiZRrUe5wBhwbTaX0FULOsU8U++xxa Pav7DXYDA435II1A25+7lJmmFUetdIW9e48pQGyDDE1+3wwqIAiCWeNZy4pMpn51 zTvgIQzvwhMmO6HKDvQZnInMG2eQQjvIXFqJob2tQV3M3BlFv4ytr+pkortBXnEg BebndJENtWwAgIAHgaNCqcUPhE6QMbpsNhS+4f1F8IHgwvU/OzdmU71f+yJThS82 jrYvyzZ9ovDYh6sjSbsjW2LfLfSiVw1sM+JvYSo6HXcYUsUWwBs= =P0vQ -----END PGP SIGNATURE----- --7puhdlcpwo2btcjb--