From nobody Fri Nov 21 20:46:18 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dCnLj2kcSz6HkqS for ; Fri, 21 Nov 2025 20:46:21 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-io1-xd2e.google.com (mail-io1-xd2e.google.com [IPv6:2607:f8b0:4864:20::d2e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dCnLh4fWyz3sgH for ; Fri, 21 Nov 2025 20:46:20 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=hardenedbsd.org header.s=google header.b=QxeoLVwe; dmarc=pass (policy=none) header.from=hardenedbsd.org; spf=pass (mx1.freebsd.org: domain of shawn.webb@hardenedbsd.org designates 2607:f8b0:4864:20::d2e as permitted sender) smtp.mailfrom=shawn.webb@hardenedbsd.org Received: by mail-io1-xd2e.google.com with SMTP id ca18e2360f4ac-949031532f9so103500239f.0 for ; Fri, 21 Nov 2025 12:46:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd.org; s=google; t=1763757980; x=1764362780; darn=freebsd.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=oPa4Hhnwj/zKWdUiLlDCtPxtxBihWcy92oJxD3ELs7g=; b=QxeoLVwe4X0GAWiRZelD9i8osiJMJVYKiNxkfb++aqmV+jmMcLSjbbhKccCvnez+f2 nZNgfX1LhjWbktZ4vSzhkM+hIttbSyjwtB4BJXEBdTsXENJ1F3PAHVMEqlMHmjMTTIpw eoftPZiU3fz41sMZYsxf3Pf6TbGdURR8pe3ZxqTth9baWaNMMIbx1nQGZVEMZpH+3x+f 20bndZuxvGYjBfWfGcN4OK0bnKPDBaEKF/AkcJDh5odlpqQ8PbGZu7YXREmB4ODYc2Tw 48TNhZtoIdO72GGuQ+uQynu9hVrRJYOEWqo1h40oygdy4EqUAGmfPdCW5ribydGd5PSG iD2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763757980; x=1764362780; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oPa4Hhnwj/zKWdUiLlDCtPxtxBihWcy92oJxD3ELs7g=; b=EeIvaUwpH3aI8H67u4T6h8BcPYoMD8SMQ8A8xjB5U3Ed8qvmxT/c4F7T2QKtUBDyK8 mlpexaVk2KuCKKu/ygRvqzuEfxusGkZHPY1mmMdVe+44NwCmBG888Mq08omLtGVHy8li NQ2HzjI3V+5DPeYvbHS6WN9jpFtGBxoMwy0N5k5CAFz7FqgnOpAwug7GSNXeFjBBcxLU RcuK2mRte9Uof57EJ+cIvU824vz6fc0HcyHVvbCKRGMjDLz6PPJlmLjwV2wIVKRNZScZ LdLE7ErTa0iGcdta2mbFe6TmA9tEp//uNib47LV7dJ5FAGnb9EsSx/iKS6tbNddLJ+bv yNhA== X-Forwarded-Encrypted: i=1; AJvYcCWhN/3IFPpOJCLla0BR5j5cTC1SsSyVEd1K9fUSaGIXnYtkW5ZYktBpk/5kZ0mXpZ/i/Bh4JHpCh3MoHL4bZ2wvtyokYg==@freebsd.org X-Gm-Message-State: AOJu0YyG2xBhXY7LVhWn2kulAGqnvhiwOTNvTtfyvXrDEvt++/OSykHC Y5zuJQBpmGOqvhD+sCVZh8Vk0iVU4bq3mugQ61hqJZ2nLt3tQUXqLKE6QzOh6xuoWARxfRoC7ZT d8bSLDyA= X-Gm-Gg: ASbGncvn+EIFR24ri5A2PvP7tR8q3OOShimRSwgUw8RcuWtvHe1DB/P8C2VDgbJcljX p1tH8poPO4/3bLrIsGlHzEr7dtx5rXdm+KbgcIge9KpJT/PNVWDEU21QKDK66rWBkqSLgA0kgyP rZWPdqnXdfJzibHvcwU6d3spUsnL5/sx2FqeYU4+YBS9UXuc1c/rtzyfrXp6ENvktReMTCc/aKO J1Czc3cXcGR0/Z8jvw85p450n0PCx1fptucLaKjFfyINkqZfFbjwvWC8iGpLATx5bvrXBNRP22y FBIEOXq/2ugpT3WLu4RRFiNjaDUJpg25PxjyWxsMpRriqVogmzMWYin9mMCYYdRj3tKXM3FCpiu oGK9Jnp9M73TuTrj24TJZ31N7Atn1OylNTYVphzX2NadnBItdggorINM1XHADghp/qDql X-Google-Smtp-Source: AGHT+IH4HTdsoF/ujSDWYURs0IQV3nBv3wNNilRNFetNGU4sBnWcTGyspBPmTADlrCnAJybOrWqwxg== X-Received: by 2002:a05:6638:8721:b0:5b7:10ea:e2a7 with SMTP id 8926c6da1cb9f-5b965b1af7bmr3177228173.8.1763757979916; Fri, 21 Nov 2025 12:46:19 -0800 (PST) Received: from mutt-hbsd ([2001:470:4001:1::95]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-5b954a501d1sm2492523173.16.2025.11.21.12.46.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Nov 2025 12:46:19 -0800 (PST) Date: Fri, 21 Nov 2025 20:46:18 +0000 From: Shawn Webb To: Christos Margiolis Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 9d18115ca0ab - main - sound: Retire snd_mtx* wrappers Message-ID: X-Operating-System: FreeBSD mutt-hbsd 14.3-STABLE-HBSD FreeBSD 14.3-STABLE-HBSD HARDENEDBSD-14-STABLE amd64 X-PGP-Key: https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/blob/master/Shawn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc References: <69209007.369f8.65e30118@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="g6rt7fkzi6mxchvd" Content-Disposition: inline In-Reply-To: X-Spamd-Bar: ----- X-Spamd-Result: default: False [-5.60 / 15.00]; SIGNED_PGP(-2.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; MID_RHS_NOT_FQDN(0.50)[]; DMARC_POLICY_ALLOW(-0.50)[hardenedbsd.org,none]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; R_DKIM_ALLOW(-0.20)[hardenedbsd.org:s=google]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-main@freebsd.org]; MIME_TRACE(0.00)[0:+,1:+,2:~]; MISSING_XM_UA(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TO_DN_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::d2e:from]; FROM_HAS_DN(0.00)[]; RCVD_TLS_LAST(0.00)[]; ARC_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; RCPT_COUNT_THREE(0.00)[4]; DKIM_TRACE(0.00)[hardenedbsd.org:+] X-Rspamd-Queue-Id: 4dCnLh4fWyz3sgH --g6rt7fkzi6mxchvd Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: git: 9d18115ca0ab - main - sound: Retire snd_mtx* wrappers MIME-Version: 1.0 On Fri, Nov 21, 2025 at 08:45:27PM +0000, Shawn Webb wrote: > On Fri, Nov 21, 2025 at 04:15:03PM +0000, Christos Margiolis wrote: > > The branch main has been updated by christos: > >=20 > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D9d18115ca0ab0ef3f34173d4= e2bdabec916d0b60 > >=20 > > commit 9d18115ca0ab0ef3f34173d4e2bdabec916d0b60 > > Author: Christos Margiolis > > AuthorDate: 2025-11-21 16:14:33 +0000 > > Commit: Christos Margiolis > > CommitDate: 2025-11-21 16:14:47 +0000 > >=20 > > sound: Retire snd_mtx* wrappers > > =20 > > Do not create mutexes with snd_mtxcreate(). It doesn't provide any > > value, plus it first allocates the mutex with malloc(9). Allocate > > mutexes in the stack and use mtx_* functions directly instead of the > > snd_mtx* wrappers. > > =20 > > Sponsored by: The FreeBSD Foundation > > MFC after: 1 week > > Reviewed by: kib, markj > > Differential Revision: https://reviews.freebsd.org/D53855 >=20 > Hey Christos, >=20 > I'm getting the following error on buildkernel: >=20 > =3D=3D=3D=3D BEGIN LOG =3D=3D=3D=3D > /usr/src/sys/dev/sound/pci/hdspe-pcm.c:726:3: error: call to undeclared f= unction 'snd_mtxunlock'; ISO C99 and later do not support implicit function= declarations [-Werror,-Wimplicit-function-declaration] > 726 | snd_mtxunlock(sc->lock); > | ^ > 1 error generated. > --- hdspe-pcm.o --- > =3D=3D=3D=3D END LOG =3D=3D=3D=3D Never mind. I didn't realize HardenedBSD had a change to that file. Sorry for the noise! --=20 Shawn Webb Cofounder / Security Engineer HardenedBSD Signal Username: shawn_webb.74 Tor-ified Signal: +1 303-901-1600 / shawn_webb_opsec.50 https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb/03A= 4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc --g6rt7fkzi6mxchvd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAmkgz5oACgkQ/y5nonf4 4fq0PQ/9Gy5dzYOscqplx0tQKfutUcCFv0bSuKigaSMMl9Y8ToyK+oZgKMFJc62F 6AA4n2vaEK5GBxe9vr/jDyjVKM43oAHuXaK8nMYdZUZW2N/xRN+sesqBB+WfCO1y Xsuz4tKBQ7F4y21TX0eegjK6rixPNhPr2r29KhQz9Cg7O3H7Hc/RhifXIl6vKYN5 HYpbIgYuNcoS/kg2/HU8BhrksofQwLB1Ha2LBN57R3FLhFjva+Btlwb0Ic5P6JHQ bpG+pOdxhV90eJBbRpgZRwE1wlnjdEtHuGcDRidFlEXeb/J2mekMpLyiLmjZ82WK kT2zVO+AGGrHs+nPAoZLURGrvGOLo7MXCDbsuw1F4R5r982XByJVW9oqYKHMoUyd E/o1qBa5vylnUQtYfvWKlM7qj90ny5VfrPXfmXzmSp2S5sJ9GJu1dJRmeHEyow44 zyepW5lzoqB5gOvf1CojpTAXD3bFZWd4qBSOuvoRv74/5LY+kGkzm9vOtUOpoGbX 7aB7h3nqu7iub762hJQFdt3EoqBRmlRr/X0EMszqT0DDnUke/kj1DTrT6nET/23M X6Oi8YHxfjBvE/Tmq1tTPfh22eDxz8PAVJ3XpJS8fC9syj5fhisOr0qBzS/xblWd yUOzq5unzcIkFQ5pXG8L+bbcV+GLqSmeRjiUTMGDb6iLV5iBy80= =1t/x -----END PGP SIGNATURE----- --g6rt7fkzi6mxchvd--