From nobody Fri Nov 21 06:44:32 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dCQgN66zbz6Gh3W for ; Fri, 21 Nov 2025 06:44:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dCQgN4Q6Nz3pfd for ; Fri, 21 Nov 2025 06:44:32 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1763707472; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=h9tV81GOu9E5Spp+EgaW2Kc8TBXCylXpqBPdUYMSdFI=; b=Kci3YzTHI76s2N7VONC/zSvwdrUq6UjxhCPTyoe0i6JusjET4NlogNgW0zJHkxeeJXMaL2 iZVPuXlAnIXOjEfK8IMEvmtUUOAn7zljb+TluIGIffHVbYXEFC4D12aIE5eJ3FhRngARBS YbCO7YmQ5kxTo/2Yn/TSSi9WcOlOsD27E6hEUcd4fpxoz3IyJeGMD9080KQG7djavBRY1e kKh/kfU3rBxkUpxeqZMKU1RNZkaPEReAQYNlaeWQtAbJvxlHxlLozV0TBDbSuKS8eg6M75 iL2Y+tcJgbzJ5agckc6dUIZO5//Zqp4gGooFSRNlVpD5ibAVHJAlgf70iT1A0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1763707472; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=h9tV81GOu9E5Spp+EgaW2Kc8TBXCylXpqBPdUYMSdFI=; b=JRRALj25qrwTJd/5OgsNwv2P2g85zmOKg6Rclc0kuzpP+hr/jTE9AfOL/pVcM7dVXTjV0G L+2xVPWosHcEB2jCNasqGXGWI0QJhrHVe85l8WpnMz5fVfh3VHM0/PYTuwIeelZ6TwWlvK WBU7wuLmwheNxe8WopetNPgRWLpXN7G1yAnnV3BGHVRcdaYzm5K7j1H/xL+B9uzcbHUocG blzuZD5MLIH37kNbSsDL9bDOplqrZB9GrjfMkLH7EzhBLHAri/K+aQtYCmLeJciUfFNg31 E7iUprw7eqjn7NSanV5+kgB2YWf8AvFUqhMsBlOGt7GIjOArhSOTlrpnsYGPBg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1763707472; a=rsa-sha256; cv=none; b=nhZFLdWH2eafYh/LikDn9tAXAdmDkfnn+uLRwLt1dfeGxLtC46F1VWm7CR1ewLqmEr2x7Q iuiPPq7lSXERZCskmxAmi4nDUwPkbttltRIjhIBOBa7mraiuUovXqNWfFXCPRYq8HPGRH5 eKsdwbmC0CjW1pW4Cpm9T/iWW9zshq+oet2bw+4IHiKgHDwH2QDYBMAx5yVRlSVX8AdJ02 KAx4aZLAFfH0wc8gslNs3Xxhze5oX3W+W0soLjMzdFQxxcZgTTs/V6KkxX+r+KD3E0S0jo u4C94YAPc1Mhi8ci1dSa0HdmSxtGLKd+zHRpl6OXg7i3ZEEIRl2y5xlP/SF2Zw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dCQgN3zpCz11ht for ; Fri, 21 Nov 2025 06:44:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 266ca by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 21 Nov 2025 06:44:32 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kevin Bowling Subject: git: 2ead091715de - main - e1000: Don't enable ASPM L1 without L0s List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 2ead091715dee327b3e00bc9840e1a95827b8e82 Auto-Submitted: auto-generated Date: Fri, 21 Nov 2025 06:44:32 +0000 Message-Id: <69200a50.266ca.53cb7ac8@gitrepo.freebsd.org> The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=2ead091715dee327b3e00bc9840e1a95827b8e82 commit 2ead091715dee327b3e00bc9840e1a95827b8e82 Author: Kevin Bowling AuthorDate: 2025-11-21 05:47:03 +0000 Commit: Kevin Bowling CommitDate: 2025-11-21 06:44:25 +0000 e1000: Don't enable ASPM L1 without L0s Reporter noted packet loss with 82583. NVM is down level. The errata docs mention disabling this, which should be the firmware default, so I am not sure why we were enabling this bit. Linux and OpenBSD have the same issue, while NetBSD got it right. Reported by: Codin Tested by: Codin MFC after: 2 weeks --- sys/dev/e1000/e1000_82571.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/dev/e1000/e1000_82571.c b/sys/dev/e1000/e1000_82571.c index e8970adf996f..650169663f56 100644 --- a/sys/dev/e1000/e1000_82571.c +++ b/sys/dev/e1000/e1000_82571.c @@ -1118,7 +1118,8 @@ static s32 e1000_init_hw_82571(struct e1000_hw *hw) case e1000_82574: case e1000_82583: reg_data = E1000_READ_REG(hw, E1000_GCR); - reg_data |= E1000_GCR_L1_ACT_WITHOUT_L0S_RX; + /* 82574 Errata 25, 82583 Errata 12 */ + reg_data &= ~E1000_GCR_L1_ACT_WITHOUT_L0S_RX; E1000_WRITE_REG(hw, E1000_GCR, reg_data); break; default: