From nobody Fri Nov 21 06:44:31 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dCQgM5Yt8z6Ggjk for ; Fri, 21 Nov 2025 06:44:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dCQgM4lcYz3pc6 for ; Fri, 21 Nov 2025 06:44:31 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1763707471; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=eufTyKEBXyi5qomNsL4WfYwxWhaS6zMc4BeVExwtvj8=; b=qgGrvZ1D9mJFc8ndoH2eee73MtBTS/IFiYdRdDN7MWb1uwxYUS7YOB2QGFvPn672zPvYAe etm1eBpxMt4nsZRNcAY7dhWMdhqa4SQVL9CbMchYR+BE9UmXiSNsPP9FGHSYy3rSMVwJ4R XT7bht9LQQ3MpG8/g9B1wQYUE1fAe9J1h0OaxyC4xcdTQKUgO0OnwRzU2IWad/kv0PaXDn 9UcEyUzFySqF8aUzmv9LT/B7Z6X2xEQOWc4VkTDC5Nc9LHj2jfD2bsTbGEUa1HRC0K0XoX S0ymnN2/rSkHW2FKC7cvmh7XWE2JoCE+htHFD7xuS7MUUPaqjj3uBYtNiv9s6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1763707471; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=eufTyKEBXyi5qomNsL4WfYwxWhaS6zMc4BeVExwtvj8=; b=Z+KxVKZlbz/3/ixtJj4WEYD3wMhubVouODJTE/ML5LLfaZX/gAiqKaraMsoGVBSQL13ldY WIEnBphR06ZZTUtlc835AoU8mhESjDxSNMDDvsPLe36/f3CfpoE9xJtcTLeFWNnppAjzYr Zc4myZ1UbG5I9XzHu5Lywl9ZyIi4KIzyAyw4vSmTkP94Rp3B8RWLHg17ErPwuksh5OFqQz MZQIINn/BLHs+7MFEmdyMlIJymhshyWzIgxcu3qaOhh/d2FnXETjCzuHCTnGKWbh6SO8Ca Gj9b812XcYZ1b86ztSloneUE8R7zIiD9tZlq2g/cDhOaK7N/Q6U2+MYE5vUWcg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1763707471; a=rsa-sha256; cv=none; b=ccNCHvilu5a59q5EmiQFL1BXt2ao97wPsgPTdV8bzi4WqR9wywNgX76lxDtaJqialgprdh XA7hQFEpfSWkGy1vSK22BlNDa0CGp86zCTIHvnQUeZ1906p2gtjA/OmYkinBPdTBWRBVvK UdJ9mAW3ki9uLcZdxzUnjV3WrGLlLW+gLeWaOlM5nmOtzf1iiub9CQhV5g5p/cHZoIwcnE IFkus5BYmaMB4mR89hbgimNIw8zbK/IaMCg58aYKr9H/D6vmolapC3b0bJCTKjntuuBw9F VPGz7EXIGOlGD0/5at38Zhb+PjKUBjpz01TBkXgtFtaNDiBdE5CdrDITyLLLSQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dCQgM3hq2z11wn for ; Fri, 21 Nov 2025 06:44:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 26e65 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 21 Nov 2025 06:44:31 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kevin Bowling Subject: git: aa30bab9a92e - main - e1000: Bump 82574/82583 PBA to 32K List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: aa30bab9a92e1be230b9708bff9f33aae7d384e5 Auto-Submitted: auto-generated Date: Fri, 21 Nov 2025 06:44:31 +0000 Message-Id: <69200a4f.26e65.2d94d0c5@gitrepo.freebsd.org> The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=aa30bab9a92e1be230b9708bff9f33aae7d384e5 commit aa30bab9a92e1be230b9708bff9f33aae7d384e5 Author: Kevin Bowling AuthorDate: 2025-11-21 05:02:00 +0000 Commit: Kevin Bowling CommitDate: 2025-11-21 06:44:25 +0000 e1000: Bump 82574/82583 PBA to 32K The reporter contacted me with packet loss and throughput fluctuations on a low power machine (Intel J1900) that got worse with the recent AIM algorithm in FreeBSD 14.2+. 32K RX PBA matches Linux default. Add a conditional path since we don't otherwise do a fixup for jumbo frames to retain space for two frames in Tx. With this change and an additional errata change, the throughput meets line rate for the reporter. Reported by: Codin Tested by: Codin MFC after: 2 weeks --- sys/dev/e1000/if_em.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/sys/dev/e1000/if_em.c b/sys/dev/e1000/if_em.c index b8ea3168330b..02f4c431badd 100644 --- a/sys/dev/e1000/if_em.c +++ b/sys/dev/e1000/if_em.c @@ -3080,9 +3080,13 @@ em_reset(if_ctx_t ctx) case e1000_82573: pba = E1000_PBA_12K; /* 12K for Rx, 20K for Tx */ break; + /* 82574/82583: Total Packet Buffer is 40K */ case e1000_82574: case e1000_82583: - pba = E1000_PBA_20K; /* 20K for Rx, 20K for Tx */ + if (hw->mac.max_frame_size > 8192) + pba = E1000_PBA_22K; /* 22K for Rx, 18K for Tx */ + else + pba = E1000_PBA_32K; /* 32K for RX, 8K for Tx */ break; case e1000_ich8lan: pba = E1000_PBA_8K;