From nobody Wed Nov 19 20:08:56 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dBXck6VRJz6JCMF; Wed, 19 Nov 2025 20:09:10 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from mx-01.divo.sbone.de (mx-01.divo.sbone.de [IPv6:2003:a:140a:2200:6:594:fffe:19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature ECDSA (prime256v1) client-digest SHA256) (Client CN "mx-01.divo.sbone.de", Issuer "E8" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dBXch1H1Yz3qsb; Wed, 19 Nov 2025 20:09:07 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=zabbadoz.net header.s=20240622 header.b=ZDSofJ6u; dmarc=pass (policy=none) header.from=zabbadoz.net; spf=pass (mx1.freebsd.org: domain of bzeeb-lists@lists.zabbadoz.net designates 2003:a:140a:2200:6:594:fffe:19 as permitted sender) smtp.mailfrom=bzeeb-lists@lists.zabbadoz.net Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by mx-01.divo.sbone.de (Postfix) with ESMTPS id CAC1CA64805; Wed, 19 Nov 2025 20:08:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=zabbadoz.net; s=20240622; t=1763582925; bh=w/iSlTWMB7sDqDB2VYdCWZRqjXYwhZzqhMp4UV0wW4A=; h=Date:From:To:cc:Subject:In-Reply-To:References; b=ZDSofJ6ueNfVfZ8hXIAWQePqDs9U86r1QijdvfjBDQd9z8s3gr3Ok1NKfRFWtHiD2 3qN/rPPbzib+wexv4wdjdOqIPmAINh1SWeJpPckyNwMfhwrOAPfdZ3gMmB46lSt5Ai r9DM0FzZYMa63RECANDmluImQmtruwlK8eD8fhYPER1BYbjZFRX+fpg4/g2FR2h1xu 5gIspUGydXWuQowgCSgcEbfEjILrQQiHVE4fAT7Z270hxWNXRN8gwb3e79fLaaBGkj mppTfa4ib3tmtcXgWIoXeR6R5SHq9akOOQBKYw0wuqOcHzgOmlJk6YkjYKHzwpSUSv ILk0HigWV+xV9l+nr55cP80I84PZT0nBP5L87a2P2CYEv2IMo/ckpX/67nytMEjzZk hec+q8o++1uwfQgEld4lEPLDZmCEjfDS7Mcxei7ujtw2+dmHjNmu+RgliA3JzTjf5G lf+al2ks6QiyWap6CQfzfj4wA9g7DVP0d39qDOQX8WVQai0LDfmuGwDKY59L/PrwkD /7myZqaRH32oIvIN4muqS92cdcwLXGiG8kuXbs7ypicblof9VAGIUKiT7hzjmUY70W uZhV5oAbCr0zWV+2mNQ4FByUYq5Tyi2xSdo/eWnDlnEZAtl9oxl4eqkpWOKhCCl715 1H+/tjcpP9/u+QwI67uuPTtU= Received: from content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id 5D0DC2D029E6; Wed, 19 Nov 2025 20:08:58 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) by content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (amavisd-new, port 10024) with ESMTP id SIiD3E97ojev; Wed, 19 Nov 2025 20:08:57 +0000 (UTC) Received: from nv.t4-02.sbone.de (nv.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:22]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id E1BBF2D029D8; Wed, 19 Nov 2025 20:08:56 +0000 (UTC) Date: Wed, 19 Nov 2025 20:08:56 +0000 (UTC) From: "Bjoern A. Zeeb" To: John Baldwin cc: Warner Losh , src-committers , "" , "" , Wanpeng Qian Subject: Re: git: 20e94950c54e - main - nvme: Notify namespace changes better In-Reply-To: Message-ID: References: <691cdf72.35308.1c1c6fc1@gitrepo.freebsd.org> <1osso5q5-74o7-pr61-q328-n6451nor36q4@mnoonqbm.arg> X-OpenPGP-Key-Id: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="0-2078512504-1763582936=:11296" X-Spamd-Bar: -- X-Spamd-Result: default: False [-2.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; CTYPE_MIXED_BOGUS(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.99)[-0.994]; DMARC_POLICY_ALLOW(-0.50)[zabbadoz.net,none]; R_DKIM_ALLOW(-0.20)[zabbadoz.net:s=20240622]; R_SPF_ALLOW(-0.20)[+ip6:2003:a:140a:2200:6:594:fffe:19]; MIME_GOOD(-0.10)[multipart/mixed,text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; MISSING_XM_UA(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+,1:+]; ASN(0.00)[asn:3320, ipnet:2003::/19, country:DE]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org,dev-commits-src-main@freebsd.org]; RCVD_COUNT_THREE(0.00)[4]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[freebsd.org,gmail.com]; RCPT_COUNT_FIVE(0.00)[6]; FROM_EQ_ENVFROM(0.00)[]; TO_DN_ALL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_TLS_LAST(0.00)[]; DKIM_TRACE(0.00)[zabbadoz.net:+] X-Rspamd-Queue-Id: 4dBXch1H1Yz3qsb This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --0-2078512504-1763582936=:11296 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8BIT On Wed, 19 Nov 2025, Warner Losh wrote: > On Wed, Nov 19, 2025, 11:01 AM Bjoern A. Zeeb < > bzeeb-lists@lists.zabbadoz.net> wrote: > >> On Tue, 18 Nov 2025, Warner Losh wrote: >> >>> The branch main has been updated by imp: >>> >>> URL: >> https://cgit.FreeBSD.org/src/commit/?id=20e94950c54e398049396647da36b9e2c3b639c1 >>> >>> commit 20e94950c54e398049396647da36b9e2c3b639c1 >>> Author: Wanpeng Qian >>> AuthorDate: 2025-11-18 15:24:23 +0000 >>> Commit: Warner Losh >>> CommitDate: 2025-11-18 20:32:22 +0000 >>> >>> nvme: Notify namespace changes better >>> >>> When we get a namespace notification, we have to reconstrut the >>> namespace to get the new identification data from the namespace. For >>> each namespace in the AEN, we will reconstrict it before we call the >>> notification. We also flag it as changed for the duration of the >> change >>> callback (prior versions of the patch needed to keep track, but we no >>> longer do, so this bit may be removed). Note when we've seen the >>> namespace so we can notify when it goes away. >>> >>> Co-authored-by: imp >>> Differential Revision: https://reviews.freebsd.org/D33032 >>> --- >>> sys/dev/nvme/nvme.h | 7 +++++-- >>> sys/dev/nvme/nvme_ctrlr.c | 12 +++++++++++- >>> sys/dev/nvme/nvme_ns.c | 9 ++++++--- >>> 3 files changed, 22 insertions(+), 6 deletions(-) >> >> Just replying to one of the multiple commits: >> >> It seems from somewhere a VIMAGE enabled kernel is pulling >> in systm.h for memmove; LINT-NOVIMAGE fails without the below: >> >> % git diff >> diff --git sys/dev/nvme/nvme.h sys/dev/nvme/nvme.h >> index 8f7a7fbda14c..e17c2bf41a5a 100644 >> --- sys/dev/nvme/nvme.h >> +++ sys/dev/nvme/nvme.h >> @@ -31,6 +31,7 @@ >> >> #ifdef _KERNEL >> #include >> +#include >> #endif >> >> #include >> > > I'll take a look, but i didn’t think i added a memmove. It's in the header file. Oh I missed jhb's changes. It was him in 8d2a50bb38051. Sorry. -- Bjoern A. Zeeb r15:7 --0-2078512504-1763582936=:11296--