From nobody Wed Nov 19 19:56:18 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dBXL95p5rz6JBJ2 for ; Wed, 19 Nov 2025 19:56:33 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dBXL93sHBz3nZs for ; Wed, 19 Nov 2025 19:56:33 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-pj1-x102b.google.com with SMTP id 98e67ed59e1d1-343dfb673a8so54738a91.0 for ; Wed, 19 Nov 2025 11:56:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1763582191; x=1764186991; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=KE5x/LhkKXEtj2065YOmwkggAPES+gd+A45VzXJkT88=; b=al1Hg39umg/vi5zj0sCkRWXVZ/7VoVV5HzOFzrL0RU72xCfml3+pWR+vcC7TljEmF7 a8PuE7+gWNceBDQLEamwZy/btr7/usgIm9sQ3kyufcHd9mc7U/aN6htW4Ex9lhxKa/bf xwvvbz3qrPaGV/PhdWvEQBv8XltQvdFJMmxcNUCkEWP4WYVjgLUO5/YWPHe65nW7pDX/ Sp7MnbxukW3qMKJQghWhaqvdIjQ4FjblNzZIEccVrLk/JDT2EYELknNABCsVSB0bSltQ OTYfBqKNvGSPbWGkypywstCxGGbKSgcVqKOOVyNQbxnjKeBxjpJfIeMN0dTFFNtGjxHb 5msA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763582191; x=1764186991; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KE5x/LhkKXEtj2065YOmwkggAPES+gd+A45VzXJkT88=; b=hlxswzlCQtlqJvDA3+Z/dAeuPu/zMnL40T3m5RI0MLSqxXV7KkfY9tuNZDVepFJ/Uz jD/1GuAaUDmH+v0LdhYfolldyQQtrhk5By2ZBeBilhprhLjAl0z1TGS9ssgrXRLvQDoC j+hmIBeYuDOCKHAN++vciTfu/szQWt4QmJu3QfU1jccdrMNfY00z5cJFevfn9L1wvIdz 6vO7WlSCBIEsxEGnABUYLhsweWX+pbFCvOmsMOmt594D6FL1RFh6A8jdVdEfoF6cxfBK Nw6ZQ+8A+XltETJrXB70cfSZ1jI7I8qrn0HAu+sAWAZ9RoBYgQnJxh2xZUt+OOgO3dqg vu6A== X-Forwarded-Encrypted: i=1; AJvYcCX1A78jxNLBLxVnhlQtel2FsEyIJV+dkeKYpJyg7uEYRyFreQAAw6ZhaguZJq0nvNDjyeNBdptiQcqMcSpu4QqLVozyjg==@freebsd.org X-Gm-Message-State: AOJu0YxHtmSJizac1zUV6GOI8hdPXwt3YdpSlL9RXWwkrx0Bt2egvn2E H5zf9NbqxDsSKjCbNbD3wJpZAu67a9UdsgPLCqBpNxmV35GBuJMmavYBCzDZ1oOPvC64wdiFiNp tm09vA25+RO4IaGqKbR3h+1wi38lmjX2b9CoQn7YFow== X-Gm-Gg: ASbGncsApIiLXUXCRfJIjtGD5X1aeIrv37mLP2IDO4utPYjaCJfjlW5xfxO5R4qgUPJ xih1Xpea5q+zCVyCWAwidsxC+7TJ35sDrWhG6an09rgamnBO5MFMre3K0sa5r+8XucZtgycfo0u ZrIhd3m2sSsSz15XvXvOhP6+926E+L/o9dufONJq49jBt21Lffg/ZQXFYsxP6c75Bjlt+HPsNl1 zqT2gMs7TZ28Og6nRPNeCTNt13S2AkvQYmDQzZUbYbcSN70CjKpMKCNqe3Q8UzxlclIYCTYD7iz G7x57SSxKJFCzP0y6Ww+ITyf2A== X-Google-Smtp-Source: AGHT+IFwX5xT8y//W3cmTehhX1p4gHJSYyZQhUcPcbxlD6TIBoIXPQZK/QDpq2OGyfrfIC996x9al7nw24d2BUxbzzg= X-Received: by 2002:a17:90b:3d8c:b0:343:bd86:b5a6 with SMTP id 98e67ed59e1d1-34728533820mr210891a91.34.1763582190960; Wed, 19 Nov 2025 11:56:30 -0800 (PST) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 References: <691cdf72.35308.1c1c6fc1@gitrepo.freebsd.org> <1osso5q5-74o7-pr61-q328-n6451nor36q4@mnoonqbm.arg> In-Reply-To: <1osso5q5-74o7-pr61-q328-n6451nor36q4@mnoonqbm.arg> From: Warner Losh Date: Wed, 19 Nov 2025 12:56:18 -0700 X-Gm-Features: AWmQ_bnzGg-1c8DTJ0EELRwFiWhy9H6fwTcV_Hzk614EjUjs6Bb1D-5s8kRPhNM Message-ID: Subject: Re: git: 20e94950c54e - main - nvme: Notify namespace changes better To: "Bjoern A. Zeeb" Cc: Warner Losh , src-committers , "" , "" , Wanpeng Qian Content-Type: multipart/alternative; boundary="000000000000064edb0643f7faf5" X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4dBXL93sHBz3nZs --000000000000064edb0643f7faf5 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Nov 19, 2025, 11:01=E2=80=AFAM Bjoern A. Zeeb < bzeeb-lists@lists.zabbadoz.net> wrote: > On Tue, 18 Nov 2025, Warner Losh wrote: > > > The branch main has been updated by imp: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=3D20e94950c54e398049396647da36b9e= 2c3b639c1 > > > > commit 20e94950c54e398049396647da36b9e2c3b639c1 > > Author: Wanpeng Qian > > AuthorDate: 2025-11-18 15:24:23 +0000 > > Commit: Warner Losh > > CommitDate: 2025-11-18 20:32:22 +0000 > > > > nvme: Notify namespace changes better > > > > When we get a namespace notification, we have to reconstrut the > > namespace to get the new identification data from the namespace. For > > each namespace in the AEN, we will reconstrict it before we call the > > notification. We also flag it as changed for the duration of the > change > > callback (prior versions of the patch needed to keep track, but we n= o > > longer do, so this bit may be removed). Note when we've seen the > > namespace so we can notify when it goes away. > > > > Co-authored-by: imp > > Differential Revision: https://reviews.freebsd.org/D33032 > > --- > > sys/dev/nvme/nvme.h | 7 +++++-- > > sys/dev/nvme/nvme_ctrlr.c | 12 +++++++++++- > > sys/dev/nvme/nvme_ns.c | 9 ++++++--- > > 3 files changed, 22 insertions(+), 6 deletions(-) > > Just replying to one of the multiple commits: > > It seems from somewhere a VIMAGE enabled kernel is pulling > in systm.h for memmove; LINT-NOVIMAGE fails without the below: > > % git diff > diff --git sys/dev/nvme/nvme.h sys/dev/nvme/nvme.h > index 8f7a7fbda14c..e17c2bf41a5a 100644 > --- sys/dev/nvme/nvme.h > +++ sys/dev/nvme/nvme.h > @@ -31,6 +31,7 @@ > > #ifdef _KERNEL > #include > +#include > #endif > > #include > I'll take a look, but i didn=E2=80=99t think i added a memmove. Warner > -- > Bjoern A. Zeeb r15:7 > --000000000000064edb0643f7faf5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Wed, Nov 19, 2025, 11:01=E2= =80=AFAM Bjoern A. Zeeb <bzeeb-lists@lists.zabbadoz.net> wrote:
On Tue, 18 Nov 2025, Warner Losh wrote:

> The branch main has been updated by imp:
>
> URL: https://cgit.FreeBSD.org/src/commit/?id=3D20e94950c54e398049396647da36b9= e2c3b639c1
>
> commit 20e94950c54e398049396647da36b9e2c3b639c1
> Author:=C2=A0 =C2=A0 =C2=A0Wanpeng Qian <wanpengqian@gmail.com>
> AuthorDate: 2025-11-18 15:24:23 +0000
> Commit:=C2=A0 =C2=A0 =C2=A0Warner Losh <imp@FreeBSD.org>
> CommitDate: 2025-11-18 20:32:22 +0000
>
>=C2=A0 =C2=A0 nvme: Notify namespace changes better
>
>=C2=A0 =C2=A0 When we get a namespace notification, we have to reconstr= ut the
>=C2=A0 =C2=A0 namespace to get the new identification data from the nam= espace. For
>=C2=A0 =C2=A0 each namespace in the AEN, we will reconstrict it before = we call the
>=C2=A0 =C2=A0 notification. We also flag it as changed for the duration= of the change
>=C2=A0 =C2=A0 callback (prior versions of the patch needed to keep trac= k, but we no
>=C2=A0 =C2=A0 longer do, so this bit may be removed). Note when we'= ve seen the
>=C2=A0 =C2=A0 namespace so we can notify when it goes away.
>
>=C2=A0 =C2=A0 Co-authored-by: imp
>=C2=A0 =C2=A0 Differential Revision: https://review= s.freebsd.org/D33032
> ---
> sys/dev/nvme/nvme.h=C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 7 +++++--
> sys/dev/nvme/nvme_ctrlr.c | 12 +++++++++++-
> sys/dev/nvme/nvme_ns.c=C2=A0 =C2=A0 |=C2=A0 9 ++++++---
> 3 files changed, 22 insertions(+), 6 deletions(-)

Just replying to one of the multiple commits:

It seems from somewhere a VIMAGE enabled kernel is pulling
in systm.h for memmove; LINT-NOVIMAGE fails without the below:

% git diff
diff --git sys/dev/nvme/nvme.h sys/dev/nvme/nvme.h
index 8f7a7fbda14c..e17c2bf41a5a 100644
--- sys/dev/nvme/nvme.h
+++ sys/dev/nvme/nvme.h
@@ -31,6 +31,7 @@

=C2=A0 #ifdef _KERNEL
=C2=A0 #include <sys/types.h>
+#include <sys/systm.h>
=C2=A0 #endif

=C2=A0 #include <sys/param.h>

I'll take a look, but i didn=E2=80= =99t think i added a memmove.

Warner=C2=A0
--
Bjoern A. Zeeb=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0r15:7
--000000000000064edb0643f7faf5--