From nobody Mon Nov 17 17:54:26 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4d9FkL21MJz6GfmD for ; Mon, 17 Nov 2025 17:54:34 +0000 (UTC) (envelope-from garga.bsd@gmail.com) Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4d9FkK0xGxz3m05 for ; Mon, 17 Nov 2025 17:54:33 +0000 (UTC) (envelope-from garga.bsd@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20230601 header.b=QZ52P8a+; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=freebsd.org (policy=none); spf=pass (mx1.freebsd.org: domain of garga.bsd@gmail.com designates 2607:f8b0:4864:20::62e as permitted sender) smtp.mailfrom=garga.bsd@gmail.com Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-29844c68068so45257865ad.2 for ; Mon, 17 Nov 2025 09:54:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763402070; x=1764006870; darn=freebsd.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=9HFZChMIOzU/Q7Tfyf1fFoaqxMFcsEJ6LxQ5LailWhA=; b=QZ52P8a+C5fzPKKFcQBDDCEhotGSjorcf4x4MnLdxJAK/ZO6xnVzdr6imOk6+TW/eo Nc7SDakyYyNlq8/HcUErM66u5QYYXKzdpxhTz5lV0E3YdSX1Ncbtkwc15mUThdDrWWY6 fsIQ18JtqwTTxVCBlDYdI4zt/hOiQ4t0BIEDThZWI9NWcwAwRzdrL116EQb6zDhidDS/ AtanNe7W4uu3RY28xk2I/l/jCHgZbIxXW1WrqxYj5V/xvNhj4CNgfriKIMdD2EODN2o9 QYdEiZYZMuzrZcwuJlx1QdYo1+lW8ZB6kcN9gS+8fpBc6++Lcx0UX686ViNI8iZGCQuU c2Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763402070; x=1764006870; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9HFZChMIOzU/Q7Tfyf1fFoaqxMFcsEJ6LxQ5LailWhA=; b=wM7MFXA+y3YJ+CJ7oCCAwoj+5PSQEHZ3aqzDUivOhnUag8cClewyy0bjj3Opg8mXM0 /fqV7UFvkGzC9jJwDgg6aXBfMFJhIgkwFSHqdP5JPGK8Hp3Pw775Stcag7lbVpFdipyn Bm3O72NeqnuGX3NPe/BPSMR3AJ66VoB1SWfl8dCwNuG14JhRMsqvpaMc/Rt7+ZEBiMl9 B4TLpMLsbw8LBrIjAPwTPSUwvxR8MhAeJiw+wgH5eyCgInK3OiVpP/Pf0MYcnWKl4Qp8 aQtQmJ+FbPh86Xl6Qg1yqUqXLzQfzpn+6wYTvRi3QJxI/i/bvGSEQvh4KTyCYLc+qNMD Sqvw== X-Forwarded-Encrypted: i=1; AJvYcCXeZju8kzRME8g7pp5WUBXRmHJZZ8IVyqDFzEeW2ajeAgrlKGgnUS9IXng/CJAnbLE9q2/MScVREwL9JR3t1zCAseRcNQ==@freebsd.org X-Gm-Message-State: AOJu0YwP5k8ew1dYnDnqQjYLgsvErzep5Wxh4Aq6jCyugH4Uxmj0ht0V h0J6p8ck6LfchPT2nFfaoUJZJETcM9f9+O1QzqwOBp8lb2pPrPJNxpwp X-Gm-Gg: ASbGncuqkkRdd/VgPC1lUAtslzXnecwOKqPFNZ/oCa49P260YJ/AeXZutYeI1NaT7WE anwSAwDMu4Kthq0iadYPTtQJuG77XMFQgqgO4jbcdbzYyH+QukZFErlatchLbaIe7MhbH9BGNA7 3z5Z3Ks1/ze/SL2rSsxsZ7tyRNNOsL6LT2rKHxoizQvInMT4wzMCa2t5NPqaiHPSJi6nuq9voHX yPvmuM7JTMkCBVU0bGdAoTLCdOpE4gsYraPoFbJiZOK6m3LUUkyk90uOMqNdVvER6caL6KFh3gA i+OSxLKqpUsORIklUmT7Yio2tC/41CB0SoUYLLxALc0siahh33MpZIOEnP2yqiYfWQu2inAzZQa 4Yx+WEDznkpRXyOO+fu5T5vdpizA7uQX+8W93QW0UCraEaCPpnnt8BzUMFeuKekYv4xV8bpqcnq TZ2oTqsX8Ha+nO3KFQOpwIKvRqcMia7FuMcsmtBYC96KRSma4xtMy2Lq6zfPEcHY+cZVFSLw== X-Google-Smtp-Source: AGHT+IFZUt8OggRfaswBG2KfiRm+y1E+IJ3YzgAC+PRhYJ9RHRmcHQZ1CkeUTUwdmO1cAicFkJjlfw== X-Received: by 2002:a17:902:da4f:b0:295:6d30:e26f with SMTP id d9443c01a7336-2986a6ec220mr169349995ad.22.1763402070067; Mon, 17 Nov 2025 09:54:30 -0800 (PST) Received: from ?IPV6:2804:f1c:34:1001:8922:7658:64c:f767? ([2804:f1c:34:1001:8922:7658:64c:f767]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29864b00fc9sm121551085ad.40.2025.11.17.09.54.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Nov 2025 09:54:29 -0800 (PST) Message-ID: Date: Mon, 17 Nov 2025 14:54:26 -0300 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: f1b9c1aafd84 - main - random: git'o in RANDOM_ENABLE_TPM To: Gleb Smirnoff Cc: "David E. O'Brien" , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202511110246.5AB2kdQc077401__35176.4420907543$1762829211$gmane$org@gitrepo.freebsd.org> Content-Language: en-US From: Renato Botelho Autocrypt: addr=garga@FreeBSD.org; keydata= xsBNBGStavwBCACjNlp/9+Y+VFe9ieR2h/WWbdvjz4Mb2z/f22bGoaskzCfvVNbo/v3i34I9 H6OdgZkGqheQEAD2jNfRbmPr4z40xDMUpYGLds+1Mvg7G3Hms3j5Ef8KaLSWUNWIfwKdfSVR Qs35ccSJxAdRW5YdI6J3xZgika+3Bc4eJ05YE/nWW+PNTYevt5rqD50N3zybVYIcLoqVPpBi AZE/sf5SLiLACIJb1t/s4x+pi8vgWevxVVT9u8V1f8zYErmHSLSqjxii0B3eRZphX9NCJOv9 +tfFZhnENInhn9gT7H4e2YumUltEy3jacONHJF3CC1pvvWEa6lEyypclMOkHQwNON7DLABEB AAHNLFJlbmF0byBCb3RlbGhvIChGcmVlQlNEKSA8Z2FyZ2FARnJlZUJTRC5vcmc+wsCXBBMB CgBBAhsDBQkFo5qABQsJCAcDBRUKCQgLBRYDAgEAAh4FAheAFiEERL7Dxegbnh7xTiQ5Ob6P xxJcZXoFAmSta78CGQEACgkQOb6PxxJcZXrYlggAgaZmr6c1yIWzN8VksHrHpwt/uxONEP+h ljy3yfrMsgfS5wx5Uzgfih1xYZUFC6jiI63CetqBqJpp3g1klRS1UWYKx2NeXphDMYZEdPm/ a6sXh4bKZbk6IE8Yn0/YiRT57d9DtbvswC7Gn7Igj/MSbhl49TvTGyvuB6juaffVoYZViomx 5zMoee8Ml2o2qj3MrCJ+/K8GU54RlpOGqGRsqdwVdr9XEWub6fF2YFwR46cjmbiU3P5urFHH nkJlBGPIwKxHimTW0lZsdx9aCKRDd/D80/WOEzXmk3k8B9lv/GsvOluHmveLhJG1R1tIJ31I f2q8dfTvqsQXnu8CcWRcgc7ATQRkrWr8AQgA1DufoxScA+CWQbUR6zExIu8wXQKrhuRt4DG2 BgynT7EMUvEBadcbQRZXsBpemNfncc9Axyut/+rWiyKJf9BLQuo/9QYmSRvW1U6+0LJUYmdg kMyBeYaPk+vnssv/u9jLuvV7FVgyE0yk1iaWIKOVDD+XrQCOvGw9uSceBrQyCyo3A/eRM/+p vnDCaywR63PKE+3axk6lfNdGK3TnaWmS30/ZDCZlNsXuqprqR4JdT5wXids5o36dsuJ5EZ20 s5hNMD34s4Yr1Y1R9elH6qBsFCpozs0+jwrArxq+UJJCR6hH5W8ZEwJtRC8tzR8mRE1WywzX BXYj0YhfGztQIxZckQARAQABwsB8BBgBCgAmFiEERL7Dxegbnh7xTiQ5Ob6PxxJcZXoFAmSt avwCGwwFCQWjmoAACgkQOb6PxxJcZXr1vgf/SKXhoZcUU5I7TqcbHg0lJz9tICTupCGHWr/s SQgjh9oEM5j1wqW7FlCGP90Tl9K0g3ow9YdbhU7VK470o6pymX9V9eLHzGgkZO/KMEtGBeK1 u+5ePjCJ/MK5B21KODLSU7WrIL1VN5ceXfQPLYt02LMLtPri+oduHD6RNBeA7US1DUzleq5F 9NHGbvV2U7BdDUezpiO8NaFjFZVB11I5d99FxUM5XGVstI3VhsRKZxjY0KnqJzaQgTFsPGmv AUfZVIN1pXgXiedhPXpr8+Y64jP+pHVwpVmh1zYWL6+q3kqFOUVP6c5iiMeoEXZvgJz7x/AC ek3X5gvu8Hpcv+MZIg== In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Bar: --- X-Spamd-Result: default: False [-3.01 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.91)[-0.907]; FORGED_SENDER(0.30)[garga@FreeBSD.org,gargabsd@gmail.com]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20230601]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; MIME_GOOD(-0.10)[text/plain]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), DKIM not aligned (relaxed),none]; TAGGED_FROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::62e:from]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; TO_DN_SOME(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_NEQ_ENVFROM(0.00)[garga@FreeBSD.org,gargabsd@gmail.com]; FROM_HAS_DN(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-main@freebsd.org]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_FIVE(0.00)[5] X-Rspamd-Queue-Id: 4d9FkK0xGxz3m05 On 14/11/25 18:41, Gleb Smirnoff wrote: > On Fri, Nov 14, 2025 at 06:03:15PM -0300, Renato Botelho wrote: > R> After upgrading my laptop this morning I noticed it was freezing after > R> suspend/resume. I've bisected and ended up on this commit. > R> > R> I confirmed reverting d6f10a5d013f (only to prevent conflicts) followed by > R> f1b9c1aafd84 and 3deb21f1afd5 have fixed the issue. > R> > R> My system is running today's CURRENT at 82d8a5029a80. > > Looks like the commit you point at can't be a culprit. Looking closer to your > description "reverting d6f10a5d013f followed by f1b9c1aafd84 and 3deb21f1afd5" > it seems that the only functional change is addition of device tpm and > rdrand_rng and option RANDOM_ENABLE_TPM to the GENERIC. > > Can you please try unmodified main sources at 82d8a5029a80, but modify GENERIC > to remove these two lines: > > +# random(4) > +device rdrand_rng # Intel Bull Mountain RNG > +device tpm # Trusted Platform Module > +options RANDOM_ENABLE_TPM # enable entropy from TPM 2.0 > > If that helps, can you please find which particular line makes the > regression. Hello Gleb! I was far from keyboard during the weekend but I tested it today and RANDOM_ENABLE_TPM is the option that trigger the issue. I've commented out RANDOM_ENABLE_{TPM,KBD,MOUSE} on unpatched src at 82d8a5029a80 and suspend/resume worked as expected. Uncommenting RANDOM_ENABLE_TPM made it to stop working again. -- Renato Botelho