From nobody Sat Nov 15 21:33:16 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4d86gh343vz6H1Kk; Sat, 15 Nov 2025 21:33:20 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4d86gh2LqZz3x8s; Sat, 15 Nov 2025 21:33:20 +0000 (UTC) (envelope-from bz@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1763242400; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=V+VmkTzZdhgm125Ez73D0jen+kRYLV34H28ZpoC0rM0=; b=DqNTP1YvFIffgcszGYeRpyX4CXwKAm+Mkj+sTq5gK5vz7fjEHEbyq0s6EJXckKax0o12yc stdZeV45IFilY+JAcWuOoptdMWmVkKkHvNwAl9ML/j8sgtSTSCIqSAQCZnEs6opLBYOUW6 tVSBQ+71CWu/ZiX/UDzVBtCn2mzSW1/jGSj+PRkqvuOQNxSM7REw8MrtkpJMeaS6loDcmQ ilpm9Z5+fE4Sr5rcGqmJJh+XH+FMk5e4WftbdE2dOqT4iKt3oZTwW8IHSnTb+wQfznMAv1 n4N0BudEOTkgx9Dm896ZHyvCEIiqP7gFG/4/GNIvpNVo+R5CQeuxNQInzSNrOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1763242400; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=V+VmkTzZdhgm125Ez73D0jen+kRYLV34H28ZpoC0rM0=; b=hJMEfwg+3AfjgVDtkl6HVvMuhY835yrcDQhPDI4OZ0C5WT49BcDSRbPOcJkaItXx06zxqq kOhsXqlxNea3Lp7GpXUIKDVMvycKkAFm181gv2rF2AJSHHHtVoRe+RgkV7RS3PRLv/t8wB YDTSMrB+WthobSLU3noK5y4ihb/XJY0tCLzexjuGwoy/AEFCMqDlKUPxTAkBVQ0LxNksBN DBg68/HYz8FMK/KW4H6X6oOHYVyLPSHGcqhPBfSphYKkdTyX8LOfoQ3k11ulXgCtiGUtqd xc7ACUa+rezzGBnALExj5whqf16osDJKkZb7xL0XNQMkDdT+kNukQRLn8kPV1w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1763242400; a=rsa-sha256; cv=none; b=NQ5izqotLMfFPj7FgQgv3ZFZChi5b6ehol1klI4x788PdXHkBd8eCIUGTFY56+6ombd6CV jsy58VmoW5WCnYrqVuld9elXSTuxUkIpSvrPE12ldBHVuk39xSWaaOjBd5tSySlXorjWou WZRh4WbctzGxTp1/BpRjNtuaj+ATFtyxdqls+J4a10IejnRAjliW97Y0IPt8BMc3x+0VGD jJvZHasQN0D60lOxYnvCxz2g66DZYo+rIR0Y2pPsA9nq+WAvpzroKvQscEbwGjJIJtnAXF z8dUsnYnL7lsN58zEBMDtHZlN44roRGpDjIlM9nEv3vT9p8tq5oMkiVJ3p6Gxw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from mx-01.divo.sbone.de (mx-01.divo.sbone.de [IPv6:2003:a:140a:2200:6:594:fffe:19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature ECDSA (prime256v1) client-digest SHA256) (Client CN "mx-01.divo.sbone.de", Issuer "E8" (verified OK)) (Authenticated sender: bz/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4d86gh0mYjzD0m; Sat, 15 Nov 2025 21:33:20 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by mx-01.divo.sbone.de (Postfix) with ESMTPS id 187A7A64805; Sat, 15 Nov 2025 21:33:06 +0000 (UTC) Received: from content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id 6CD242D029E6; Sat, 15 Nov 2025 21:33:18 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) by content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (amavisd-new, port 10024) with ESMTP id pSi3KF_-LgYH; Sat, 15 Nov 2025 21:33:17 +0000 (UTC) Received: from nv.t4-02.sbone.de (nv.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:22]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id 2CC392D029D8; Sat, 15 Nov 2025 21:33:17 +0000 (UTC) Date: Sat, 15 Nov 2025 21:33:16 +0000 (UTC) From: "Bjoern A. Zeeb" To: =?UTF-8?Q?Dag-Erling_Sm=C3=B8rgrav?= cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: a615ded5bf2d - main - sys/conf/files: Add iwx driver In-Reply-To: <86346fuhny.fsf@ltc.des.dev> Message-ID: <462npnsp-7o16-q664-65pn-q6o76rrp375q@SerrOFQ.bet> References: <202511150319.5AF3JZxn087193@gitrepo.freebsd.org> <975p35no-15n8-q8o8-r154-r3517o4o6oqs@mnoonqbm.arg> <86346fuhny.fsf@ltc.des.dev> X-OpenPGP-Key-Id: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="0-575627910-1763242397=:11296" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --0-575627910-1763242397=:11296 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8BIT On Sat, 15 Nov 2025, Dag-Erling Smørgrav wrote: > "Bjoern A. Zeeb" writes: >> Dag-Erling Smørgrav writes: >>> +dev/iwx/if_iwx.c optional iwx \ >>> + compile-with "${NORMAL_C} -DIWX_DEBUG=1" >>> +dev/iwx/if_iwx_debug.c optional iwx \ >>> + compile-with "${NORMAL_C} -DIWX_DEBUG=1" >> Why would we add the debug flag in a default kernel compile? > > Because the driver doesn't build without it. Feel free to fix that, but > don't forget to turn debugging off in the module build as well. Took me 3 minutes to make it build without IWX_DEBUG: https://reviews.freebsd.org/D53776 No I did not add the kernel option yet... whoever needs it can but could likely equally just add a #define IWX_DEBUG to the source file. /bz -- Bjoern A. Zeeb r15:7 --0-575627910-1763242397=:11296--