From nobody Sat Nov 15 21:00:10 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4d85xX0gRKz6Gy08; Sat, 15 Nov 2025 21:00:16 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4d85xW6Qz3z3s26; Sat, 15 Nov 2025 21:00:15 +0000 (UTC) (envelope-from bz@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1763240415; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dntIzyU0sul0slfh7RvNMkWLXtBO10XTGB62DH1y2yI=; b=fU/CB8TtMlJBftG0ix8Vh+INsStxKceovIcxjn/QS769XpLFR1CwchIBFbaOK4SVxHN5GI TTJBZkyBjj6+Bxms9XtZnE8ttdpMDYxn0ovKMoPLp0GRNzV83rCkQbXN0+k+BaQaqQH9LR T+Yodx5oiLCepfoS1BzeorjuK59uJ/m91Skfa9+aJlNGMPWud0AVzORHNHasBJigsE3N/6 1a3lr5bL1sxX2sPurEM/kLCwpzdTPdrB6VXbwxPE40ORwLBfsACwoQQ8wMM4oqMpiNy4wt 7rtwzKKhvna4AO90ItzusEfGDgvdgFcUSNGZFxmusvEYzcWFyyPPQYRi14qhOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1763240415; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dntIzyU0sul0slfh7RvNMkWLXtBO10XTGB62DH1y2yI=; b=nbrKv9XIajrmmDQNsJh2ad8CE5PYKp3P/S63npAwkeO9Xha1ZWB9nScf+zrRjx3nI/vWvr FD5wQoxT6VX7BnmsrY0oaWylhKrr5Xk4PK0xXtfhMQWaGNAGNFP68Va4OexkyHOibD4qQl i8Sj+6bCN0dgQwlK1qRHZXLHg1f5MISpS6prD4E75RfVTqQzIGHghbIpWN7n4uEqnqvvLX j/eX2H19qpK3EoykmQYgD+haXnDmC0uDKeU7h+Kcr5kt1G4QheqtmmEfcMSRy6uBJQplCq r+EfpDiogJJGVtnRn7Eq4CYPni8JEeabj6CYHLTy8l6VKNBj/GKx5U0Ff3dsKg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1763240415; a=rsa-sha256; cv=none; b=DQrvW0zBum/UCMEke/qo3NUljxIgNLMJuvZEWfywNl3LaW6JrZy8o1egSDMck1tOBgSxty qJYVU39IRF5/sFwE6H3BnfQsSeCj/qDB3fH5FbJqnBM9zDvKxImDDviEBKhtD3hd/6odjN E+uR+n5veZ2QwP/6zMLinaHHQIrKSyC9X585LlvXK7avJuK2+f3+VwxfpV2OrlHV2WVQk1 5vxAarPles56RsZCnK1yCbp0aWwVP45sqdHnYurJWlWqbzDc0DSHAKE1bq6PkAa43uHmyp U2CcGLe0V3BWhe0rTGwX1HcAyWIzm5q1FXfHskyaP6lW5OxtfpyhqcA2WdWvaQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from mx-01.divo.sbone.de (mx-01.divo.sbone.de [IPv6:2003:a:140a:2200:6:594:fffe:19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature ECDSA (prime256v1) client-digest SHA256) (Client CN "mx-01.divo.sbone.de", Issuer "E8" (verified OK)) (Authenticated sender: bz/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4d85xW4spPzC6r; Sat, 15 Nov 2025 21:00:15 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by mx-01.divo.sbone.de (Postfix) with ESMTPS id AF204A64805; Sat, 15 Nov 2025 20:59:59 +0000 (UTC) Received: from content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id ED0462D029E6; Sat, 15 Nov 2025 21:00:11 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) by content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (amavisd-new, port 10024) with ESMTP id 0Wh7W_HBSJ2x; Sat, 15 Nov 2025 21:00:10 +0000 (UTC) Received: from nv.t4-02.sbone.de (nv.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:22]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id B1E1D2D029D8; Sat, 15 Nov 2025 21:00:10 +0000 (UTC) Date: Sat, 15 Nov 2025 21:00:10 +0000 (UTC) From: "Bjoern A. Zeeb" To: =?UTF-8?Q?Dag-Erling_Sm=C3=B8rgrav?= cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: a615ded5bf2d - main - sys/conf/files: Add iwx driver In-Reply-To: <202511150319.5AF3JZxn087193@gitrepo.freebsd.org> Message-ID: <975p35no-15n8-q8o8-r154-r3517o4o6oqs@mnoonqbm.arg> References: <202511150319.5AF3JZxn087193@gitrepo.freebsd.org> X-OpenPGP-Key-Id: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="0-270227745-1763240410=:11296" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --0-270227745-1763240410=:11296 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8BIT On Sat, 15 Nov 2025, Dag-Erling Smørgrav wrote: > The branch main has been updated by des: > > URL: https://cgit.FreeBSD.org/src/commit/?id=a615ded5bf2dd7f563eed6766d32fc063ae36f92 > > commit a615ded5bf2dd7f563eed6766d32fc063ae36f92 > Author: Dag-Erling Smørgrav > AuthorDate: 2025-11-15 03:18:45 +0000 > Commit: Dag-Erling Smørgrav > CommitDate: 2025-11-15 03:18:45 +0000 > > sys/conf/files: Add iwx driver > > PR: 290812 > Fixes: 2ad0f7e91582 ("Import iwx as ported from OpenBSD by Future Crew.") > Reviewed by: emaste > Differential Revision: https://reviews.freebsd.org/D53758 > --- > sys/conf/files | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/sys/conf/files b/sys/conf/files > index 87c8830b192e..53fcb80f2b8d 100644 > --- a/sys/conf/files > +++ b/sys/conf/files > @@ -2278,6 +2278,10 @@ iwn6050.fw optional iwn6050fw | iwnfw \ > compile-with "${NORMAL_FW}" \ > no-obj no-implicit-rule \ > clean "iwn6050.fw" > +dev/iwx/if_iwx.c optional iwx \ > + compile-with "${NORMAL_C} -DIWX_DEBUG=1" > +dev/iwx/if_iwx_debug.c optional iwx \ > + compile-with "${NORMAL_C} -DIWX_DEBUG=1" > dev/ixgbe/if_ix.c optional ix inet \ > compile-with "${NORMAL_C} -I$S/dev/ixgbe -DSMP" > dev/ixgbe/if_ixv.c optional ixv inet \ Why would we add the debug flag in a default kernel compile? Should that the not be enabled in the driver code based on DBEUG or IEEE80211_DEBUG or like for other drivers be an option? For exmaple, we do have RTWN_DEBUG, ATH_DEBUG*, BWI_DEBUG*, BWN_DEBUG, MALO_DEBUG, MWL_DEBUG, IWM_DEBUG, IWN_DEBUG, WPI_DEBUG for various wireless drivers. I don't see what iwx should be special? -- Bjoern A. Zeeb r15:7 --0-270227745-1763240410=:11296--