From nobody Fri Nov 14 08:44:06 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4d79fZ41Q9z6HF1Y; Fri, 14 Nov 2025 08:44:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4d79fZ2FtJz3kJr; Fri, 14 Nov 2025 08:44:06 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1763109846; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=N+V9RCHXcfbyvsynrZHuks1kl8lQYwKw3NdDdKuuwsE=; b=jWPYGH4XCdq6TImIJEKnNFcF+7Ts94xDb3LsccvTnypMpI3nF0MtgZUoqqgS9xt56cAs8S 8Q50fxAIR1FpGBhnJm+C1gSnjiMaN0aNFaaib0I6yzK/VVl+knp83kw25D+2gGI24UpnqG ScVdrvQ5Nwf0Snv/M2bYa4bMyYLM6Xx2UQQoaT7Z7nyaNaAcxp1XQd9/5BVen97HzbEwZ7 ZpfWy0mnGMEe5wcQ0WPEEKJIcSTksoFcR5ZBnofWeh/lnFp+cUckPRK+Uq2sWHEF5mP2r+ 2k5fIMBR6Y1kAElv5HIEk9dz6DXXIsKlvOABOC1kI+0GWYA+TE4NoGgYbjlorQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1763109846; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=N+V9RCHXcfbyvsynrZHuks1kl8lQYwKw3NdDdKuuwsE=; b=Eijviege/ZtXQZ6OHOfZqyWk/rhin8U2wO1uxEnWL938Oq5lC8Z8q+tnq1F3do3DRz0kCZ IEIq+L3eW8HlKGpiw9PF5nginGPHEpqs9vO+Sa7uyzgu4vErsfMdYvFPWf2R+USTYDOQ+0 4dIBR36kilBCGuaGfO8uuCBnRMBFUkCWCcUWIZM6/K523zyNAw3P88Um08E3m9QPrY29In +tERzZ8MiOKSrgs7SwMPdMAulKZ4MX2E52BI2UNAJRs5rs0BWGI0kDREta/RPep5LzCz9/ 3gWoTfnq5qnltXZl9U0xbB+16orZm3fQvd8jJFKnF5kZtfPB9pizEX/duXuoHw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1763109846; a=rsa-sha256; cv=none; b=fM224mIsyw0K0QAw/IyVOl+XYhf8FmZnDTzVczqUOJs6Xmllp/427dnpWWvYpztz+Hc+Ag +Xo9T0GGY7q6PvR8E4sFx1SpAFERU/iw6u1Tkr7MJ83kWUHh4ua8Rr50tN/Z1WzijeQN+Z fmvcWZwdzohlffIlYRkut9XA8gUX7W2BqGjb/mbOk+RyYvwLw4bfdEqiW1pISAfY+oQ665 +gQPetPWB72uk3jhfaYFWfcQqzalLkszSJuTyye4On+R+UOxwCtL47cG+2mpcQbeCBuhDr zE6R9HRprdA3H1IRpo/ppcXUQGP/61lVI7ThXio0PFqc2aRNISpQXV8Lpf0Asg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4d79fZ1sSvz10by; Fri, 14 Nov 2025 08:44:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 5AE8i6Rn098044; Fri, 14 Nov 2025 08:44:06 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 5AE8i6iC098040; Fri, 14 Nov 2025 08:44:06 GMT (envelope-from git) Date: Fri, 14 Nov 2025 08:44:06 GMT Message-Id: <202511140844.5AE8i6iC098040@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Navdeep Parhar Subject: git: b0cfa27c91c4 - main - cxgbe(4): Avoid racy access to requested_fec in sysctl_requested_fec List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: np X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: b0cfa27c91c400dcf3e8441cc04f9e5300c7c3af Auto-Submitted: auto-generated The branch main has been updated by np: URL: https://cgit.FreeBSD.org/src/commit/?id=b0cfa27c91c400dcf3e8441cc04f9e5300c7c3af commit b0cfa27c91c400dcf3e8441cc04f9e5300c7c3af Author: Navdeep Parhar AuthorDate: 2025-11-14 07:45:59 +0000 Commit: Navdeep Parhar CommitDate: 2025-11-14 07:45:59 +0000 cxgbe(4): Avoid racy access to requested_fec in sysctl_requested_fec PR: 289121 Reported by: Qiu-ji Chen MFC after: 1 week Sponsored by: Chelsio Communications Differential Revision: https://reviews.freebsd.org/D52199 --- sys/dev/cxgbe/t4_main.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/sys/dev/cxgbe/t4_main.c b/sys/dev/cxgbe/t4_main.c index 4ce8d71ed86f..9bd5e02fabf0 100644 --- a/sys/dev/cxgbe/t4_main.c +++ b/sys/dev/cxgbe/t4_main.c @@ -9007,7 +9007,7 @@ sysctl_requested_fec(SYSCTL_HANDLER_ARGS) struct adapter *sc = pi->adapter; struct link_config *lc = &pi->link_cfg; int rc; - int8_t old; + int8_t old = lc->requested_fec; if (req->newptr == NULL) { struct sbuf *sb; @@ -9016,16 +9016,15 @@ sysctl_requested_fec(SYSCTL_HANDLER_ARGS) if (sb == NULL) return (ENOMEM); - sbuf_printf(sb, "%b", lc->requested_fec, t4_fec_bits); + sbuf_printf(sb, "%b", old, t4_fec_bits); rc = sbuf_finish(sb); sbuf_delete(sb); } else { char s[8]; int n; - snprintf(s, sizeof(s), "%d", - lc->requested_fec == FEC_AUTO ? -1 : - lc->requested_fec & (M_FW_PORT_CAP32_FEC | FEC_MODULE)); + snprintf(s, sizeof(s), "%d", old == FEC_AUTO ? -1 : + old & (M_FW_PORT_CAP32_FEC | FEC_MODULE)); rc = sysctl_handle_string(oidp, s, sizeof(s), req); if (rc != 0) @@ -9042,7 +9041,10 @@ sysctl_requested_fec(SYSCTL_HANDLER_ARGS) if (rc) return (rc); PORT_LOCK(pi); - old = lc->requested_fec; + if (lc->requested_fec != old) { + rc = EBUSY; + goto done; + } if (n == FEC_AUTO) lc->requested_fec = FEC_AUTO; else if (n == 0 || n == FEC_NONE)