From nobody Thu Nov 13 14:36:04 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4d6jW85Nl9z6GxSR; Thu, 13 Nov 2025 14:36:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4d6jW84vM2z3MLT; Thu, 13 Nov 2025 14:36:04 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1763044564; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/fxRqM4hWhZd8EYBvYEeavGf9swDW9mlrj2kvwoBu+A=; b=VEumqjUX077rO7sFPksrMdYkjMRa+lmCNu2P73JS2Vv+uwwS+1bj5x5ZkBAR/rNljxNwEa jWrGFkoJffXW3DWbpfy/qWA9f5wXVSUQ0i+GLABuATw2Q9eMFBZOELG3f/7K0mOCwtH299 KV4xpmdFl0uf7CAwmiYzK5DIrPRi+L3xzNjy00yxm80rw4hX90RBmpM2SaFAKsS7ePeYQr g9esxaNmimajEUpAFr/WWgJ5tcHHIEaHf2mW4ViqDbp+ZlXXKliQPy4LgtHxXWIVkGiCXS pW0NA+cPt+VeQqnxiF8jeDKkDhWGEl+UvIbnwXCQO1Se2eM67NjlGD3MTvrNfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1763044564; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/fxRqM4hWhZd8EYBvYEeavGf9swDW9mlrj2kvwoBu+A=; b=jdN96VLI1ypIlwwfqeLIdIZ6jNJky2beBAop+yxJGjYcjPDVE4Z25GK3Mzt8VHOXEcEw/d rC7A/qTKcPjTAkIbeqApHH4w7E4yzvmvyhbD4qVhD/144u1r9HPNWAU7q0z1R2eDV+Zzjf MgpiRF2Tt/LQajCYI3qKKvsRQiBk99T7WlwAmPZvXEbORhHV+oq6KGoxn93hv97hp9dZWt gAEXA6xIWU6M8kgnb4uPYTx9J03Bj0zleYN3sbLdhL5JzBflHfqAwuRiyNEey8Z+oppobn vTzNBgdrJydDZNCV5LxX1WwYtdX01Fy9Sch4PnNAyd2tcqNmrBggXG9ki43SMg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1763044564; a=rsa-sha256; cv=none; b=dQwQ4i05geSja5z2arEbN4c3N6mavQ05hxOjYZsFsl2yOpH1IfwXcsbTPhgLJ2Nqt4lWO8 dlpaGXu4QFhUiRfdFwKw6v6uzzhqbPPUawhggrhAon5nqqZ8S+smmFHy94lh39+0nsAqHN NXy60OJvRPwnsM5MLsQxHI2hjHHJ5XXCnvu6y37fBjT9Jtne9TAMUmNpOxwmBaTyUex1+W pW3hbVamTa2Vlqfp4CxgI96UxFU3Xyz9Qddmhb+aXha8THJx0lj41v7oUGybfjFAtdNDiG YO7Y5pMJTCrpTQaF8i4h5wtXm5HjlVrdqLyXRQVfj2grMDzJz8ATuCzHjNph7A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4d6jW84VfTz8YT; Thu, 13 Nov 2025 14:36:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 5ADEa463045691; Thu, 13 Nov 2025 14:36:04 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 5ADEa4V8045688; Thu, 13 Nov 2025 14:36:04 GMT (envelope-from git) Date: Thu, 13 Nov 2025 14:36:04 GMT Message-Id: <202511131436.5ADEa4V8045688@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Christos Margiolis Subject: git: 6b5431941c10 - main - sound: Remove unnecessary uio checks in dsp_io_ops() List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 6b5431941c10b6fdf164ad9d3dfa4b4f1b2edc22 Auto-Submitted: auto-generated The branch main has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=6b5431941c10b6fdf164ad9d3dfa4b4f1b2edc22 commit 6b5431941c10b6fdf164ad9d3dfa4b4f1b2edc22 Author: Christos Margiolis AuthorDate: 2025-11-13 14:35:48 +0000 Commit: Christos Margiolis CommitDate: 2025-11-13 14:35:48 +0000 sound: Remove unnecessary uio checks in dsp_io_ops() uiomove_faultflag() takes care of that already. Sponsored by: The FreeBSD Foundation MFC after: 1 week Reviewed by: kib Differential Revision: https://reviews.freebsd.org/D53733 --- sys/dev/sound/pcm/dsp.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/sys/dev/sound/pcm/dsp.c b/sys/dev/sound/pcm/dsp.c index 429586e64aef..f7188fd16356 100644 --- a/sys/dev/sound/pcm/dsp.c +++ b/sys/dev/sound/pcm/dsp.c @@ -467,10 +467,6 @@ dsp_io_ops(struct dsp_cdevpriv *priv, struct uio *buf) int prio, ret; pid_t runpid; - KASSERT(buf != NULL && - (buf->uio_rw == UIO_READ || buf->uio_rw == UIO_WRITE), - ("%s(): io train wreck!", __func__)); - d = priv->sc; if (!DSP_REGISTERED(d)) return (EBADF); @@ -488,9 +484,6 @@ dsp_io_ops(struct dsp_cdevpriv *priv, struct uio *buf) ch = &priv->wrch; chn_io = chn_write; break; - default: - panic("invalid/corrupted uio direction: %d", buf->uio_rw); - break; } runpid = buf->uio_td->td_proc->p_pid;