From nobody Tue Nov 11 12:08:18 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4d5QKb2X7Zz6GLSf; Tue, 11 Nov 2025 12:08:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4d5QKb0Ntzz3c03; Tue, 11 Nov 2025 12:08:19 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1762862899; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=sAmdw6dbk7XnZWEmjVNZ6PyiCvIOg5L8H1+p3PVkSf8=; b=ZljacWl8R5sCPXKqY8GBCkaYFsTrxWHf/4Xup/Nl+w/uYMJYA7ivIzuodB80nIAfPRygHH DGkY5D8uPuP+GqbjXG79xNr/lBU0052SkbW9jZFLUDQTMDUbAMubp8XgMIcsdrlxEEqnXl ECqvl8gLUnTtlIh8Gs4cwYxPULIyh+gwUTeR/fqQmGZK3LEphPTiZ+RU0PYk6lFGqGapFw YBoONEbvkac3m6VPy215wRfc+a96WXqzQ3mPdpMpCwPUp1J7rvSqoAr37i6IIxXwD1StXK pteZYIhmoPZwCMayfbVGsquj/MQkL2buN40fXI4OhTExJZtcreDkb+j/85mu1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1762862899; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=sAmdw6dbk7XnZWEmjVNZ6PyiCvIOg5L8H1+p3PVkSf8=; b=gMXOKPp4LN0qIOYdd9C7YgqflpGeqVIj2kdTpCOFil3nprl3nNp7/oVPDIM0eanw7ZJJAt Tu9pwMkzo0VPeDIdYwvWVw/hRex8POwSq4Dfh2S9Z7OXkOzK/LY9tuoGzNJnyW54llIVVT JEuhZj19AeyRrU4QFLn6QuqQqLLswVUIZLpyQryfe+P/YP7ElT+IvJXhAli5g4m7zklBES vRVXSOrcZwhRLSvgF2yTTR1AkDrqtvKff2H7s16ESt4yC1+NvMdCO2UQHQODjHGfk4DPkV W1epIZeY+wv1FRxKw31TKpDC62nIoXjmjjZZzd/QfPH/W/9c0ccTVVd5FcuzDw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1762862899; a=rsa-sha256; cv=none; b=MccASeDnFEmmNrzGO/R6+NuViKbk8MwvEl48Lhl+L0LKK+nJhZf1+aOn+kZ2yobLV2H4x7 Anpkrh7JkQhZmKsDD3nzRUW805W3G65RZjK+zsY1gC8nQCxyNkWNT7Gcqrv4Gsef2xpQAw ipK+l1luq+8YtCRaSNORqJoMEjpPZFnbQNvy6crZBGPV3SK4G4l/qUiJA5JEIN96QQIoWb K65WakVJLETw8vpII4aoRROdxaZsqGE4NGNsaSF+O/kVCFpMfJiO9BuHfp2HltkJGBzpXB 6IzlhEYHYMcxWM1E5Djt7e0BlqVIsty9R/1EeepHuWg6Z4X0FqGZzh0MPYxegw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4d5QKZ728wz13rX; Tue, 11 Nov 2025 12:08:18 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 5ABC8IR5035376; Tue, 11 Nov 2025 12:08:18 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 5ABC8IT0035373; Tue, 11 Nov 2025 12:08:18 GMT (envelope-from git) Date: Tue, 11 Nov 2025 12:08:18 GMT Message-Id: <202511111208.5ABC8IT0035373@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Christos Margiolis Subject: git: 91fcc0132d0b - main - sound: Retire feeder_class->desc List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 91fcc0132d0b192f07f9b67626c9af2ad8759857 Auto-Submitted: auto-generated The branch main has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=91fcc0132d0b192f07f9b67626c9af2ad8759857 commit 91fcc0132d0b192f07f9b67626c9af2ad8759857 Author: Christos Margiolis AuthorDate: 2025-11-11 12:06:24 +0000 Commit: Christos Margiolis CommitDate: 2025-11-11 12:06:24 +0000 sound: Retire feeder_class->desc The only field we care about is pcm_feederdesc->type, so keep that one only and do not embed the whole pcm_feederdesc. While here, make the feeder type enum into a named one and use it as feeder_class->type's type. Sponsored by: The FreeBSD Foundation MFC after: 1 week Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D53556 --- sys/dev/sound/pcm/feeder.c | 8 ++++---- sys/dev/sound/pcm/feeder.h | 28 ++++++++++++++-------------- 2 files changed, 18 insertions(+), 18 deletions(-) diff --git a/sys/dev/sound/pcm/feeder.c b/sys/dev/sound/pcm/feeder.c index f55c3e5992e1..acc9e374e718 100644 --- a/sys/dev/sound/pcm/feeder.c +++ b/sys/dev/sound/pcm/feeder.c @@ -48,7 +48,7 @@ feeder_register_root(void *p) { struct feeder_class *fc = p; - KASSERT(fc->desc.type == FEEDER_ROOT, + KASSERT(fc->type == FEEDER_ROOT, ("first feeder not root: %s", fc->name)); SLIST_INIT(&feedertab); @@ -60,7 +60,7 @@ feeder_register(void *p) { struct feeder_class *fc = p; - KASSERT(fc->desc.type != 0, ("feeder '%s' has no descriptor", fc->name)); + KASSERT(fc->type != 0, ("feeder '%s' has no descriptor", fc->name)); SLIST_INSERT_HEAD(&feedertab, fc, link); } @@ -119,7 +119,7 @@ feeder_getclass(u_int32_t type) struct feeder_class *fc; SLIST_FOREACH(fc, &feedertab, link) { - if (fc->desc.type == type) + if (fc->type == type) return (fc); } return (NULL); @@ -400,7 +400,7 @@ static struct feeder_class feeder_root_class = { .name = "feeder_root", .methods = feeder_root_methods, .size = sizeof(struct pcm_feeder), - .desc = { FEEDER_ROOT, 0, 0 }, + .type = FEEDER_ROOT, }; /* * Register the root feeder first so that pcm_addchan() and subsequent diff --git a/sys/dev/sound/pcm/feeder.h b/sys/dev/sound/pcm/feeder.h index f89652ab9635..171168d66e4e 100644 --- a/sys/dev/sound/pcm/feeder.h +++ b/sys/dev/sound/pcm/feeder.h @@ -27,6 +27,17 @@ * SUCH DAMAGE. */ +enum feeder_type { + FEEDER_ROOT, + FEEDER_FORMAT, + FEEDER_MIXER, + FEEDER_RATE, + FEEDER_EQ, + FEEDER_VOLUME, + FEEDER_MATRIX, + FEEDER_LAST, +}; + struct pcm_feederdesc { u_int32_t type; u_int32_t in, out; @@ -34,7 +45,7 @@ struct pcm_feederdesc { struct feeder_class { KOBJ_CLASS_FIELDS; - struct pcm_feederdesc desc; + enum feeder_type type; SLIST_ENTRY(feeder_class) link; }; @@ -63,27 +74,16 @@ struct pcm_feeder *feeder_find(struct pcm_channel *c, u_int32_t type); void feeder_printchain(struct pcm_feeder *head); int feeder_chain(struct pcm_channel *); -#define FEEDER_DECLARE(feeder, type) \ +#define FEEDER_DECLARE(feeder, ctype) \ static struct feeder_class feeder ## _class = { \ .name = #feeder, \ .methods = feeder ## _methods, \ .size = sizeof(struct pcm_feeder), \ - .desc = { type, 0, 0 }, \ + .type = ctype, \ }; \ SYSINIT(feeder, SI_SUB_DRIVERS, SI_ORDER_ANY, feeder_register, \ &feeder ## _class) -enum { - FEEDER_ROOT, - FEEDER_FORMAT, - FEEDER_MIXER, - FEEDER_RATE, - FEEDER_EQ, - FEEDER_VOLUME, - FEEDER_MATRIX, - FEEDER_LAST, -}; - /* feeder_format */ enum { FEEDFORMAT_CHANNELS