From nobody Tue Nov 11 12:08:06 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4d5QKM1WT3z6GLK9; Tue, 11 Nov 2025 12:08:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4d5QKL6MqWz3bSL; Tue, 11 Nov 2025 12:08:06 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1762862886; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=J1hKVe7fKUOGD9CzBShI5m1RWgYf5CloSjaVyMDjQuw=; b=Jh2ufGA1+lw2UWRyQL0S8OgG5rEin3I62MOzg60r0V8Kepjfq6HheUKc4Jkc6/cAxe6oox IeYEz62y+b1Og26NDwtCLchS85j1FZdKEfXoPje+3b8SDyxvc1R/XOxZ/iwDuTjm/NehR/ Pd+CQOYcaBp3x6VKvrQtWGXCRHDDLqifqpzYHXqtLAR8Fsvmiw8Pl/5fbZ2UY/sj64oHrb xBxZvOOKrbT3pyEU50zBRC1bAZTOrCaM+LxVRd5Kkjq704TgfKQbh981DOpAAAyPOAMJEN Nqbc5LDq6axQlGNfV+HFj0DFEfFvV4RVbGJy4ZyIVQ4wP83LzT4GiMmHY0IsWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1762862886; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=J1hKVe7fKUOGD9CzBShI5m1RWgYf5CloSjaVyMDjQuw=; b=cIHFANssmBYfBo52KaWdHiYDyPlxe95AAN9XkXzX80+RTS5NLpHP472AYKuz9F/Bb0CND5 9Mhm0V0LVqBjMuq1Y+LJ5xgF66+xw3uzkGPNf20bLj/euLMJluWlE2ZiRgoMJh1gM0kbK9 MxhQlLa4LiGwPLULChS5RSMnEuQIN14R5MKnUssyufAs1TselsFr2pGlT4vDhhQtX+809P 9kXBZycHsv89GahhO6yTwJfRaHiKftMla62sfaihsoSYrJ2KUQBDgpAgXl7dPsjYrsA6mN 7Ut3p7KITdJftWnjcXNIlUdt/00Zu2C05ug6csC1N27VgURENozDNuvUPqQrEQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1762862886; a=rsa-sha256; cv=none; b=wwiCDaPop4nOYFdzF55L5m3LPIPExhjKYqEGYsf5UMSz5sECi1g1r1mc8d9VoOCe9FRfLV RP5Okytus/I8U1LCW5ezjy5Hbx+lWlYvpw01b9SYJwewiq70x/yLOzbFOXtVtixWnqewPf Ya6Ro0iyuck1Yjni/hUnTblaKoRBamjnNNS1rQEfQHMI43jJwBX9JqAYTvI5l9tFXFmvs3 0q3aGYWS9ZV9hfBKy4DQipi8JXOmOfIE8xPyUe7BSPIZrplRqT3a4Wpoi3YpiliLPlRnAY bkFkfb3xF1JvDKFmvh7EgGCOj7g3yJ9HxmHqU5vJuEqEZNtJck+gAfMTOLzt4A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4d5QKL5p74z13Wt; Tue, 11 Nov 2025 12:08:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 5ABC86D9035004; Tue, 11 Nov 2025 12:08:06 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 5ABC86Mi035001; Tue, 11 Nov 2025 12:08:06 GMT (envelope-from git) Date: Tue, 11 Nov 2025 12:08:06 GMT Message-Id: <202511111208.5ABC86Mi035001@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Christos Margiolis Subject: git: ad28c6a13a45 - main - sound: Remove redundant sndbuf_free() in chn_kill() List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: ad28c6a13a45746f32cbc832b3fe58748fae0d19 Auto-Submitted: auto-generated The branch main has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=ad28c6a13a45746f32cbc832b3fe58748fae0d19 commit ad28c6a13a45746f32cbc832b3fe58748fae0d19 Author: Christos Margiolis AuthorDate: 2025-11-11 12:05:30 +0000 Commit: Christos Margiolis CommitDate: 2025-11-11 12:05:30 +0000 sound: Remove redundant sndbuf_free() in chn_kill() If b exists, it will get destroyed by sndbuf_destroy() (which calls sndbuf_free()) a few lines below, so the additional sndbuf_free() here is redundant. Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D53527 --- sys/dev/sound/pcm/channel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/dev/sound/pcm/channel.c b/sys/dev/sound/pcm/channel.c index 749ee4d9cdba..54d8976d46bf 100644 --- a/sys/dev/sound/pcm/channel.c +++ b/sys/dev/sound/pcm/channel.c @@ -1373,8 +1373,8 @@ chn_kill(struct pcm_channel *c) } free_unr(chn_getunr(d, c->type), c->unit); feeder_remove(c); - if (c->devinfo && CHANNEL_FREE(c->methods, c->devinfo)) - sndbuf_free(b); + if (c->devinfo) + CHANNEL_FREE(c->methods, c->devinfo); if (bs) { knlist_clear(&bs->sel.si_note, 0); knlist_destroy(&bs->sel.si_note);