From nobody Mon Nov 10 19:54:28 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4d50jw4ZLcz63L5W; Mon, 10 Nov 2025 19:54:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4d50jw44zwz3YFr; Mon, 10 Nov 2025 19:54:28 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1762804468; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=7GR9iOke8WhKVcVKHJ97UrW8NJR7+EW7E5l6UHpIOwM=; b=DWqm+q4o5U0ivI0d8Ds7/2qS0XSAHBtEBUeodJPnuHyRX5kBf0yo/8CaQsctNBmDdQ0DRR 6fhcgENdNzPsNcxXauw7M5lkVrtF/zO9jADuNR3IFrlJ1M59tTAiXJC82a8gDlhIzgXYrb /88nXwG9MvABvbTDPsxEIE331YRcBvBFe+h750ahBNWxIFnnWTL6ZrXV+elsaP6438TfsU 1Q3qfFltL5TogBbJJMqHJ2kNaXe0hHl2uphF+rVTdG0HUuWWd6Ax7SDLEe/NX40CnlGBmR gpjr9VGVUHPZD3JNl3s/qUPtf6Heif3omKBo1hBAtq5HBGM1phSzFLQH6YVgNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1762804468; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=7GR9iOke8WhKVcVKHJ97UrW8NJR7+EW7E5l6UHpIOwM=; b=JvoD1usMixac0SVQGffAW8VIXVeskqW9lydooKytWZXwwc9plskIjgYTng3xb6h9FH7G5Z Kn5I1Z9sW8M7G/VozOXN0DI5ewwJogTO/m4v8cDfGrwq7W+ohwLun4Kwo5oMN/m5d69KfZ 9qnWNWLjSaXDH61iw6F371WU/ABxptVsRfLnmh9vUKsXZPwChJYQWt26BkJzZzqbuK2avN Ft0XaB22WEwTG37k4QhG6hsNMNmlpKdymznZNy7aTRuoMaXYWQVNbU6xIQ6ZY913L4fWq5 agE3PfDpOS5aoXlDIlgjW6ws0aeeMHR6OyC/5j/m9Vw7gvmKt0JbHXz6pGzozQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1762804468; a=rsa-sha256; cv=none; b=IalqGn+Pc/x/XsBkk+PtWzflNZ3hB00sZ5zG2rwNnWKrb2nHgP6m6bTjAv5dKOgW++sHrJ F4pL9NYwxm4vtuS7ApxY02C79/iHb93J0ab/3hVoctfkkdB0n7iShKLewvOIzej3mLMvgu /x4Unmn34djZqxi2aBxVpYuuLxvjpY9M/d2Fl4FA2oFJxf6zq6TpioH3mZcWpLjy1aG99B dyRG23AApHLCI4o9YYgMTiJKFxEBzfeWzrvaY5vixwO32/g2NnZYKvHfZqRz5f6BzWeKy+ PekngVN/mWwpFLLL9nun4PniNWB1AY2fuW+u+hlwrU/i0RUGqImLUXEMjh03Hw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4d50jw37h2zXVJ; Mon, 10 Nov 2025 19:54:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 5AAJsSiB007734; Mon, 10 Nov 2025 19:54:28 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 5AAJsSN0007731; Mon, 10 Nov 2025 19:54:28 GMT (envelope-from git) Date: Mon, 10 Nov 2025 19:54:28 GMT Message-Id: <202511101954.5AAJsSN0007731@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: "Bjoern A. Zeeb" Subject: git: b568711f8ef1 - main - LinuxKPI: 802.11: clear CONF_IDLE earlier List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bz X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: b568711f8ef1afd7c86ea2d8bd2f94f399f54dc1 Auto-Submitted: auto-generated The branch main has been updated by bz: URL: https://cgit.FreeBSD.org/src/commit/?id=b568711f8ef1afd7c86ea2d8bd2f94f399f54dc1 commit b568711f8ef1afd7c86ea2d8bd2f94f399f54dc1 Author: Bjoern A. Zeeb AuthorDate: 2025-11-10 19:41:08 +0000 Commit: Bjoern A. Zeeb CommitDate: 2025-11-10 19:41:08 +0000 LinuxKPI: 802.11: clear CONF_IDLE earlier When starting to scan and ending a scan we clear/set the hardware to idle. Similarly we set the hw to idle when we remove the channel context but when starting we only set it to non-idle when we went from assoc to run. This apparently was not a problem most of the time as the switch from a failed hardware scan to a software scan was racing against net80211. ad4ddc83ebf8 fixed that specifically for rtw88 and while we were more consistently scanning, this broke authentication as the setting of idle at the end of the scan was now happening reliably. Move the unsetting of idle from assoc_to_run to scan_to_auth for when we create the chanctx to keep it symmetrical. This makes authentication work again for rtw88. This likely also fixes the problems in the listed PRs. iwlwifi(4) mvm and mld driver parts do not use this information at all and were never affected. Sponsored by: The FreeBSD Foundation MFC after: 3 days Reported by: Oleg Nauman (oleg.nauman gmail.com) PR: 290850, 288186, 281979 PR: 272145 (the non skb-mem-limit parts) --- sys/compat/linuxkpi/common/src/linux_80211.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sys/compat/linuxkpi/common/src/linux_80211.c b/sys/compat/linuxkpi/common/src/linux_80211.c index 0dc3b2631804..f025f191a3bd 100644 --- a/sys/compat/linuxkpi/common/src/linux_80211.c +++ b/sys/compat/linuxkpi/common/src/linux_80211.c @@ -2308,6 +2308,10 @@ lkpi_sta_scan_to_auth(struct ieee80211vap *vap, enum ieee80211_state nstate, int changed |= IEEE80211_CHANCTX_CHANGE_WIDTH; lkpi_80211_mo_change_chanctx(hw, chanctx_conf, changed); } else { + /* The device is no longer idle. */ + IMPROVE("Once we do multi-vif, only do for 1st chanctx"); + lkpi_hw_conf_idle(hw, false); + error = lkpi_80211_mo_add_chanctx(hw, chanctx_conf); if (error == 0 || error == EOPNOTSUPP) { vif->bss_conf.chanreq.oper.chan = chanctx_conf->def.chan; @@ -3081,8 +3085,6 @@ lkpi_sta_assoc_to_run(struct ieee80211vap *vap, enum ieee80211_state nstate, int lsta->in_mgd = false; } - lkpi_hw_conf_idle(hw, false); - /* * And then: * - (more packets)?