From nobody Wed Nov 05 00:28:13 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4d1R4Z0rPlz6FsJ6; Wed, 05 Nov 2025 00:28:14 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4d1R4Z09QPz3dm0; Wed, 05 Nov 2025 00:28:14 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1762302494; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=x+nStetILEynjD4UIdwCbDO3l4W+WLqQhcWg650SG40=; b=n2lzcc9pADKZ9HE+6IHiC/913An/Pvn4YfA6uslMLydxfAIXQSnuPImaxviZjok4SN0fWz CfBBndBMvGc/gXY4svzBbkWU/IIAsuvnHMGOJTZk4UFeX1oUBLF8PmRnIvsmSTHcLJxyCc oP2TH83WzY67/VDErMKxedyWs1uOZxHmd/c2FHYkKbcNLb+YzN9J8iK8sfNxiUPMAVcN54 oqLerrUvpytwjKKahEOvJ9gcppgEv3AHt+qaysaON/y5Ad7E2yvxI3VTy4v0D6LFpnt0iD ML1bkS7T1aIHWNEIQOJXxNHmNAHnjCPC7ts7zd7Xrgr7yCXeNABAEeETcdgemQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1762302494; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=x+nStetILEynjD4UIdwCbDO3l4W+WLqQhcWg650SG40=; b=XvdwtBpmjIgcGYcwkThfHz7vhJeyQHAm1oBhCtkFMS+Z8qCiaAvrkryM9rxcrDzkPHYYYu eBPkOJn8T8k204zEObNJYzi/DszicCxrjdEmmB3Ie6LZ1x/HWU/lIRIwwrW/Saa6hUBBb8 c9NOannWPNRkTlY6uk6GzyFApHVZrCqb4oByNQBQrVgaO8Tcg/zwm6HxtU09lGvG6LVvQS 5Pq7XV/faFHOL3TMPSqBXEW179ts52q42ff+Ct1SYKwmGQv6ZACkxixOxojdfvCvhIxmPM nCCH5LQox16ZvYC/W8A7dr5bnqOgPm4flLPy5HnTuHvGfaRIgonJIDCcW2I/6Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1762302494; a=rsa-sha256; cv=none; b=m0HWBE3T6s7zBVqSceu3iaAO5aOtuPxu/UcFvuXaXcbFpPT7v+GzFTQbwU9IlEoHiFsPzh FVn6yfJXgJ7ZgtQSNjOELp2aDaQVfl8N7T+YaQT4QbTeXSkih+TJXi8/YLJQF08zKzZlk/ Wm8Qr4RGzD9x9gXSanLgtv29NntVwI66Ax7HHrlwbYex3u2qA392bbP27laVXTm7iPUxqj 5KPml10cedYOVh/tuwq+eNYdRXy99Jk+aZrlffykDibhGD4F3q0vWalHarTLkT6BQjXGK3 oAXraMgUFP1o5LQ9SIHxhGXlAvtun9l7gr5j7PMqjv6qd9KxONO4V/dhfj4cow== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4d1R4Y6cB8z4Jf; Wed, 05 Nov 2025 00:28:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 5A50SDFJ017308; Wed, 5 Nov 2025 00:28:13 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 5A50SDZM017305; Wed, 5 Nov 2025 00:28:13 GMT (envelope-from git) Date: Wed, 5 Nov 2025 00:28:13 GMT Message-Id: <202511050028.5A50SDZM017305@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kyle Evans Subject: git: 90314c04f10f - main - makedev(9): drop an additional note about cdevpriv dtors List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kevans X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 90314c04f10f583c37c59ec51fd628e3deaf3622 Auto-Submitted: auto-generated The branch main has been updated by kevans: URL: https://cgit.FreeBSD.org/src/commit/?id=90314c04f10f583c37c59ec51fd628e3deaf3622 commit 90314c04f10f583c37c59ec51fd628e3deaf3622 Author: Kyle Evans AuthorDate: 2025-11-05 00:28:02 +0000 Commit: Kyle Evans CommitDate: 2025-11-05 00:28:02 +0000 makedev(9): drop an additional note about cdevpriv dtors These were previously somewhat safe to call destroy_dev(9), but will now also cause a deadlock in the same fashion that d_close doing so would previously. Amend the note to point it out, in case it's useful for someone. Reviewed by: imp, kib, markj Differential Revision: https://reviews.freebsd.org/D53439 --- share/man/man9/make_dev.9 | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/share/man/man9/make_dev.9 b/share/man/man9/make_dev.9 index de56f350faa5..9f2c36fb39a4 100644 --- a/share/man/man9/make_dev.9 +++ b/share/man/man9/make_dev.9 @@ -25,7 +25,7 @@ .\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF .\" SUCH DAMAGE. .\" -.Dd January 19, 2025 +.Dd November 4, 2025 .Dt MAKE_DEV 9 .Os .Sh NAME @@ -387,14 +387,18 @@ function is the same as: destroy_dev_sched_cb(cdev, NULL, NULL); .Ed .Pp -The +Neither the .Fn d_close -driver method cannot call +driver method, nor a +.Xr devfs_cdevpriv 9 +.Fa dtr +method can .Fn destroy_dev directly. Doing so causes deadlock when .Fn destroy_dev -waits for all threads to leave the driver methods. +waits for all threads to leave the driver methods and finish executing any +per-open destructors. Also, because .Fn destroy_dev sleeps, no non-sleepable locks may be held over the call.