RE: git: 9ce5410b9094 - main - src.conf: regen

Kyle Evans <kevans_at_FreeBSD.org> wrote on
Date: Mon, 26 May 2025 04:22:01 UTC :

> The branch main has been updated by kevans:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=9ce5410b9094f9a2dce72e86a70fd086acdb3ff6
> 
> commit 9ce5410b9094f9a2dce72e86a70fd086acdb3ff6
> Author: Kyle Evans <kevans@FreeBSD.org>
> AuthorDate: 2025-05-26 04:20:44 +0000
> Commit: Kyle Evans <kevans@FreeBSD.org>
> CommitDate: 2025-05-26 04:21:51 +0000
> 
> src.conf: regen
> 
> This appears to be reflecting the default witch for LLVM_BINUTILS in
> 1cae7121c667d9 ("Enable LLVM_BINUTILS by default").
> ---
> . . .

A basic problem is that src.config's correct content should
be platform specific in part, not the same across all
platforms.

An example on aarch64 that seems incorrect:

WITHOUT_LLVM_TARGET_ALL
             Only build the required LLVM target support.  This option is
             preferred to specific target support options.  When set, these
             options are also in effect:

             WITHOUT_LLVM_TARGET_AARCH64 (unless WITH_LLVM_TARGET_AARCH64 is
             set explicitly)
. . .

That says that on aarch64 using WITHOUT_LLVM_TARGET_ALL
would use WITHOUT_LLVM_TARGET_AARCH64 so that the system
would not support targeting itself.

Note that the full list of WITHOUT_LLVM_TARGET_* listed
are:

             WITHOUT_LLVM_TARGET_AARCH64 (unless WITH_LLVM_TARGET_AARCH64 is
             set explicitly)
             WITHOUT_LLVM_TARGET_ARM (unless WITH_LLVM_TARGET_ARM is set
             explicitly)
             WITHOUT_LLVM_TARGET_POWERPC (unless WITH_LLVM_TARGET_POWERPC is
             set explicitly)
             WITHOUT_LLVM_TARGET_RISCV (unless WITH_LLVM_TARGET_RISCV is set
             explicitly)

That suggests that X86 (amd64 and i836) would be what was
still enabled. That suggests that the document was generated
for, say, amd64.

The WITHOUT_CLANG section is like that as well.


===
Mark Millard
marklmi at yahoo.com