From nobody Mon May 19 09:14:08 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4b1Bnr5tQMz5wnn6; Mon, 19 May 2025 09:14:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4b1Bnr525Vz47Pb; Mon, 19 May 2025 09:14:08 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1747646048; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=uoQHHc9xkSaAklEYNljVn3YCdPIK8vBt34dNCnH1meg=; b=gYu6Mccj9cKILiPoES1EVNDQX3rRhA1kPHh/W4g9JNOrcSjHL1TVM258ITes3gt9DxQ7AF ml2HF83vPHHyPvEylThZ2hvtgcQ5PUOjoMsfutTZDCW3RvUJ9aIzuo8Iy2Yev8HisIDJKF XqhkcZUWZOhHC/3DcdTcBvADY3o6X7x24izLJZFACqq1/nQ6XtURIoXWXtpgj03axh7DNO h1AbV17UAuYseZAdJR37DjhiLh9mXC4CCZ3QpfzLp115Phu2BV0jEdOEPWiMGFsFyxIY+7 gkGHe1SsdksCeksVKLfiQbOlhFanWqi7n+pyuAYvqFNaz5Eo6Cwu7nONAjXfdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1747646048; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=uoQHHc9xkSaAklEYNljVn3YCdPIK8vBt34dNCnH1meg=; b=Uywt9ao1iiK2tV24nShFXWb4s4FNqNykkgtGLeV93zHX/zMq3inEN+CMwmm5NYX47zpFZa wpmGITh7SLiQxUrk30/vfB/0QrXI0Yt02ak+V+I7TdkIiVMtaQHPcRVewnE1aK6emq9lsg +aMOGHwvy79cOgxy+XiGnr9je/+MND2+r5pGNhfZlNXlxORxvugMTDiTJVxFzH9bCRocwZ Bn3DaqTU+18olpItCT/v84561Ef4PYrzprkrEKGf0RksE4SS2bXH4inY4It/kUEHit0PDr eAyJZlPBMIJxpmGRVNlcIS5s6ZVuPo8wjCJxLk2g1ruZGpcyyaGDBZ3p7gaeNA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1747646048; a=rsa-sha256; cv=none; b=GzvYi3rN1ul9unl7DNoEaR3XeCdY0tt/pyuCtkkNTTA1hG34N0ixfcvklszxkUxYswsa8X hzIoP5/hWkqfwFrFM1j7tG3Nto7Np8ILsXVkPvHR1C37U1J6S+TOzPMqnTUFz+LHirS2xG u/y3mcrjkkw4AeZT5p8onFdA51/rZt0uluyNHj44aKp/nACBMMXB2tOInInE1Vh0UYPeAy IAE3tOuHz7MEk/soprITgifHI3djkGIebT1sahIbb7lbV9DFT1EJCqG74BmSi8gkPQcPQf 7BmTy03bQ3IEYZrNnxBTLfKeixQ3rrJLZ+9cvH/ebNVzuIvN61xEo5jSHHtaKg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4b1Bnr4RtZzy9Z; Mon, 19 May 2025 09:14:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 54J9E8NJ093115; Mon, 19 May 2025 09:14:08 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 54J9E8DN093112; Mon, 19 May 2025 09:14:08 GMT (envelope-from git) Date: Mon, 19 May 2025 09:14:08 GMT Message-Id: <202505190914.54J9E8DN093112@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Andriy Gapon Subject: git: 97c799661a76 - main - dwc_otg_fdt: do not create and leak extra usbus child List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: avg X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 97c799661a76b78963fd9f92a7e6bb452ebba999 Auto-Submitted: auto-generated The branch main has been updated by avg: URL: https://cgit.FreeBSD.org/src/commit/?id=97c799661a76b78963fd9f92a7e6bb452ebba999 commit 97c799661a76b78963fd9f92a7e6bb452ebba999 Author: Andriy Gapon AuthorDate: 2025-05-19 09:06:55 +0000 Commit: Andriy Gapon CommitDate: 2025-05-19 09:08:43 +0000 dwc_otg_fdt: do not create and leak extra usbus child dwc_otg_init() already takes care of creating the bus and setting up sc to point to it. Fixes: 518da7ace813e MFC after: 1 week --- sys/dev/usb/controller/dwc_otg_fdt.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/sys/dev/usb/controller/dwc_otg_fdt.c b/sys/dev/usb/controller/dwc_otg_fdt.c index 3d5dcb9e9a7b..2ed94b23212c 100644 --- a/sys/dev/usb/controller/dwc_otg_fdt.c +++ b/sys/dev/usb/controller/dwc_otg_fdt.c @@ -140,10 +140,6 @@ dwc_otg_attach(device_t dev) if (sc->sc_otg.sc_irq_res == NULL) goto error; - sc->sc_otg.sc_bus.bdev = device_add_child(dev, "usbus", DEVICE_UNIT_ANY); - if (sc->sc_otg.sc_bus.bdev == NULL) - goto error; - err = dwc_otg_init(&sc->sc_otg); if (err == 0) { err = device_probe_and_attach(sc->sc_otg.sc_bus.bdev);