From nobody Fri May 16 14:04:33 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZzTNK3nm5z5vmGk; Fri, 16 May 2025 14:04:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZzTNK2zhmz46Rc; Fri, 16 May 2025 14:04:33 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1747404273; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=7mLn7vOqXzEA9neY3xPwo9xLo4NvPHoinp+E9PrbymY=; b=LMnwSLvognsE3dEoL5ngO8N/VWqKMbf8SdRsNFF/9HH2ZVYHWs34HfJJ0UfSbhr8IaJz9+ LILRFppV6s/aKaQ2LQrmgXdbudymIzPP+1GP1rPD9t9Dt9KEr1FuwJt1J/UK+0c6sHYgUG z+T12E6IpnbxpWeYEcKysPb/hcpyBHTHVn5OoUDsyjNrCQqUssrPlbhIeLr36HXFXUPm5q 8nBWKUaxEdxJIvyBrK73yIPCaS+HAXYRKWQHVWCUqqQjb3sZ67RIoTmcdKLfgVVlHCjMHE WIjd4FWqNvRI2HweW7QKK9+WvXv0WWKt4LeULJREgD8fqrIFLUPWVg1Gk4zksw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1747404273; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=7mLn7vOqXzEA9neY3xPwo9xLo4NvPHoinp+E9PrbymY=; b=sn/HjtV9Vva+MHA3WT7IveFquh/pOHqVgu5bBVjCqgF1veBVWCNQ1SXUaVbtnM45f93n9P yaZYmoxcHUv14JL+LrSfYBtR9gD+OCzmNJ861qB4wV5aB+B8eIBdYsvQiVPpJAfhjwBeV8 zCh9WY6PH2bz3YgOMc76uMHoDSFzh0JvjW6yqjPImfhi+j2fNFs3Lyt970nGYqLeTCB6r0 bc1XHINcw9Lr7F5FyNrg6e18BN75asvjLBaBkOPu1+NvwJYGBNlLhOx+NnmnP+lGW20h1G /znWkFc3S3gXIHMNIBL+cdma6DrQpFLJ7LrjH68LqbHuGUigjjdCoIw0ZmUYpQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1747404273; a=rsa-sha256; cv=none; b=OPfKg3FQO22huktOmuJuEeVMTobE+8iJeBLhJX3oSi+8QdVjWasFV42ZVCbsBXks0I+mhj YuoZwhjXeSkKWd6Ya7YN6G2hpL3Ztn1n2/vnZ4rPlujsvyDDkFDoPxwIENA0FYJm1h6piM n2EYZBRqNP8X/Vfo9Er3BiTxum2ZrXIa8QeNDSnei2yjZeqt2aKOrn9VK+FP/FCkezhfIx px55wPAeETx4agadyoc/BMAepNH0LC59bSmqS+MnQbESGuporuTno4MXrJq46RkPb8RpNF r28kk45JtQsjmzbwZ5/hAsIQjW/siz5KKnZlzk9QcQ6UFqvb5Ak0WPnLICJuVw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZzTNK2Vf5z15S7; Fri, 16 May 2025 14:04:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 54GE4XK4021408; Fri, 16 May 2025 14:04:33 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 54GE4XSh021405; Fri, 16 May 2025 14:04:33 GMT (envelope-from git) Date: Fri, 16 May 2025 14:04:33 GMT Message-Id: <202505161404.54GE4XSh021405@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Joseph Mingrone Subject: git: 9d29fc2e4bfb - main - sh: Avoid referencing uninitialized memory in alias List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jrm X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 9d29fc2e4bfba9fcd3b0944e683458a3f1fa0c47 Auto-Submitted: auto-generated The branch main has been updated by jrm: URL: https://cgit.FreeBSD.org/src/commit/?id=9d29fc2e4bfba9fcd3b0944e683458a3f1fa0c47 commit 9d29fc2e4bfba9fcd3b0944e683458a3f1fa0c47 Author: Joseph Mingrone AuthorDate: 2025-05-15 14:42:14 +0000 Commit: Joseph Mingrone CommitDate: 2025-05-16 14:03:09 +0000 sh: Avoid referencing uninitialized memory in alias If run as alias '' uninitialized memory could be referenced. This is based on a fix from NetBSD. For more information, refer to https://github.com/NetBSD/src/commit/10cfed82c28 . Obtained from: NetBSD (Robert Elz , 10cfed82c28) MFC after: 3 days Reported by: mckusick, Robert Elz Reviewed by: emaste Differential Revision: https://reviews.freebsd.org/D50364 --- bin/sh/alias.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/bin/sh/alias.c b/bin/sh/alias.c index a02554d66e24..681e82b3e19e 100644 --- a/bin/sh/alias.c +++ b/bin/sh/alias.c @@ -204,6 +204,11 @@ aliascmd(int argc __unused, char **argv __unused) return (0); } while ((n = *argptr++) != NULL) { + if (n[0] == '\0') { + warning("'': not found"); + ret = 1; + continue; + } if ((v = strchr(n+1, '=')) == NULL) /* n+1: funny ksh stuff */ if ((ap = lookupalias(n, 0)) == NULL) { warning("%s: not found", n);