From nobody Sat May 10 14:48:35 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Zvpdw16g4z5wRCg; Sat, 10 May 2025 14:48:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Zvpdv5XTBz3YQG; Sat, 10 May 2025 14:48:35 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1746888515; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Fmlsuyw27jBv64yUjKWrvUX2cgYRhizISd5jgRW34l4=; b=yHyiV/1aEPKM+r+DGdHZvOs7VfPRV2hM0jga3Fjr44oXqqYCWlz3g+5BvI+vs8KRZ/6QS7 SGFt8Aw1UVkLfTEjp/40KgyzPvjYCaWxeT/OuSMaXE3jDvt8OkVG06AK8vYHlufeQwL3kn aRjAJROw4GPUianqPT7gpCh17itW3bKyx2uwouahnE4G37Aoq1LrVuxNVrYCXIIt5b1olm SgZfs8hVimN+9JmQvIM98NFsFWEb73O0606o3w0b7uFrrGgKG02vUXD5MLPw/tnnLCJuJA erWNYQwANiHMKslgrVCWQ7o+U05nh8gfB3EMUusBIIW5uPaxk716B0owdom0iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1746888515; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Fmlsuyw27jBv64yUjKWrvUX2cgYRhizISd5jgRW34l4=; b=wJh+5v14WSRluE4Et98g+tJgLoC6rxTpVzzDGtJ2Z7qVNDzGCXGmogq370hPGDGbylXUV1 JMBNLfv5+s1ADBWAAcGCsY7Jkb6zBD5GTbxnkcFRrD9sEo6Bw4iLknCEudAPLzkhJDWVl8 UQyp8qKMemlEoD3OXH10uISTOhMv0Sw80EgZ4H4djvIwLDtNdjTFT8foq4BIubXABcpkZV 05ETVRUqqlLsXsyQrdbS2mETzmtXUXvbZ+CrLwudbHg846sB4g6r1itqr6Vdc8xk1Ws3w7 dxr1iG1VyNt1NVhpYKAEz0Z3+uAsCl+Yz8FZHsGTOValfeqrawaQ2iTX4Upo/w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1746888515; a=rsa-sha256; cv=none; b=T7cBJvc036CDa4ktm0bmdGcxc5a4/XQZ5//ohitKRpPloOF1NQMdPmQWEabJEaGDbpxhTu 5caih37WwfDqvdELunD6xmrr2gipFcH2lk+lAD7iDXyEfaH3roXohEH+kvTrmuaQuTdC4m igKnYY25d6uB2r0JPl6eirJSRhPLC4WaLKl8grDDIDvGcPNbSD+ayD0eJBvLc20PQV35mn 9Mb83TpYj4+KwdsWXSx3969lP2icOWid30gBP0uQ7mbXan1e5gmnG/lgBRP6Imkcyuk1z7 fXN43uUbnnKb8zy9tZf/zpJqCWE2Kj46/mUlc2WcNeUyIhNmt8rCocQhu6msCg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Zvpdv40TYzqkp; Sat, 10 May 2025 14:48:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 54AEmZ1x014940; Sat, 10 May 2025 14:48:35 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 54AEmZVh014937; Sat, 10 May 2025 14:48:35 GMT (envelope-from git) Date: Sat, 10 May 2025 14:48:35 GMT Message-Id: <202505101448.54AEmZVh014937@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Rick Macklem Subject: git: 511de5b1430e - main - runat.c: Add an explicit check for snprintf() failure List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: rmacklem X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 511de5b1430ea974b3dc6fcb2af28d2e10b2b25e Auto-Submitted: auto-generated The branch main has been updated by rmacklem: URL: https://cgit.FreeBSD.org/src/commit/?id=511de5b1430ea974b3dc6fcb2af28d2e10b2b25e commit 511de5b1430ea974b3dc6fcb2af28d2e10b2b25e Author: Rick Macklem AuthorDate: 2025-05-10 14:44:38 +0000 Commit: Rick Macklem CommitDate: 2025-05-10 14:46:17 +0000 runat.c: Add an explicit check for snprintf() failure The check for "outsiz" too large was probably sufficient to catch failures, since it was cast to an unsigned (size_t). However, it seems appropriate to add an explicit check for a failed case (returning -1). Discussed with: oshogbo Fixes: 0660de8172cd ("runat: Add a runat(1) utility similar to the Solaris one") --- usr.bin/runat/runat.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/usr.bin/runat/runat.c b/usr.bin/runat/runat.c index 66f4ebadd180..99437f3472f4 100644 --- a/usr.bin/runat/runat.c +++ b/usr.bin/runat/runat.c @@ -52,6 +52,8 @@ main(int argc, char *argv[]) pos = 0; for (i = 1; i < argc; i++) { outsiz = snprintf(&buf[pos], siz, "%s ", argv[i]); + if (outsiz <= 0) + errx(1, "snprintf failed: returned %d", outsiz); if ((size_t)outsiz > siz) errx(1, "Arguments too large"); pos += outsiz;