git: 5b4b2c7c9b8a - main - vm_page: drop stale memq comments
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Wed, 07 May 2025 21:52:01 UTC
The branch main has been updated by dougm: URL: https://cgit.FreeBSD.org/src/commit/?id=5b4b2c7c9b8a43eceaa3aa3d2f962599f602928b commit 5b4b2c7c9b8a43eceaa3aa3d2f962599f602928b Author: Doug Moore <dougm@FreeBSD.org> AuthorDate: 2025-05-07 21:47:20 +0000 Commit: Doug Moore <dougm@FreeBSD.org> CommitDate: 2025-05-07 21:47:20 +0000 vm_page: drop stale memq comments The member memq was dropped from the vm_object struct because it was redundant. Pages were kept in an ordered tail queue, and also as leaves in a radix tree. Over time, the radix tree was enhanced so that it could iterate over pages as effectively as could the tail queue, and then a series of small changes replaced uses of the tail queue, one by one, until finally it was created and maintained but never used. So then it was removed. But two comments about its existence were not dropped, until now. Reviewed by: alc Fixes: c8d56817b80f ("vm_object: drop memq field") --- sys/vm/vm_page.c | 3 --- sys/vm/vm_page.h | 4 ---- 2 files changed, 7 deletions(-) diff --git a/sys/vm/vm_page.c b/sys/vm/vm_page.c index 869ba1634000..5ed1879c6a34 100644 --- a/sys/vm/vm_page.c +++ b/sys/vm/vm_page.c @@ -1545,9 +1545,6 @@ vm_page_iter_insert(vm_page_t m, vm_object_t object, vm_pindex_t pindex, * Complete page "m" insertion into the specified object after the * radix trie hooking. * - * The page "mpred" must precede the offset "m->pindex" within the - * specified object. - * * The object must be locked. */ static void diff --git a/sys/vm/vm_page.h b/sys/vm/vm_page.h index 979d9bd12b9f..3d7257644ef6 100644 --- a/sys/vm/vm_page.h +++ b/sys/vm/vm_page.h @@ -78,10 +78,6 @@ * A radix tree used to quickly * perform object/offset lookups * - * A list of all pages for a given object, - * so that they can be quickly deactiviated at - * time of deallocation. - * * An ordered list of pages due for pageout. * * In addition, the structure contains the object