From nobody Mon Mar 31 15:14:04 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZRF5n6ssLz5s9W3; Mon, 31 Mar 2025 15:14:05 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZRF5n5qbnz48Sv; Mon, 31 Mar 2025 15:14:05 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1743434045; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=swLPVSivDthYqMvFfmx7lHLwWQIm5WJfdT4Zr0S4lPs=; b=nykEZZCOZLVNm4lR2I+UQKRsr6NccikFVmZUGAg9/BW4Phm0nlKyQTJPeI4IN8uU6QEJXz /JMaTgB2MTyClO9dfHrWec0ftasYqA1c2/bGQY4r5rPBWXuCgjwwpe7Zx7hdhIb+iFOoFs anmdf8FNsdlZvMqc5YLpP54lx/4K8UxWnHCpQkcuNYD2aLKGKhiPp72D+jlcz+NSwNKCor BwAAzCAPgKSU6XZzDgi6wULhwCtNGZPE1Inc7CYs6iCZ3NHTatbpKdIxJGiUPl4lW6LBDP QKTgPUa0Qc4UYDX3/32u2U8utJJjsBIHg6xkEUh0tKvCioC54hefmk3OOQkt3w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1743434045; a=rsa-sha256; cv=none; b=aUxLktD8VSefNwQrf72Dd2pB1/dzj1aRYxAhaPnz9QgMw0CBg1B+zrV7oeJaIGxivrxY4j Aq8epj+k584WuFSBTJeAv7xJghEj96tUVQd9tvflH9w7KL+TSdP03B7HDsJyo2l5mlNMXi m5GUhL7w1kiZprvSOZMdLNTwUem0cecQIrsLmVfPff+I8Xj8wSp1MHGcPoJYxaORILsjvL u4LEls242EjNera4DxIGAZwSGVQjr+oKnWnvFl02S6+Du02b9CXpWkPWtghk5XL/8no1Jr pT4U54R1KlxhRnAJDKxXV9OKsUArRqhh4RXBQvfpZi0Z7CmaOF4YvqyD9DXIag== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1743434045; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=swLPVSivDthYqMvFfmx7lHLwWQIm5WJfdT4Zr0S4lPs=; b=CQ/GiX515Vb5fPCi5UocgqOfr2IQdrA88tlFjsfqWvSYhH84oMkwqG32rHzwSu2GfxdlsM yTVbG8swmQqA1nNCEFdAg4XXGy98agiZOE/kLMny8v7p4ahAr4oMMg0oIDRERtqW9tW+1+ hMPuvOh48AqPoIuuLnU3OaoBNL6TY/acbHUF8PmgQc9LQH07imRG3KcnSvr06tk28l2WCB oPcXq9Wc+L8gVPP4BhwM5BebzhHU371AmuTvBmP+UGiVJ9cY1pZ+j1QGWzZnG4N6p0fdr0 qenYBIXIGUxwklNurWFfoEo9nCchxCjMOgSdf0Z1tzbpMKxYG7sPSnp/taYmRw== Received: from [IPV6:2601:5c0:4200:b830:95ca:52bb:57ab:e333] (unknown [IPv6:2601:5c0:4200:b830:95ca:52bb:57ab:e333]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4ZRF5n3tLwzymL; Mon, 31 Mar 2025 15:14:05 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <25967c7b-79c0-4883-8b92-86e58201589b@FreeBSD.org> Date: Mon, 31 Mar 2025 11:14:04 -0400 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: e24279e0f9e2 - main - Remove mentions of ENOSYS added in d97e44784bb5 Content-Language: en-US To: Enji Cooper , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202503280240.52S2elHG075912@gitrepo.freebsd.org> From: John Baldwin In-Reply-To: <202503280240.52S2elHG075912@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/27/25 21:40, Enji Cooper wrote: > The branch main has been updated by ngie: > > URL: https://cgit.FreeBSD.org/src/commit/?id=e24279e0f9e28ba0c1920cb539fc357568790c0a > > commit e24279e0f9e28ba0c1920cb539fc357568790c0a > Author: Enji Cooper > AuthorDate: 2025-03-27 19:26:59 +0000 > Commit: Enji Cooper > CommitDate: 2025-03-28 02:40:07 +0000 > > Remove mentions of ENOSYS added in d97e44784bb5 > > aio(4) is a hard requirement in the kernel as of f3215338ef82. The > scenario that the patch was submitted for is no longer possible. > > This isn't a straight up revert since the previous change also addressed > some minor issues. > > PR: 190942 > Reported by: asomers > MFC after: 2 weeks > MFC with: d97e44784bb5 > Fixes: d97e44784bb5 ("aio_*(2): mention ENOSYS under ERRORS") > Differential Revision: https://reviews.freebsd.org/D49541 FWIW, I think it would have been cleaner to do a full revert and then do a followup commit applying the other changes. You had to do the followup commit anyway to bump .Dd. Not anything to change here, but something to consider in the future. -- John Baldwin