From nobody Mon Mar 31 10:07:54 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZR6JV6V4zz5rmDX; Mon, 31 Mar 2025 10:07:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZR6JV5ccPz476g; Mon, 31 Mar 2025 10:07:54 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1743415674; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=QC8p+gtgYiMxIw0u9emXyRUmerl7WiyNpqx0+NPxYq8=; b=hJyz/jjutF5DB8mW/QL9wR6cIq80CBbXR6UQavR/WWpcSLZk2/IWeNPbqTlGprcSRtrnMo BKGNnzHGnSk+3B15vYIe6iiQokqpeue9q82D3wRGNvY7y5/ZTYAXGDTDbZLGtHs/CQx5KT fEfHKqPpZUIIEts3VYx0h/jMl/XfA3ouquBNOFHScMlhb0YwIeSVjeNfr6UiKFDdRt+MKJ 3ErjyF1nHaKrnhghqSAIuanRrJqdSSYAErkiekp85jofceOXkZcvtYe+Wr76dPbtmQNLKn WuK879HKKTnOjzCB2KjCQfPen8JakZryBb7pfPxNCWtPwZO3kLSH8DAZUWUlWQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1743415674; a=rsa-sha256; cv=none; b=GO/J2hxbph2pzObXCvcTCpsyZIIMVYnwlPCZgfakyH+2iQCMsl0Xt+W1Uj7PppdrtmWRr/ JH5eCGA1KqWiYtqfVZ6S4lnjxuWFkSoxdvdT9y2NraviaHDGV6yeMq63SmNQaESbH9ZYci VznZoJu702aV7fRviDToR9CVOksUjJFNHzqcxuPIupGOIGnfJD1Tcsg61e4cgYVe5VSC8W Fjh/R9dzOoj35wn0wKcHdL04DDsveGg/dhyEsNG+Dm/kV4nYEXwLlNrQ0b2OeYzGhjIosp vz/OgWt4M7TmVv4RGhN587qkSg8jxOZnSC/uv/FBuhxrpT5UsHTwYCh5uQspwg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1743415674; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=QC8p+gtgYiMxIw0u9emXyRUmerl7WiyNpqx0+NPxYq8=; b=jQhWwAZoFWKWek3QDE08lSrQNykPbhm01U3EMUHCqz2k5OC4QztZKJYuM3BQb6sSaoFvGz Tjpto/D9EinevevCBaxHSO69vVNxKZDZNlRZZ4zafCRIPRM8nEhSst0B7JxLOVQt1SSAEh h3E7ahqJO+uIQS2/CcXlLySOZrkW6Y5htMOgFGSVkJngUbBqWNhJVJfX1+THsAFkCIAn1T ibML0K12Uh5MFSdxcJxllm/WabaJHMyk6hDyjUbGZW1nXu1o4tJKRrxBNJeAuIZoXU8JJb s5/6zaBKWmHCHtviAbXh1xxOcvlH9tEagncH8eFdE2o0e4Jk839sbRR0Ahe9nw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZR6JV4zyYzgfW; Mon, 31 Mar 2025 10:07:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 52VA7ssj092200; Mon, 31 Mar 2025 10:07:54 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 52VA7sw8092197; Mon, 31 Mar 2025 10:07:54 GMT (envelope-from git) Date: Mon, 31 Mar 2025 10:07:54 GMT Message-Id: <202503311007.52VA7sw8092197@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Michael Tuexen Subject: git: e8623834ca29 - main - sctp: fix double unlock in case adding a remote address fails List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: e8623834ca29b562687db945bdd12a3e2fe4aeb1 Auto-Submitted: auto-generated The branch main has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=e8623834ca29b562687db945bdd12a3e2fe4aeb1 commit e8623834ca29b562687db945bdd12a3e2fe4aeb1 Author: Michael Tuexen AuthorDate: 2025-03-31 01:25:53 +0000 Commit: Michael Tuexen CommitDate: 2025-03-31 01:25:53 +0000 sctp: fix double unlock in case adding a remote address fails Thanks to glebius@ for pointing to the problem. Reported by: syzbot+1d5c164f1c10de84ad8a@syzkaller.appspotmail.com Fixes: 2d5c48eccd9f ("sctp: Tighten up locking around sctp_aloc_assoc()" MFC after: 3 days --- sys/netinet/sctp_pcb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sys/netinet/sctp_pcb.c b/sys/netinet/sctp_pcb.c index 55b452743f86..1a8a514fbf5f 100644 --- a/sys/netinet/sctp_pcb.c +++ b/sys/netinet/sctp_pcb.c @@ -4232,7 +4232,6 @@ sctp_aloc_assoc_locked(struct sctp_inpcb *inp, struct sockaddr *firstaddr, LIST_REMOVE(stcb, sctp_asocs); LIST_REMOVE(stcb, sctp_tcbasocidhash); SCTP_ZONE_FREE(SCTP_BASE_INFO(ipi_zone_asoc), stcb); - SCTP_INP_WUNLOCK(inp); SCTP_LTRACE_ERR_RET(inp, NULL, NULL, SCTP_FROM_SCTP_PCB, ENOBUFS); *error = ENOBUFS; return (NULL);