From nobody Fri Mar 28 19:04:27 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZPVM05NV7z5rHxr; Fri, 28 Mar 2025 19:04:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZPVM00TJVz3DqH; Fri, 28 Mar 2025 19:04:28 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1743188668; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TdjU9IEZLrGw12ezSz819BgPNUkz9S4mQDeIKv+Ksko=; b=J+MQ1h8Ap3jRweOKa0k0yUcuw9xdHSAzvCBbmtlmS7FMLzrOFT8oFothaV0i84KsNsl2+G /Up3O3wBzjsT3CgXD50/OZuRrN50Dbx+toIuO+5RpcooX2K4fvWMSx2DmPYyiLbyGaUAKj npa1IlsMf8ka61ugRad4bY6ENZIRtluviLflx+Ih6yEHNo1eq9mXzlCKn2/j8iAqzE7u9L n7WI0C+vB0h5N4LWbzycOu944OZLpO/xEgCE6JH66n0Y1BfotOfT0lVVGIbUKxWAa2GsgG H2uQwXCsJdzcGen+BYxXqb0CCWVZCBNAD/nLtfMG1K7FOuwSSAidwqhZn4/Uhw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1743188668; a=rsa-sha256; cv=none; b=h3SnDCZXLei37iZmc3eVMZ55jFcTx26adwvt63RcYUA2eMMt865MK8+S7rOS519SC1/VVj EUMPgSK+RkzZLq5tg231vyEuZCRIxHVWbLLKdAhPgMl8Zjwh0iF66Zb3r4Z7xlCQGGyc9D XRcTKTqvAwlm/TEv6LDOQHPyAsmwgEskqCFUaQgrw0g9vpfN73DmFlrvkrgXzn+SnpABJj NsuB7vLKqiAY4InMiXTFGpprv4zNXm9c5URPqEOwvmrUw6IVb+6WiQboIzDdUDirCLrIqB 08H8Zss1cjMR5oPgKFZZbp7jltez6CvjywjawYhw91etmfE/meosZ7IJertbzw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1743188668; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TdjU9IEZLrGw12ezSz819BgPNUkz9S4mQDeIKv+Ksko=; b=UKMGmVUMp6SwOhsDZQcAUCGV/Jh/IvI46ec76CryH0iSpufR3ZEgrJI0ug8VWwqXfubC5W l0eIa8tuQBvvMYUtN/wlFO1xPTavK51iCTVkJI9KPuutVjdYUQ69pJFUqGvClzL2WZI3jt Xpo6f9J6Sl6iAEtAAooWuRnSM9PD9dNLZYE5F9kSXcxWqsJDe+jD3QkUEpVCzhXrbUsh3+ CKtqr97ywGt9Np97hdpRMyuNdtLBsgTdUy/uxsZyS8GtteEdknFGkYxhmd5PLW3z4OlBa+ hM25SaCq7WOemJ5ANAl+G54rrrDNrXRfy8vJKPC7nTzSpsZH4IPzd2vYUZCIqg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZPVM002j8zw0F; Fri, 28 Mar 2025 19:04:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 52SJ4RRc022706; Fri, 28 Mar 2025 19:04:27 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 52SJ4R9k022703; Fri, 28 Mar 2025 19:04:27 GMT (envelope-from git) Date: Fri, 28 Mar 2025 19:04:27 GMT Message-Id: <202503281904.52SJ4R9k022703@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Adrian Chadd Subject: git: d8482e1b3e14 - main - athpoke: Use a format string with err() List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: adrian X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: d8482e1b3e1473c7a8216f356bb978c792740a85 Auto-Submitted: auto-generated The branch main has been updated by adrian: URL: https://cgit.FreeBSD.org/src/commit/?id=d8482e1b3e1473c7a8216f356bb978c792740a85 commit d8482e1b3e1473c7a8216f356bb978c792740a85 Author: Adrian Chadd AuthorDate: 2025-03-27 23:43:35 +0000 Commit: Adrian Chadd CommitDate: 2025-03-28 19:00:34 +0000 athpoke: Use a format string with err() Don't do err(1, ptr); that's a very old security risk turned warning. Differential Revision: https://reviews.freebsd.org/D49546 Reviewed by: thj --- tools/tools/ath/athpoke/athpoke.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/tools/ath/athpoke/athpoke.c b/tools/tools/ath/athpoke/athpoke.c index e54388587ca8..02a21676e91f 100644 --- a/tools/tools/ath/athpoke/athpoke.c +++ b/tools/tools/ath/athpoke/athpoke.c @@ -89,7 +89,7 @@ main(int argc, char *argv[]) atd.ad_out_data = (caddr_t) &state.revs; atd.ad_out_size = sizeof(state.revs); if (ioctl(s, SIOCGATHDIAG, &atd) < 0) - err(1, atd.ad_name); + err(1, "%s", atd.ad_name); argc -= optind; argv += optind; @@ -132,7 +132,7 @@ regread(int s, struct ath_diag *atd, uint32_t r) atd->ad_out_size = sizeof(v); atd->ad_id = HAL_DIAG_REGS | ATH_DIAG_IN | ATH_DIAG_DYN; if (ioctl(s, SIOCGATHDIAG, atd) < 0) - err(1, atd->ad_name); + err(1, "%s", atd->ad_name); return v[2]; } @@ -147,7 +147,7 @@ regwrite(int s, struct ath_diag *atd, uint32_t r, uint32_t v) atd->ad_in_size = sizeof(rw); atd->ad_id = HAL_DIAG_SETREGS | ATH_DIAG_IN; if (ioctl(s, SIOCGATHDIAG, atd) < 0) - err(1, atd->ad_name); + err(1, "%s", atd->ad_name); } static int