From nobody Thu Mar 20 07:11:46 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZJGwR12fFz5rQpN; Thu, 20 Mar 2025 07:11:51 +0000 (UTC) (envelope-from noreply@sjh.sh) Received: from sjh.sh (sjh.sh [IPv6:2001:19f0:5c00:286a:5400:5ff:fe26:bbcc]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature ECDSA (prime256v1) client-digest SHA256) (Client CN "*.sjh.sh", Issuer "E6" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZJGwQ0Hh9z3nZy; Thu, 20 Mar 2025 07:11:50 +0000 (UTC) (envelope-from noreply@sjh.sh) Authentication-Results: mx1.freebsd.org; none Received: from [IPV6:2601:404:ce00:7c90:ec4:7aff:fec4:ac4a] (unknown [IPv6:2601:404:ce00:7c90:ec4:7aff:fec4:ac4a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.sjh.sh (Postfix) with ESMTPSA id EA08675600; Thu, 20 Mar 2025 07:11:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=sjh.sh; s=default; t=1742454707; bh=q487n6np+Nl+lSjqQGXiHx4pTSEKAxzjK1KRW9fqE74=; h=Date:Subject:To:References:From:In-Reply-To; b=KbNLm5FXXF1Jn2GuuWGjgDi1f/euGDQ/DB0n3ezg6xdqu9TOpM9pbu6lqSG4TrHaA 5CKpw+yg/n272jP+RladHiRSRfxihkHQOXaYxH3izPSAI0HMdRxC+eCyR3Xc3/UG2S 98SIsdpefBRbDFhmE463LnN80Ugq6K50RpqYcgmcdBlqA/W8r0b2gemrcpsgmjxP36 75GjyAEteYqk7D3WCMO+Xq2/waBPxf240oojJ7+xRtDHQx77lt77HIbac1t2OyJ3Bw D9cDLJMxVP7jpjE729DZYK+mXZmTsr2795wOg+xcYGWlIiT0CbTddJSBqgGXfeGf5+ d3xM0DFxhLK0g== Message-ID: <1c4b2e3e-aabc-4fd4-a115-56a9133e9bff@sjh.sh> Date: Thu, 20 Mar 2025 03:11:46 -0400 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 9d0eea9422d0 - main - Make newly POSIX functions visible To: Colin Percival , Stephen Hurd , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202503192345.52JNjFxt093046@gitrepo.freebsd.org> <01000195b231d604-edc6ae17-e5d4-4dc6-afd3-995223ecde17-000000@email.amazonses.com> Content-Language: en-US From: Stephen Hurd In-Reply-To: <01000195b231d604-edc6ae17-e5d4-4dc6-afd3-995223ecde17-000000@email.amazonses.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:20473, ipnet:2001:19f0:5c00::/38, country:US] X-Rspamd-Queue-Id: 4ZJGwQ0Hh9z3nZy X-Spamd-Bar: ---- On 2025-03-20 02:16, Colin Percival wrote: > On 3/19/25 16:45, Stephen Hurd wrote: >> commit 9d0eea9422d075c8a6924b33161d2d5abfb4072a >> Author:     Stephen Hurd >> AuthorDate: 2025-03-19 23:45:06 +0000 >> Commit:     Stephen Hurd >> CommitDate: 2025-03-19 23:45:06 +0000 >> >>      Make newly POSIX functions visible >>           Some of the POSIX 202405L functions are already in the >> system, make >>      them visible when appropriate. >>           Reviewed by:    imp >>      MFC after:      1 week >>      Differential Revision: https://reviews.freebsd.org/D47859 > > This broke lang/python311: >> --- Modules/posixmodule.o --- >> ./Modules/posixmodule.c:12907:9: error: call to undeclared function >> 'setresuid'; ISO C99 and later do not support implicit function decla >> rations [-Werror,-Wimplicit-function-declaration] >>  12907 |     if (setresuid(ruid, euid, suid) < 0) >>        |         ^ > I realize this is almost certainly a bug in Python (assuming that these > functions are available without setting the right POSIX level) but if > Python has this bug I'm sure other ports will also be affected. Please > back out this commit and talk to portmgr@ about doing an exp-run to find > out what needs to be fixed in the ports tree before re-committing this. I could also make it #if __POSIX_VISIBLE >= 202405 || __BSD_VISIBLE Should fix the problem, but still make them visible for POSIX.