From nobody Thu Mar 20 06:16:05 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZJFh75cV5z5rMqh for ; Thu, 20 Mar 2025 06:16:07 +0000 (UTC) (envelope-from 01000195b231d607-260ae5cd-6a59-4187-b9c9-9029bf20f91a-000000@amazonses.com) Received: from a8-13.smtp-out.amazonses.com (a8-13.smtp-out.amazonses.com [54.240.8.13]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZJFh65sR5z3C7l for ; Thu, 20 Mar 2025 06:16:06 +0000 (UTC) (envelope-from 01000195b231d607-260ae5cd-6a59-4187-b9c9-9029bf20f91a-000000@amazonses.com) Authentication-Results: mx1.freebsd.org; none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=vnqrkfnvu6csdl6mwgk5t6ix3nnepx57; d=tarsnap.com; t=1742451365; h=Message-ID:Date:MIME-Version:Subject:To:References:From:In-Reply-To:Content-Type:Content-Transfer-Encoding; bh=kYXirL6T5SMEuGYUdunqxwrHTUFx7O+Ivnu0IG9v0AM=; b=DvZ4cRt65CXxFjfFqSxq88PE2Ou4wbZbNMbOnhJNKMCEWUuWj7kReB7YXHG3RL8d 9cCALhnoLHGqVfkLLwwOGnxU/ZMSfQBdL8QyqYrSv8fmR16eNQXEevnxP0kVim4PpSj Dg4oNJUe2QNqMKu91VQ2vvDDm7LJQgkyYmD6vELE= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=6gbrjpgwjskckoa6a5zn6fwqkn67xbtw; d=amazonses.com; t=1742451365; h=Message-ID:Date:MIME-Version:Subject:To:References:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Feedback-ID; bh=kYXirL6T5SMEuGYUdunqxwrHTUFx7O+Ivnu0IG9v0AM=; b=hkMRomqrxr1e+6gOxmfEU2POInScdLWEe8p6WyU80C6mulOUVgLT11FJEts7flFT QfVkSbhArMv4QvQ7Cc2jLPMYdLKnzmA8Q5Mk54v0blrm1skCbrOIPev4N5RS8D+LoZF lhSr3xej0FAbLgof1UzDw93dlCphoEhJ7zh+ObzM= Message-ID: <01000195b231d607-260ae5cd-6a59-4187-b9c9-9029bf20f91a-000000@email.amazonses.com> Date: Thu, 20 Mar 2025 06:16:05 +0000 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 9d0eea9422d0 - main - Make newly POSIX functions visible To: Stephen Hurd , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202503192345.52JNjFxt093046@gitrepo.freebsd.org> Content-Language: en-US From: Colin Percival Autocrypt: addr=cperciva@tarsnap.com; keydata= xsFNBGWMSrYBEACdWRqDn3B3SKO7IG0/fGHYtfs26f3Q5QeAcasy1fQLniwGQWn5rlILhbCD K/jdNoDm5Zxq20eqyffoDNObCjnHgg4tGANdi+RmDy+7CDpE789H8dss9y7Pt5DlGGAXQQnt hxush3EYS/Ctprd9UUL/lzOOLOU1aNtzB84tNrJBtcJmL7OYHfyTSNFxvedqJrrasejIQOLI t/DQ89BPzz+vsKHz7FJPXh3fsVkzLA00DJYcfkgxyABfJNA7U6yMwd4DVSdx/SsvfIDMVXnu UXCXswo106WPZbYGlZPpq0wW6iibtTerJix+8AeuwXvl9O1p8yESK4ErkIxCnmghTSz+pdzj z/6xBRkdDM9VdZ0r+CzsaNXMpDOzFuKyjaiYBdgCLljbDnXIHFcqXenrZ7Xwkm09g/M4uVSh pIUG2RYa6tsHSQoGCp3f2RZv1znfViKQFbbL83QjtPA20AhseZSYbHp1FPhXyy9J0wkGL16L e99g6gdGeIRE82BZjBjKGDkoyDPq+oDRSFl8NtzmIKy+cfz00nViqcTF4bREXEawFGhlpO0X O9q8mijI9iFB6zaPBiSdJGBL5ML5qLTNCl8Zlf4m1TBvmRTqF/lzMHVXHidDoUhpSh/y3AFZ 1KrYc27ztJQywDJPJPWPbtY8YhFLFs377gfP8WldsZjzp8nvoQARAQABzSVDb2xpbiBQZXJj aXZhbCA8Y3BlcmNpdmFAdGFyc25hcC5jb20+wsGRBBMBCAA7FiEEglY7hNBiDtwN+4ZBOJfy 4i5lrT8FAmWMSyYCGwMICwkNCAwHCwMFFQoJCAsFFgMCAQACHgUCF4AACgkQOJfy4i5lrT+i Yg/+PYyJNoFuygtV5t/skcjYmvEC93mnazEvh+x99vGYZnGKeJ8NDOF4QCUzeHquOWxDi8Zl reXyswKcrIquPxxX6+YyGe97VbvLnez3ksfzOYRj1F4qV0Rq8ZNK51+bvIrbcS3SfDaRioAk D7WWwFor8y/hSwxYkfsKbtP5PRcem20JUxuC085zqWLaKv5t5n2CBzAGMjwJaQ3tM3AXVwWJ uJaHA6ot/6fntJlmkfcyCYyyr0D6b0guRj3STbZ2hNn5o2AI+f6LJJ31s2sPFjl6rs7fORf3 hFSNOHDd2HxfVBXFdQy24ROkC4orBBz2xh9GScjxxT/hbXkfufkubFubw7n0HkvHzA3UF+Qq A8JiI3n+d7ocsP0/5BQ2sZdeqPGJgHx6RkAMuW1tJ29wSvCN1qMgFwhYkpQdfvHlociQrimU fvlRfSrBEe8o7tvIuEdpvwvCZSTJqQbVoMw8UHFE7nzyCXUSab5h6PbjakCqim13ekVO2KFF TTPcz5o5jEeUY75tzbIwcDfFbT5KqNjWy06TVdM9VEJDHSfOfxHR3kSEwZ+tT2aTvL3grsUn gFwSNcj4Cl4CRFfUw8zVZY+7O7RiMlhBqykikvUurrdGKc1Scwa0yuppdA6eVvylyTWSQGrQ +uLWtV1LUKN7ZqKJWBkLPt9nS4XZWGyBvxOHYqjOwU0EZYxKtgEQANYfgbtUMVnhjxDHhWLp g5kLHK3YW0TfJKzpXqDB7NiqxHofn4OcbZnVC3MKggcbs9o1/UtsjnlsG8550PfiYkDXvPiO RJwgbGs6MGIDK797C6cnBLQ8xwBa9SL4cl5iQFnhWmt6vwnJ+an/cm5JpYves3wL7jV09qU9 57hkHXEUcl38r4FssZzVcLKPUVTa3Un+QGRTGDGe/f4ctjMaqv0ZCM+l2ixPhf/vqESrfSLv V/+T3dmtUfXjazO3SABvsHwxgGuTTYOlKoPCaebr+BRdqm0xeIShoIlhvTI8y4clchqx/Uxg UG5X2kvU13k3DS3Q8uLE4Et9x1CcZT6WGgBZSR6R0WfD0SDnzufNnRWJ0dEPA2MtJHE7+85R Vi9j/IgZV+y5Ur+bnPkjDG1s2SVciX5v9HQ0oilcBhvx0j5lGE9hhurD9F+fCvkr4KdbCknE 6Y8ce8pCNBUoB/DqibJivOzTk9K9MGB5x0De5TerIrFiaw3/mQC9nGeO9dtE7wvDJetWeoTq 4BEaCzpufNqbkpOaTQILr4V6Gp7M6v97g83TVAwZntz/q8ptwuKQPZ2JaSFLZn7oWUpYXA5s +SIODFHLn6iMoYpBQskHQjnj4lEPJadl4qj+ZKA89iDAKsniyoFXsbJe2CPbMS1yzBxKZq6K D/jpt7BOnuHr/JrXABEBAAHCwXYEGAEIACAWIQSCVjuE0GIO3A37hkE4l/LiLmWtPwUCZYxK tgIbDAAKCRA4l/LiLmWtP3jmEACQrh9gWe8F1Tkw3m6VoHKwLc5he4tX3WpQa//soPO6iGG3 S3WPruQ46NrAaAojoOcKI9UONDO5rxG0ZTX53S+lu2EO47jbcLwOCjaEpjKpDRt9ZXBQE8Xl mtBE9Bp3W9gpjB1nE3KNM1mJYgsK0QdRpwwfh4pVgGpOj8j23I6MCK+v99zEBnpgCn2GX8W/ kctRXHqWwndHysOJtRP/zrl7dDaABF1f9efUl0LL3TD3GJ9VDz+DNOin/uK2a1hiJo8QzTRk PpfUQ2ebzDsrd1i/pOWkMSkdH+rEu4AGrXWtaBwrMyrGkL6Icb6yO+P9/z0W2wlgBf3P1YRt JPgQt/Dj3yvA/UnaV/QmuVQPjl13o24UnJGsZM8XGnNdfWBKkC1Q6VXC4QT+dyBHYH9MuE9d 6oGl8pFM1+cTfEfbM62/rRoPkF1yHMsI/903VxEvuUIKfhEZAVLFyHldooNxuchntHQP9y8J 8Ou9bWYQP7MnEn+kwSwrZkjurfPkan+xQvp6dDYnj3V0GwA5pprBMaB928VIDVOv+1PNQI3t Cvk5VPv/skq+TJRMHW7bFSt8PRa91cUf1FOLIz9APDiJOzXkwxUEHGV3zPSaUhs1JYjyBeGT wDAvtLUdjOnRhEUOwlnIrztmvyciutjJoVzKEEjj5WXnHk9L9kQ1bpAjkjTONw== In-Reply-To: <202503192345.52JNjFxt093046@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Feedback-ID: ::1.us-east-1.Lv9FVjaNvvR5llaqfLoOVbo2VxOELl7cjN0AOyXnPlk=:AmazonSES X-SES-Outgoing: 2025.03.20-54.240.8.13 X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:14618, ipnet:54.240.8.0/21, country:US] X-Rspamd-Queue-Id: 4ZJFh65sR5z3C7l X-Spamd-Bar: ---- On 3/19/25 16:45, Stephen Hurd wrote: > commit 9d0eea9422d075c8a6924b33161d2d5abfb4072a > Author: Stephen Hurd > AuthorDate: 2025-03-19 23:45:06 +0000 > Commit: Stephen Hurd > CommitDate: 2025-03-19 23:45:06 +0000 > > Make newly POSIX functions visible > > Some of the POSIX 202405L functions are already in the system, make > them visible when appropriate. > > Reviewed by: imp > MFC after: 1 week > Differential Revision: https://reviews.freebsd.org/D47859 This broke lang/python311: > --- Modules/posixmodule.o --- > ./Modules/posixmodule.c:12907:9: error: call to undeclared function 'setresuid'; ISO C99 and later do not support implicit function decla > rations [-Werror,-Wimplicit-function-declaration] > 12907 | if (setresuid(ruid, euid, suid) < 0) > | ^ > ./Modules/posixmodule.c:12907:9: note: did you mean 'setreuid'? > /usr/include/unistd.h:458:6: note: 'setreuid' declared here > 458 | int setreuid(uid_t, uid_t); > | ^ > ./Modules/posixmodule.c:12930:9: error: call to undeclared function 'setresgid'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration] > 12930 | if (setresgid(rgid, egid, sgid) < 0) > | ^ > ./Modules/posixmodule.c:12930:9: note: did you mean 'setregid'? > /usr/include/unistd.h:457:6: note: 'setregid' declared here > 457 | int setregid(gid_t, gid_t); > | ^ > ./Modules/posixmodule.c:12949:9: error: call to undeclared function 'getresuid'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration] > 12949 | if (getresuid(&ruid, &euid, &suid) < 0) > | ^ > ./Modules/posixmodule.c:12970:9: error: call to undeclared function 'getresgid'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration] > 12970 | if (getresgid(&rgid, &egid, &sgid) < 0) > | ^ > 4 errors generated. > *** [Modules/posixmodule.o] Error code 1 > > make: stopped making "all" in /tmp/ports/usr/ports/lang/python311/work/Python-3.11.11 I realize this is almost certainly a bug in Python (assuming that these functions are available without setting the right POSIX level) but if Python has this bug I'm sure other ports will also be affected. Please back out this commit and talk to portmgr@ about doing an exp-run to find out what needs to be fixed in the ports tree before re-committing this. -- Colin Percival FreeBSD Release Engineering Lead & EC2 platform maintainer Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid