From nobody Tue Mar 18 17:03:56 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZHJ8Y2VSCz5qx1l; Tue, 18 Mar 2025 17:03:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZHJ8Y11sKz3CZb; Tue, 18 Mar 2025 17:03:57 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1742317437; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=42NbsdnG432ikDASUeXrYnqJ1lZBuipdKbO5CPzFSms=; b=rpq04UtpRfECh8d7+f17URNxf0SkWC68TOfRJGtjlURf1E/r7ZHFRVpsJZZF4bPnih7y3H 2l2Uf8ZVsIIkIPsyimEqglVMs0woyrT31YYLnvUTEj2iifw/ZJEz69ykpQfhSeqjeftdnw ImBGGddynnHBXmeofc2CaFwKe8vBcSf8k1BlgGUpGZBRZCGS5zCHnZl6aAa8+SSYqsb7Um qUBWH/NtTDjO8Ba/FsWQmNLx2wJkCQ1HJIw4Fgm/KSg4jNCkd1PuEfN/BCrj3DfL5llbg7 +8SkHTt0/g7kDvnMSOlxT7AmqyUbezuzDVawlmH+k0LDpWCwyCRaGXbFOlU1cw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1742317437; a=rsa-sha256; cv=none; b=aY47Rk5ellbYCy7/Rmlxwl6wRgY47Qehdqn1F/KEKI/Vgp2RJrFrofAYhBxJZiGcGyan/n wDTBmd+dLWzQRhWUO/GzvU/Thrx/tH5XuY2083Y846l3TZfNuXVf5rCqMW4jHB5SHjiRXb 05iAMKsEWCMSbI++AYv9z4qNw4QWYfAvO+sQdcB0EUBrZkXf53Fa9jVlrw43uyLCGOoOZG XsWgGgwYGbO9Vwkcae70Pcj485juFnWu0So4qK1XlMxSWBCosRYKnN7fDx4Cz3pC5YvHTG WPzg81Wcoz9xKYDo7vLeZ5uoTg26YZ4554OVDbiFh9R/yTsLtZjQQ01gTgWQew== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1742317437; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=42NbsdnG432ikDASUeXrYnqJ1lZBuipdKbO5CPzFSms=; b=MU8xBUUip+5dL+nQomwf8sfCe6iQY/tzW7A27rdUrNZJIGgVs53bIsdzq+yHCt5pYpu0rC kemJmCwYPnG6/3y6JNWEoSF+JImnsVqBE+x/l4ojwJhu8lXNULBtFDZg0kNYrE3UhfVk1V izc4Dn0dtJ4GnD4ZtDF70SW7tWMctE0oh8XBITX3PceEGfJGLrMOlZkVUkcZiZ3RYudL1n QLR/NQnp0++NV1j+MxArh/sJXFoYcjzTuz+ejENcG79X9h2vGid2gLtHgF6AuxGl92eO1O fYcnJdHtvmfD/HBAQRcswIu9jQurOXjBxgcSz0be0lBKboe6IqWZzeseyR1zyA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZHJ8Y0XbMzj1x; Tue, 18 Mar 2025 17:03:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 52IH3uNL040399; Tue, 18 Mar 2025 17:03:56 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 52IH3uG3040396; Tue, 18 Mar 2025 17:03:56 GMT (envelope-from git) Date: Tue, 18 Mar 2025 17:03:56 GMT Message-Id: <202503181703.52IH3uG3040396@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Stephen Hurd Subject: git: 0f684b5aec50 - main - Disable HS200 on rockchip_dwmmc in attach List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: shurd X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 0f684b5aec50b4766dc2a8f010fd7b9568af5063 Auto-Submitted: auto-generated The branch main has been updated by shurd: URL: https://cgit.FreeBSD.org/src/commit/?id=0f684b5aec50b4766dc2a8f010fd7b9568af5063 commit 0f684b5aec50b4766dc2a8f010fd7b9568af5063 Author: Stephen Hurd AuthorDate: 2025-03-17 07:16:53 +0000 Commit: Stephen Hurd CommitDate: 2025-03-18 17:01:21 +0000 Disable HS200 on rockchip_dwmmc in attach HS200 mode requires tuning, and there is no code to perform this tuning at present. Until there is, leave HS200 mode disabled. Reviewed by: manu Differential Revision: https://reviews.freebsd.org/D49400 --- sys/dev/mmc/host/dwmmc_rockchip.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/sys/dev/mmc/host/dwmmc_rockchip.c b/sys/dev/mmc/host/dwmmc_rockchip.c index c4b07ac3290e..656e9a9cf09d 100644 --- a/sys/dev/mmc/host/dwmmc_rockchip.c +++ b/sys/dev/mmc/host/dwmmc_rockchip.c @@ -78,6 +78,7 @@ rockchip_dwmmc_attach(device_t dev) { struct dwmmc_softc *sc; int type; + int rc; sc = device_get_softc(dev); sc->hwtype = HWTYPE_ROCKCHIP; @@ -90,8 +91,17 @@ rockchip_dwmmc_attach(device_t dev) } sc->update_ios = &dwmmc_rockchip_update_ios; + rc = dwmmc_attach(dev); - return (dwmmc_attach(dev)); + /* + * Note: It's not that the controller doesn't support HS200, + * it's that FreeBSD doesn't support tuning. + * If someone implemented tuning, this could work. + */ + device_printf(dev, "Disabling HS200+ (tuning code not written)\n"); + sc->host.caps &= ~(MMC_CAP_MMC_HS200 | MMC_CAP_MMC_HS400); + + return (rc); } static int