From nobody Fri Mar 14 05:51:52 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZDYQw47Y7z5qZq0; Fri, 14 Mar 2025 05:51:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZDYQw3bCnz3Hn9; Fri, 14 Mar 2025 05:51:52 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1741931512; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0YZjlSvLo24Su3saY/VjHsPDvwQoliysCuKtRIeumuE=; b=jr7/hSuMXCVtkGKJcyr3Pq7EBWhk38FXO1Z/MPp9dEfB3fgSjw1Cm9R6tDs0ohRdfuEaRg SLQcKA+TXSXLjrs+3CKzlYFnsiRK6Ondu5pTZaAMgTzPd4mhonmPbsVbEwszKeX0N9G+lW UHYPnROgbUZ4SOqKmCRbhbFi3BmswdcyEcyq/9nXiUUDM+/71acWdy2r2PYHeEmzw4/8Yn FVleEJUxt/1nWdePmntLju3adLavbea7cl3zsGaCAXz2YiwJOaICQRAJQ+d8Tft3JDhWj7 eeO+F3Kf8wWPtLyCoiW5P47YcaCVLXvjNcL0Xp6LBtWprAUpTMtTVKmPfDbe1Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1741931512; a=rsa-sha256; cv=none; b=BvNHmvjVSdGrcJ5rSb9FAdvTvJTLUXx1SxNZ/yoYr2fuGXdHaLM2MPsEnQ6tTz4hxoqo/V eL11KyoDjnHytx29lxzTkKz4hUs5Y3geqOTl7sbAScseE5cGsrUua/OqjY9jFDVNT7hw19 D5Z6ezVJEf45XDFFGkYe+C/PvDy8sAolZVQ6oXCGMEuZmIUd+zEAWYDTRIoZodXYPZfctk A6g58xBnBTEEnlh+zUt7g7i2Hoebo+EglqlZ0prEsMsoRMrnr+EhT/lGkKMlajYaAEvfXt VzoPVtIR/VVHtVZhyVMfmpzM2ibpPAjCXX3Y7LrHJrjs+SlzZo3TnanmH3dkhw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1741931512; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0YZjlSvLo24Su3saY/VjHsPDvwQoliysCuKtRIeumuE=; b=ve++VKRT6YHUZZw5+4iWaaMXtcVf3EzHftkYnc+y1TSY9tQ2eUAnC8lAVkDlGG97xMoTRx YXIw4QflAwmjF9CYxNXS/aBXAECvt5DH4J/XaJwCdhz7xVGlUrmbLswuUA5qovkFst7mZA KJrHpLa1y06K+/bPk6jBtkKctrR5g7tY0W16q04H/VJlEfADEhh7hwbActS4dAEAEmvc1E FEvfc8qON8PkSnHaIo/8jG5Jvq9IofQdkvsy0NTEm4IRDH4V9EySBRy008PCMJTZeiunhe 7xgOL3pyTYaBiaJh2OB5l55DVPoqgDgaHj6LACTBdEHHkY4askseeW/So6zVew== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZDYQw32Z6zXNn; Fri, 14 Mar 2025 05:51:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 52E5pquY003249; Fri, 14 Mar 2025 05:51:52 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 52E5pqTW003246; Fri, 14 Mar 2025 05:51:52 GMT (envelope-from git) Date: Fri, 14 Mar 2025 05:51:52 GMT Message-Id: <202503140551.52E5pqTW003246@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Wei Hu Subject: git: 47f4137e44b8 - main - mana: remove redundant doorbell in mana_poll_rx_cq() List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: whu X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 47f4137e44b8079c7784604d220a298db07a19a1 Auto-Submitted: auto-generated The branch main has been updated by whu: URL: https://cgit.FreeBSD.org/src/commit/?id=47f4137e44b8079c7784604d220a298db07a19a1 commit 47f4137e44b8079c7784604d220a298db07a19a1 Author: Wei Hu AuthorDate: 2025-03-14 05:26:45 +0000 Commit: Wei Hu CommitDate: 2025-03-14 05:51:34 +0000 mana: remove redundant doorbell in mana_poll_rx_cq() With the last commit to refill the rx mbuf in batch, the doorbell in mana_poll_rx_cq() becomes redundant. Remove it to save a few microseconds spent in mmio call. Reported by: NetApp Reviewed by: Tallamraju, Sai Tested by: whu Fixes: 9b8701b8 ("mana: refill the rx mbuf in batch") MFC after: 3 days Sponsored by: Microsoft --- sys/dev/mana/mana_en.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/sys/dev/mana/mana_en.c b/sys/dev/mana/mana_en.c index 94cca4fa50c7..949b498ceadc 100644 --- a/sys/dev/mana/mana_en.c +++ b/sys/dev/mana/mana_en.c @@ -1890,13 +1890,6 @@ mana_poll_rx_cq(struct mana_cq *cq) mana_process_rx_cqe(cq->rxq, cq, &comp[i]); } - if (comp_read > 0) { - struct gdma_context *gc = - cq->rxq->gdma_rq->gdma_dev->gdma_context; - - mana_gd_wq_ring_doorbell(gc, cq->rxq->gdma_rq); - } - tcp_lro_flush_all(&cq->rxq->lro); }