From nobody Thu Mar 13 16:54:11 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZDD9c0qWzz5qw2y; Thu, 13 Mar 2025 16:54:12 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZDD9c07pFz3fKg; Thu, 13 Mar 2025 16:54:12 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1741884852; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=23aYerT1+06mcKSfJS36bjqTg+8NhqszRJpLkS8+gq0=; b=USKRCkNwO5tTqw9nsU/CQl5b6H7dl02vKMyMSMqgkYY0g+2379tbmFs95TTzcxNCu1AvRp JO4FfAcC4Yo5VUwNqGvwAPBLEjjciSN6d6q3h/d7C+xbXmYUplxNJbSxSl8O4rOKlmd0+y xhGsSKZ3NsFC6gCZD4nuUqDbGzUQzc9dPW5KqBwfJu0jfNy9oviHnm//W+WxGrnbNRclpD 7tVFnIQCn1ngQQ0TBmkUfRMlHrf0+1eTnEM49SMi+AIRWq3QoZqXKycX8mZOt3JOg6BSlS cNfJ7ncCRvd3oF7zcz6fVKPkdt2sVyGUr/scGnBYJgEuJpKXKdkQZwRpDED9vA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1741884852; a=rsa-sha256; cv=none; b=BHKi4WCT/HWjPasPtYpesnfmyHYWecRtapezgDEAxTm+i0OvPgogAySOcnxYVPO+ij2WFb /CoOi3QRhWdhcBFgx0pFqmtMi4t9PvM+iffFlzFAp7TJD3cgewW2PH/bPGVGj1skmlZjvK tDiDL5/DYF5FyPrPyuwErMNme2cWSJ7+fBj+AxkLb1UzX3JP+Kk2fMIGqNiyYuo4pphdyd r+3kQQGMU4YChhc79H5iIjdLxCTBdTfjlgfIy2MH2KIsrZ0ZpJsdoqJK5yJXY/FHv1vIkD v8nYaXqDV3tSJfTGFN2YvN0kgqM02L0eTvLYV9hRYbEqd65/lncmjJnXmZgBug== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1741884852; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=23aYerT1+06mcKSfJS36bjqTg+8NhqszRJpLkS8+gq0=; b=sNwf3y38POjxwzk/73Wl1VyRl3Zl2gRmk2itXFYiwu/yvMeDKvKu5faItjwMrLpyNuMvkf mAI2dpuAj6PwM8yFnyeLogKW6FLmXc//EP72vEpLB6QJAydHusQHaWbLlWm5ov8RTQdrxh Rt19oaghTBi40NCsClW0TVPU/DZjYAGCNaMLqlDIwTiKXA9QwzT/JMGL9VQ96k69iGWTEt g5EvBk6XiC2X5McfGumdJYPICHLaMkI2AqdyjRZ5SYb50OAN5psqBjEBGLahHnAoocZBx2 gsq3/pparVr8SWe85pS75FJA7iHUaD7EyOfJhUXN1GU4/OpATIF0cu9wm9PKPw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZDD9b6NQqz15QY; Thu, 13 Mar 2025 16:54:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 52DGsBmu043678; Thu, 13 Mar 2025 16:54:11 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 52DGsBSc043675; Thu, 13 Mar 2025 16:54:11 GMT (envelope-from git) Date: Thu, 13 Mar 2025 16:54:11 GMT Message-Id: <202503131654.52DGsBSc043675@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Gleb Smirnoff Subject: git: c78a14a2b872 - main - inpcb: in_pcb_lport_dest() doesn't use lportp as input argument List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: glebius X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: c78a14a2b872b0f82326d5bc00ec99513b3961e6 Auto-Submitted: auto-generated The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=c78a14a2b872b0f82326d5bc00ec99513b3961e6 commit c78a14a2b872b0f82326d5bc00ec99513b3961e6 Author: Gleb Smirnoff AuthorDate: 2025-03-13 16:53:40 +0000 Commit: Gleb Smirnoff CommitDate: 2025-03-13 16:53:40 +0000 inpcb: in_pcb_lport_dest() doesn't use lportp as input argument This assignment just created false positive analyzer report. CID: 1593692 --- sys/netinet/in_pcb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sys/netinet/in_pcb.c b/sys/netinet/in_pcb.c index 47852a8cda4b..a14792649519 100644 --- a/sys/netinet/in_pcb.c +++ b/sys/netinet/in_pcb.c @@ -826,7 +826,6 @@ in_pcb_lport_dest(const struct inpcb *inp, struct sockaddr *lsa, #endif tmpinp = NULL; - lport = *lportp; if (V_ipport_randomized) *lastport = first + (arc4random() % (last - first));