From nobody Thu Mar 13 16:03:15 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZDC2r4TJLz5qrn1; Thu, 13 Mar 2025 16:03:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZDC2r1JWQz3Qb9; Thu, 13 Mar 2025 16:03:16 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1741881796; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+J8BrH0C4eEsiTczf0nEqulfJd2R3bT9ZCTABl6q440=; b=H/KYBeq2FwUEItZHDlvTja54kSSJ4SAdCgEHt5qpiAImWAdJ4nKjflNOM4m8DyeFl40hN8 8zswBw2yWOeRMoEAIIBSiXe86ClnLeqqxLRfujlv3Wo9FKb6oeo/elBbLdcUmziYWUbCiw EZRz7K13TQ/r32rxdy8HBGlQzRkxHeHIWfJAhE89cYInQbfELhGXLZHYebETmZjAjoHmDs L7y3ZqIVwHcMGnva0bSrKKQSa3VrrQNakNrFg3GQDf/qkarkix6yj4aJoN+6iGJcPMWamI S2BphbteguLeh4slc+XJLRu0tOOW9xPn+wWIvnyM+FK/eNdai1XBiCuScUPKmw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1741881796; a=rsa-sha256; cv=none; b=XyI1d/t9RQ7KFG7Oe+tkU2JphHcaTZVohsBDxZ8cT66qvo27VpYCE99MGtMZw9JXLDTfn8 1srxHYBm+nIMozbkNdXKyU+vHp02wkVbsTFiL4ujO1TXPlfWPxGrGUGHJf2031IWyd48Sd 2/mx2Ukab+ErdojehHYJSZGCaWwmN7uZFp30sc98LUG2kGFiF/L1oP34E5f3R9a0EsS+q9 V8i1N0c8nlOPxzVyZNWShqaaFB4hdSerAtAoRxlAn+ELLjBseEkmchZHtyc3Io+XjQvg15 39rhaX6HBjN3POgyUm/NFKFbFCCO7DKKQIpZL9kUbbWWtsSHeEk2pzjmhJiMag== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1741881796; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+J8BrH0C4eEsiTczf0nEqulfJd2R3bT9ZCTABl6q440=; b=rFqWKrhJnFfye0bMRiDnTjEc83rnEJJANPccQeG7ICEV2Wx90lHcPSfiCTdJsIYvmH+++S LcmjzdVH0p9P0ufzXMQt/VoRUflJ01My1BdjEUvBC19fV+0evpEik66KYg1UZ7wh/ucc1O Ek6lSV5Fq0GZbH4S9bphgjarjWBf0Kjja/7EAEeTFb2Jsk2VGOAxWoO7Q/b/921l6pfU8E 9MQH/kqnI9SJ5IRBWJBjUw8rg0o9xCCJVHkZXsf+elJfF2LKSAkZj/jvYC4w9m8n5w3veb g3Ki2lDk5/wunEM9UzJ3g4vC+1E5svWU72WoBXVbw8g1dRejcBBxi03GQGKNbA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZDC2r0hDFz14QD; Thu, 13 Mar 2025 16:03:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 52DG3FBB048598; Thu, 13 Mar 2025 16:03:15 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 52DG3FOe048595; Thu, 13 Mar 2025 16:03:15 GMT (envelope-from git) Date: Thu, 13 Mar 2025 16:03:15 GMT Message-Id: <202503131603.52DG3FOe048595@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: c3555174fd97 - main - mlx5en: follow PRM for setting the max hw lro segment size List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: c3555174fd97ce12682e5ed1e2d2586016962a8f Auto-Submitted: auto-generated The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=c3555174fd97ce12682e5ed1e2d2586016962a8f commit c3555174fd97ce12682e5ed1e2d2586016962a8f Author: Konstantin Belousov AuthorDate: 2025-02-05 03:05:35 +0000 Commit: Konstantin Belousov CommitDate: 2025-03-13 15:59:27 +0000 mlx5en: follow PRM for setting the max hw lro segment size If the NIC is capable, just pass the full packet size, including L2/L3 headers, as the segment size. Otherwise, decrement the number of strides by 1 to left the space for L2/IP headers, as it was done before. But do the arithmetic on the segment number instead of the full packet size. Reviewed by: Ariel Ehrenberg , Slava Shwartsman Sponsored by: NVidia networking MFC after: 1 week --- sys/dev/mlx5/mlx5_en/mlx5_en_main.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/sys/dev/mlx5/mlx5_en/mlx5_en_main.c b/sys/dev/mlx5/mlx5_en/mlx5_en_main.c index 321ed8ac9976..d69d2e433c9c 100644 --- a/sys/dev/mlx5/mlx5_en/mlx5_en_main.c +++ b/sys/dev/mlx5/mlx5_en/mlx5_en_main.c @@ -2947,10 +2947,8 @@ mlx5e_get_rss_key(void *key_ptr) static void mlx5e_hw_lro_set_tir_ctx_lro_max_msg_sz(struct mlx5e_priv *priv, u32 *tirc) { -#define ROUGH_MAX_L2_L3_HDR_SZ 256 - - MLX5_SET(tirc, tirc, lro_max_msg_sz, (priv->params.lro_wqe_sz - - ROUGH_MAX_L2_L3_HDR_SZ) >> 8); + MLX5_SET(tirc, tirc, lro_max_msg_sz, (priv->params.lro_wqe_sz >> 8) - + (MLX5_CAP_ETH(priv->mdev, lro_max_msg_sz_mode) == 0 ? 1 : 0)); } static void