From nobody Wed Mar 12 21:15:52 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZCk203LwSz5qVb8; Wed, 12 Mar 2025 21:15:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZCk202KL2z45Jf; Wed, 12 Mar 2025 21:15:52 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1741814152; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=wI9Q60ywO6NwQxbgTeHMGgiwGfvkO9AQybBVulEA+qo=; b=Wd7K2ZsAGVJmcjhwFW/zlv0a2aPnBzEoGjvH77DIn9BryN1yuS9AeFcpvIZx1Y5iVNL2pr alI070xthPC79RBf941dbxnw/drO9Jhxgt9cSiJViKqoitmONUWUvnG2pJPFICWGWSQ5zv nGSJpKFyeQSscB4kG+nOwDzlf7c4SNrfa4KvCXxxb/KPC7GrNvqWfTVRgL6fhGc5B1KvRD cQuo5qDFC6vcYKbm3/jP+UDlojL3Gg3dXP+FVDmUhrtcMGwFDrfFDkyvTvpPwVrQOmWXSH hMLONjoxXw3SnywfrqkM/858XFMav7+wZw/JKeMRx6zDBBfnKkg+SZ3qHH+yMQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1741814152; a=rsa-sha256; cv=none; b=anq12Fzi233ENdMna5Gp5k2FLUgX1OPNHyOZYfqp6zwXzyOSPwEpV5yETdF/hkH2LHI3Fp lOtCxW2jEk5wLGLJZiXS3pjBofJpq25MkslWyC8CQDlQxooiNGfg4/SU4QbzU6YZolphfE m8LR6pFl3j8igl3esPsiXXD/YY3XsQa85GcjbuDrvZIUQ9Eh8747GR5OgHPCoRWWmCwN/M S12+XG/XiKqpjWGV/Pb0KDg0aKALYyjHq36G2XHuiVJVvhBWDT07/z8O8p77HquUcTYlne WO24e9d1/OSv5AJPSxPXTe//MX+WIpV2zSnFfTq3ajSGrBajQss6Gvja2eVzZA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1741814152; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=wI9Q60ywO6NwQxbgTeHMGgiwGfvkO9AQybBVulEA+qo=; b=rV4iTO/w6RZqMrGgUtlwfjO1WTJomwIy2ROZxiaF2ZSoX+kutOo8kltKxfmHxgaZ3jYz3T XTcj06ab/9ik/j4xhj8MKbZZOoABswy759e1szWipQg78viy9qkrVuk9LbpiAZi0b95y2v bjSEhs25OwLHp/TSdSm1YPvkakg+Zl+8ee5VK3JsQ/s/oBZg8oiwAOGrdA0Ad5f2ytU26D NguPA2hRYS0WmCDT8weNoW2RQM0nsCZK9zDVQcAagv3/793eQbHbr54xmw1gjejc2W0GcK uF/T/tl6gOdlnLSjeMqCa7Ou5uB+e8+pImKZv7JD1EAzKlsJBlZE7MZTlDilWQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZCk201sdqzCvD; Wed, 12 Mar 2025 21:15:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 52CLFqSN027179; Wed, 12 Mar 2025 21:15:52 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 52CLFqoM027176; Wed, 12 Mar 2025 21:15:52 GMT (envelope-from git) Date: Wed, 12 Mar 2025 21:15:52 GMT Message-Id: <202503122115.52CLFqoM027176@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Christos Margiolis Subject: git: cabf76fde836 - main - sound: Remove redundant check in mixer_clone() List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: cabf76fde8368222a68865953521e1c3668b5298 Auto-Submitted: auto-generated The branch main has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=cabf76fde8368222a68865953521e1c3668b5298 commit cabf76fde8368222a68865953521e1c3668b5298 Author: Christos Margiolis AuthorDate: 2025-03-12 21:15:34 +0000 Commit: Christos Margiolis CommitDate: 2025-03-12 21:15:34 +0000 sound: Remove redundant check in mixer_clone() PCM_REGISTERED() does this check through PCM_ALIVE(). Sponsored by: The FreeBSD Foundation MFC after: 1 week --- sys/dev/sound/pcm/mixer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/sound/pcm/mixer.c b/sys/dev/sound/pcm/mixer.c index b5b5814e667b..7bd0a2e14c46 100644 --- a/sys/dev/sound/pcm/mixer.c +++ b/sys/dev/sound/pcm/mixer.c @@ -1365,7 +1365,7 @@ mixer_clone(void *arg, bus_topo_lock(); d = devclass_get_softc(pcm_devclass, snd_unit); /* See related comment in dsp_clone(). */ - if (d != NULL && PCM_REGISTERED(d) && d->mixer_dev != NULL) { + if (PCM_REGISTERED(d) && d->mixer_dev != NULL) { *dev = d->mixer_dev; dev_ref(*dev); }