From nobody Tue Mar 11 14:04:45 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZBwW22Lbhz5qbyD; Tue, 11 Mar 2025 14:04:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZBwW157V5z3r2b; Tue, 11 Mar 2025 14:04:45 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1741701885; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=wQmS0vAF+1fixHm9r6SJXDHqXx5qX3Pw0BFPvIYpk8M=; b=oYS+PEkUC9QSqrHahMdFjwCVAb8R42mzK5/MHeEnXNt7SmCMilIBaPPyxOAgIUtv/Nq0Y7 PHajpJclh3XHBjWoghMhc5EZ+FO5tuEji1X5NlPVOAxbybfeoclJYtQa6yExZk/w3dU06p aJP8CiXOzyOFt/SYhRRsxNvWLNAaYl4YdWvIdSElT2zp98PDUmxLOxiPW4FlrVZXS3XkCS vuTYVUnSRRnRq8+z/uFQRMQvivHOHisLZCOYUNjgLo042sgp+ymzS2o8rNFT6HM+w88ZRM r7fv/FcfhHS9lVOR2z6xMd7tEE+FADGZ1J0i97gAXPS5uW94FkzxgT1EPUwMKw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1741701885; a=rsa-sha256; cv=none; b=G2yGNgtVVizFhrJP/IxA2XtzR4ytivT73lmsFNuYhCHQApKcWksipOhFCMwa7QqNGgufFf eLXlENSqK/hRyUBtVnE9RDEf/U7fEwFDzC0O65nIJg7MECiL4mudbg9swf4SPll3L9x7n5 WHdYnsEYo+r1y6N58yqoFSSG3HwkQ+UAOeNaPEp6r87fUgeIoRbFCC/VmGahUDXDwaCmmO tr2Nhdm/IVBIrI7RPDLNJsUtXjOOiW8ADfzWbQ545iRuw/Wf7G9GqUjv0cNULm05lWyrRn MbKN/qzUp0IopnMIwjsA7GOQz0B5xO356BglsS4BvdHjnhCvDODBHDibSn2cHA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1741701885; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=wQmS0vAF+1fixHm9r6SJXDHqXx5qX3Pw0BFPvIYpk8M=; b=ZLV2+OfBSHTh9F0ZTeuqB4dcUWbbuc4xtlQBUU3c0bzN1XqbebMPwg/MSBWx4MZMA3B0zv 2c15rLRlXFOyjUx8gqQXdckbAQogal0q//p5+IdWlNKHoTYLcRyn5jTD49W16y5m3zXiHH Zl/gNWNDiEXmFmnnk9q1Kgqa//GNzMvCKF81KuikmjQJEOgOp4+mQBnTPNQ/EHH0rPP47B kVaahAkuSGubIadeHpQvODmQSjpEgXaqSKfNiRwfM6BqygWvFk1bc6TpkPly8Baj4KtXvh uYXqsVMIBY3DnThLdKBVX05xXz5+QckacgocNxspNVuNw5tI/jF4AkdKmbQ9lQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZBwW14bLDzD3f; Tue, 11 Mar 2025 14:04:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 52BE4jba028871; Tue, 11 Mar 2025 14:04:45 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 52BE4jod028868; Tue, 11 Mar 2025 14:04:45 GMT (envelope-from git) Date: Tue, 11 Mar 2025 14:04:45 GMT Message-Id: <202503111404.52BE4jod028868@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Olivier Certner Subject: git: 7f005c6699f4 - main - libsa: smbios: Use 64-bit entry point if table below 4GB on non-EFI boot List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 7f005c6699f429c2f762b4dd8fb39b3bcf5378e2 Auto-Submitted: auto-generated The branch main has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=7f005c6699f429c2f762b4dd8fb39b3bcf5378e2 commit 7f005c6699f429c2f762b4dd8fb39b3bcf5378e2 Author: Olivier Certner AuthorDate: 2025-03-03 21:10:25 +0000 Commit: Olivier Certner CommitDate: 2025-03-11 13:54:09 +0000 libsa: smbios: Use 64-bit entry point if table below 4GB on non-EFI boot On amd64, boot blocks and the non-EFI loader are 32-bit compiled as clients of BTX, so cannot access addresses beyond 4GB. However, the 64-bit entry point may refer to a structure table below 4GB, which we want to use if the BIOS does not provide a 32-bit entry point. The situation is similar for powerpc64. Consequently, always compile-in support for the 64-bit entry point, but ensure that it is not selected on 32-bit-compiled boot loaders if the structure table it points to grows beyond 4GB (as it is then not accessible). PR: 284460 Reviewed by: markj MFC after: 2 weeks Relnotes: yes Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D49288 --- stand/libsa/smbios.c | 37 ++++++++++++++----------------------- 1 file changed, 14 insertions(+), 23 deletions(-) diff --git a/stand/libsa/smbios.c b/stand/libsa/smbios.c index 2477c0ccf2d3..e0531eab01da 100644 --- a/stand/libsa/smbios.c +++ b/stand/libsa/smbios.c @@ -29,11 +29,6 @@ #define PTOV(x) ptov(x) -/* Only enable 64-bit entry point if it makes sense */ -#if __SIZEOF_POINTER__ > 4 -#define SMBIOS_64BIT_EP 1 -#endif - /* * Detect SMBIOS and export information about the SMBIOS into the * environment. @@ -145,9 +140,7 @@ SMBIOS_GET64(const caddr_t base, int off) struct smbios_attr { int probed; -#ifdef SMBIOS_64BIT_EP int is_64bit_ep; -#endif caddr_t addr; size_t length; size_t count; @@ -184,7 +177,6 @@ smbios_sigsearch(const caddr_t addr, const uint32_t len) /* Search on 16-byte boundaries. */ for (cp = addr; cp < addr + len; cp += SMBIOS_STEP) { -#ifdef SMBIOS_64BIT_EP /* v3.0, 64-bit Entry point */ if (strncmp(cp, SMBIOS3_SIG, sizeof(SMBIOS3_SIG) - 1) == 0 && /* @@ -195,10 +187,19 @@ smbios_sigsearch(const caddr_t addr, const uint32_t len) */ SMBIOS_GET8(cp, 0x0a) != 0 && smbios_checksum(cp, SMBIOS_GET8(cp, 0x06)) == 0) { +#ifdef __ILP32__ + uint64_t end_addr; + + end_addr = SMBIOS_GET64(cp, 0x10) + /* Start address. */ + SMBIOS_GET32(cp, 0x0c); /* Maximum size. */ + /* Is the table (or part of it) located above 4G? */ + if (end_addr >= (uint64_t)1 << 32) + /* Can't access it with 32-bit addressing. */ + continue; +#endif smbios.is_64bit_ep = 1; return (cp); } -#endif /* v2.1, 32-bit Entry point */ if (strncmp(cp, SMBIOS_SIG, sizeof(SMBIOS_SIG) - 1) == 0 && @@ -207,13 +208,9 @@ smbios_sigsearch(const caddr_t addr, const uint32_t len) smbios_checksum(cp + 0x10, 0x0f) == 0) { /* * Note that we saw this entry point, but don't return - * it right now on SMBIOS_64BIT_EP as we favor the 64-bit - * one if present. + * it right now as we favor the 64-bit one if present. */ v2_p = cp; -#ifndef SMBIOS_64BIT_EP - break; -#endif } } return (v2_p); @@ -586,7 +583,6 @@ smbios_probe(const caddr_t addr) if (saddr == NULL) return; -#ifdef SMBIOS_64BIT_EP if (smbios.is_64bit_ep) { /* Structure Table Length */ smbios.length = SMBIOS_GET32(saddr, 0x0c); @@ -601,9 +597,7 @@ smbios_probe(const caddr_t addr) smbios.ver = 0; maj_off = 0x07; min_off = 0x08; - } else -#endif - { + } else { /* Structure Table Length */ smbios.length = SMBIOS_GET16(saddr, 0x16); /* Structure Table Address */ @@ -661,11 +655,8 @@ smbios_detect(const caddr_t addr) dmi < smbios.addr + smbios.length && i < smbios.count; i++) dmi = smbios_parse_table(dmi); - setenv("smbios.entry_point_type", -#ifdef SMBIOS_64BIT_EP - smbios.is_64bit_ep ? "v3 (64-bit)" : -#endif - "v2.1 (32-bit)", 1); + setenv("smbios.entry_point_type", smbios.is_64bit_ep ? + "v3 (64-bit)" : "v2.1 (32-bit)", 1); sprintf(buf, "%d.%d", smbios.major, smbios.minor); setenv("smbios.version", buf, 1); if (smbios.enabled_memory > 0 || smbios.old_enabled_memory > 0) {