From nobody Tue Mar 11 14:04:36 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZBwVs1r3kz5qbpt; Tue, 11 Mar 2025 14:04:37 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZBwVr4sPYz3qqN; Tue, 11 Mar 2025 14:04:36 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1741701876; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=D40DhS7Ffy+DtjJTCcCBVW6U1S1aWvZl4ZXlnpDTe/U=; b=lLGSPV6a/BkCgEOnPPtIOoYRTosjusclT8cDZsLJgbB4LIN7sjIC8UKSR9UlmqkKVgmRCy freG+Rqv7H1BgKw/KXRCeLEaR+RsFng45YCngMCI4AcBw3H8jwkCa/bPmY740fIsgj6ciY bwEi97nQ/ZC6icvxHRRDFtIHVq4oIiRiN5u4gsqAqjEbnLnYKVTPbAi9eXHtunGixbckN/ ExnfNq8JqWSe92OMsVVhLwzdfJgILb5gz6amrTZzxV5LkyxoxkNbmWRO3J9YG3xxbmj12S EYIo8jrSe+jn/dCmrSKVUf8F3BDH+4uSTrzIj+tkT6DJNxpkqvIRVqQZ6znPlg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1741701876; a=rsa-sha256; cv=none; b=GTMXf4SrWc+vc5CER7B8at4sL+U9OiRUV8mqoxAkGb65W3YlwPlV0gyfjD4wtUqJtmgCB2 o+0SlZsGLahqWV5XTYmzrEbLJic+A+TWOmqbvKkvqa9lh3mOrU0jEffG2F4irE9IJl1f45 oCxmLDLZ9I1pfDUKkYQrv8fjq58BwcNaazUN3suCKqfLidm20bu5d+d3W3zq8SzdfFjq8P nXOYK21MaK+ZdMHpm8CsGg1pNZ7lGqiBGhYoshgmY+lJI0VH6/pB++BEStlK5qkz88h3S6 xKZt5yiRABKY0VJILrQw6EDyzovtxwJjNOAok2nRsxhm6aBh1u68aBbyBc7SBg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1741701876; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=D40DhS7Ffy+DtjJTCcCBVW6U1S1aWvZl4ZXlnpDTe/U=; b=TEY9AMvJ6ysr0yRUaV3zAYjsneMOz++fq51Gj4hMSKnO261NquT+6UHe64V+6NzfgPau2p CvhwJ3TOC8dObG0Kc/Ks2s6+vVGutApQQ2ONe60RByoaAdQs8jeJoYihVjuFTJYfOjOOuO bpi/fnOtVNTv6+jizZx2tQTiHpgrirRv5jcsf9Mj3gkSUqsbVe8Yr+xHHS1eOxc3qG+272 3ZLiN0aG6Rb+9nRuT83m9miL0wLEVvTOe5qZIgsitZRbsayzaBtcWmmM7pyRHBikNGI5dz yqW7WIV1kqUu9YBT1Wdi2pf3ynAK2xCDA/UqbIcNwqJDan+7tCDX+ljYjt4BWQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZBwVr4Sr2zD03; Tue, 11 Mar 2025 14:04:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 52BE4a2w028584; Tue, 11 Mar 2025 14:04:36 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 52BE4aAd028581; Tue, 11 Mar 2025 14:04:36 GMT (envelope-from git) Date: Tue, 11 Mar 2025 14:04:36 GMT Message-Id: <202503111404.52BE4aAd028581@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Olivier Certner Subject: git: a609592ddcdf - main - libsa: smbios: style(9): Entry point parsing comments List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: a609592ddcdf4e33a5126ffcdd12e6a609078d4c Auto-Submitted: auto-generated The branch main has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=a609592ddcdf4e33a5126ffcdd12e6a609078d4c commit a609592ddcdf4e33a5126ffcdd12e6a609078d4c Author: Olivier Certner AuthorDate: 2025-03-03 10:45:23 +0000 Commit: Olivier Certner CommitDate: 2025-03-11 13:54:07 +0000 libsa: smbios: style(9): Entry point parsing comments Move the comments so that lines stay of reasonable length. Remove comments that state the obvious. Reviewed by: markj MFC after: 2 weeks Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D49280 --- stand/libsa/smbios.c | 28 ++++++++++++++++++---------- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a/stand/libsa/smbios.c b/stand/libsa/smbios.c index a203d222bc79..4faec8c3aa01 100644 --- a/stand/libsa/smbios.c +++ b/stand/libsa/smbios.c @@ -563,19 +563,27 @@ smbios_probe(const caddr_t addr) #ifdef HAS_SMBV3 if (isv3) { - smbios.length = SMBIOS_GET32(saddr, 0x0c); /* Structure Table Length */ - paddr = SMBIOS_GET64(saddr, 0x10); /* Structure Table Address */ - smbios.count = -1; /* not present in V3 */ - smbios.ver = 0; /* not present in V3 */ + /* Structure Table Length */ + smbios.length = SMBIOS_GET32(saddr, 0x0c); + /* Structure Table Address */ + paddr = SMBIOS_GET64(saddr, 0x10); + /* not present in V3 */ + smbios.count = -1; + /* not present in V3 */ + smbios.ver = 0; maj_off = 0x07; min_off = 0x08; } else #endif { - smbios.length = SMBIOS_GET16(saddr, 0x16); /* Structure Table Length */ - paddr = SMBIOS_GET32(saddr, 0x18); /* Structure Table Address */ - smbios.count = SMBIOS_GET16(saddr, 0x1c); /* No of SMBIOS Structures */ - smbios.ver = SMBIOS_GET8(saddr, 0x1e); /* SMBIOS BCD Revision */ + /* Structure Table Length */ + smbios.length = SMBIOS_GET16(saddr, 0x16); + /* Structure Table Address */ + paddr = SMBIOS_GET32(saddr, 0x18); + /* No of SMBIOS Structures */ + smbios.count = SMBIOS_GET16(saddr, 0x1c); + /* SMBIOS BCD Revision */ + smbios.ver = SMBIOS_GET8(saddr, 0x1e); maj_off = 0x06; min_off = 0x07; } @@ -588,8 +596,8 @@ smbios_probe(const caddr_t addr) smbios.ver = 0; } if (smbios.ver == 0) { - smbios.major = SMBIOS_GET8(saddr, maj_off);/* SMBIOS Major Version */ - smbios.minor = SMBIOS_GET8(saddr, min_off);/* SMBIOS Minor Version */ + smbios.major = SMBIOS_GET8(saddr, maj_off); + smbios.minor = SMBIOS_GET8(saddr, min_off); } smbios.ver = (smbios.major << 8) | smbios.minor; smbios.addr = PTOV(paddr);