From nobody Mon Mar 10 20:02:32 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZBSVQ2yWpz5pb1j; Mon, 10 Mar 2025 20:02:38 +0000 (UTC) (envelope-from rpokala@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZBSVQ1HR3z3gGf; Mon, 10 Mar 2025 20:02:38 +0000 (UTC) (envelope-from rpokala@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1741636958; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dKNsboppeURkyk7NH96B3eCy8Ro29oFOKGyMzztS+eo=; b=xtpv9wScX9NEO7aCyE3XlEhGqdhtYNi0Y9yesVs5S5PwmBhsNlyVixvHuSKOO6hu2JgvEz xaSw29omrDKyxMKAG3VB6tO98MOjeLuiHqHnI5XYznuzPchHqbtuTskPSThqR6z2qPiFk4 axgu8uYP5kv9ESitQotrW/2OrIlU0NU1yI5+kBSc9oC+Vu9c33nf4bbgHbrtD2yZ23DF8J yJFDacctTDwNB60ZOVpJwT2IEGrG7SC/Bt+Bj+7n1kXhsN+bNWkPfrjfYOfSVVD60+OEvp A24VnxwmUT1MgW6mPb/fA2lhDdTPkTOWXK0UQlm/+mzMmq58SsuIjQJ5+Pub8A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1741636958; a=rsa-sha256; cv=none; b=Q4BNfbo+jxbjJMaEQQ5gadF3bIZuOv+qsR2Hzak8uE8/jhoLEPopj7lfKWLch3J1ranWGH cKeQnRl67H6z5xm3/KH0vkMXDUpfZpn7IN3492KS7yJeayDNuhWNNoO6a2BVvh/MBWy4HO KV5KZ/1TKk1R5d0/6f/wW182PfLQxtKM/1NeebwQEWE8cszZvlTe5EFNrbTQTt51edZ6Oa YszfOBx6WrjcAs2SukIXdF7gzKcPxSEcKzL7nN3fGd12+aFcLNJZw/NNgt/cdaE7Kl3Wrx UVgtmzrtRVoLzjgLHHiNL+RMR6zN0E4LZ1Ziaedj9I6YjA2vH9ZpFpvh1rsxBg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1741636958; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dKNsboppeURkyk7NH96B3eCy8Ro29oFOKGyMzztS+eo=; b=whCNRsHam24dTtsfz0nue5zNMkjEcc4C/dz7eD9ai74GpmtpyyT0ACYHgEpJoOyhKMkbLX PMlcZDnY+y6pUaCoafVij7l717OTaiZYa7GgT1vMCLsgLWK/0sFJhL0Jel9NY2Xce/jJiL g+ffDaAxDP2Pc8Vx1s5p1BvVIeKjGmE+Yf27hItGgzkQH7QOYDR2B3VYZ+u+kOGvUa0uvO 8MmwlOKMaE1k8qNHDFTD0VW34IxD+xm+n21CN01azsjR7qx8eYeo6WX2c64GDxIMFeDkAE fJmkwQjFbDcTc8RLovvXH5i2LErTU2Hawiv5Bx3PRlF8np/9qOCfxXaQN34nRg== Received: from [192.168.1.52] (c-73-231-46-254.hsd1.ca.comcast.net [73.231.46.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: rpokala) by smtp.freebsd.org (Postfix) with ESMTPSA id 4ZBSVP2Z3Mz1TJ; Mon, 10 Mar 2025 20:02:37 +0000 (UTC) (envelope-from rpokala@freebsd.org) User-Agent: Microsoft-MacOutlook/16.94.25022327 Date: Mon, 10 Mar 2025 13:02:32 -0700 Subject: Re: 78cd83e4017b - main - devclass_alloc_unit: Go back to using M_WAITOK From: Ravi Pokala To: John Baldwin , Ravi Pokala , , , Message-ID: <6DC2BB95-68EC-4710-AD36-7082FD52DC1A@panasas.com> Thread-Topic: 78cd83e4017b - main - devclass_alloc_unit: Go back to using M_WAITOK References: <202503101735.52AHZiu6027210@gitrepo.freebsd.org> <14C8991D-C686-48DC-9E5D-5F40CE1C75BB@panasas.com> <3ffc904b-7a14-412e-bf08-4703b00e3ffb@FreeBSD.org> In-Reply-To: <3ffc904b-7a14-412e-bf08-4703b00e3ffb@FreeBSD.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-version: 1.0 Content-type: text/plain; charset="UTF-8" Content-transfer-encoding: quoted-printable Ah, I see. Thanks, Ravi (rpokala@) =EF=BB=BF-----Original Message----- From: John Baldwin > Date: Monday, March 10, 2025 at 11:15 To: Ravi Pokala >, >, >, > Subject: Re: git: 78cd83e4017b - main - devclass_alloc_unit: Go back to usi= ng M_WAITOK On 3/10/25 13:41, Ravi Pokala wrote: > Hi John, >=20 >> This reverts commit 234683726708cf5212d672d676d30056d4133859. >=20 > The commit message for that change says that this allocation might be don= e while holding a lock, and so M_WAITOK is not valid. So then why is this ch= ange okay? >=20 > Thanks, Because the earlier commit to sdhci in this same push fixed it to create de= vices in a sleepable context. --=20 John Baldwin